Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All addresses text is not updated when changing accounts #19379

Merged
merged 6 commits into from
Mar 25, 2024
Merged

All addresses text is not updated when changing accounts #19379

merged 6 commits into from
Mar 25, 2024

Conversation

ibrkhalil
Copy link
Contributor

fixes #19374

Summary

Fixes an issue with the text that indicated the number of selected addresses in Edit shared addresses screen and Request to join screen

status: ready

@ibrkhalil ibrkhalil self-assigned this Mar 23, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 23, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 851e31c #1 2024-03-23 12:13:37 ~5 min tests 📄log
✔️ 851e31c #1 2024-03-23 12:13:53 ~6 min android-e2e 🤖apk 📲
✔️ 851e31c #1 2024-03-23 12:13:57 ~6 min android 🤖apk 📲
✔️ 851e31c #1 2024-03-23 12:17:09 ~9 min ios 📱ipa 📲
✔️ 289ea4f #2 2024-03-25 09:57:29 ~6 min android 🤖apk 📲
✔️ 289ea4f #2 2024-03-25 09:57:39 ~6 min tests 📄log
✔️ 289ea4f #2 2024-03-25 09:58:06 ~7 min android-e2e 🤖apk 📲
✔️ 289ea4f #2 2024-03-25 10:00:34 ~9 min ios 📱ipa 📲
✔️ 4bf56ec #4 2024-03-25 10:48:03 ~6 min tests 📄log
✔️ 4bf56ec #4 2024-03-25 10:48:13 ~6 min android 🤖apk 📲
✔️ 4bf56ec #4 2024-03-25 10:48:28 ~6 min android-e2e 🤖apk 📲
✔️ 4bf56ec #4 2024-03-25 10:52:28 ~10 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1fa2eef #5 2024-03-25 17:10:08 ~7 min android-e2e 🤖apk 📲
✔️ 1fa2eef #5 2024-03-25 17:10:13 ~7 min android 🤖apk 📲
✔️ 1fa2eef #5 2024-03-25 17:19:10 ~16 min ios 📱ipa 📲
✔️ 0d9fd6d #6 2024-03-25 19:43:18 ~6 min tests 📄log
✔️ 0d9fd6d #6 2024-03-25 19:43:27 ~6 min android-e2e 🤖apk 📲
✔️ 0d9fd6d #6 2024-03-25 19:45:25 ~8 min android 🤖apk 📲
✔️ 0d9fd6d #6 2024-03-25 19:46:26 ~9 min ios 📱ipa 📲

seanstrom
seanstrom approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! ✅

@qoqobolo qoqobolo self-assigned this Mar 25, 2024
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 703629,702730 

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Looking for community: 'open community'
    Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented 

    critical/chats/test_public_chat_browsing.py:1180: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_message_reaction, id: 702730

    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'Message sender')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2] 

    critical/chats/test_1_1_public_chats.py:73: in test_1_1_chat_message_reaction
    message_sender.emojis_below_message(emoji="thumbs-up").wait_for_element_text(1, 90)
../views/base_element.py:190: in wait_for_element_text
    self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: `2` is not equal to expected `1` in 90 sec



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_mute_community_and_channel, id: 703382
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    5. test_community_several_images_send_reply, id: 703194
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    10. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    11. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_add_contact_field_validation, id: 702777
    Device sessions

    3. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    6. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    @qoqobolo qoqobolo mentioned this pull request Mar 25, 2024
    Merged
    @qoqobolo
    Copy link
    Contributor

    Thanks a lot for the fix @ibrkhalil, PR can be merged.

    @ibrkhalil ibrkhalil merged commit 3be1532 into develop Mar 25, 2024
    6 checks passed
    @ibrkhalil ibrkhalil deleted the 19374 branch March 25, 2024 20:14
    ibrkhalil added a commit that referenced this pull request Mar 25, 2024
    @ibrkhalil
    All addresses text is not updated when changing accounts (#19379)
    dff2f57
    cammellos pushed a commit that referenced this pull request Mar 26, 2024
    @ibrkhalil @cammellos
    All addresses text is not updated when changing accounts (#19379)
    5ecd471
    mmilad75 pushed a commit that referenced this pull request Apr 2, 2024
    @ibrkhalil @mmilad75
    All addresses text is not updated when changing accounts (#19379)
    5e400f2
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jo-mut jo-mut jo-mut approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @seanstrom seanstrom seanstrom approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    @siddarthkay siddarthkay Awaiting requested review from siddarthkay

    Assignees

    @ibrkhalil ibrkhalil

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    "All addresses" text is not updated after unselecting some addresses for permissions
    6 participants
    @ibrkhalil @status-im-auto @qoqobolo @seanstrom @flexsurfer @jo-mut