-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send button and system messge icon based on chat/contact customization color #19558
Conversation
Jenkins BuildsClick to see older builds (23)
|
{contact-customization-color | ||
:customization-color} (when (= chat-type constants/one-to-one-chat-type) | ||
(rf/sub [:contacts/contact-by-address chat-id]))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we're using this sub a few times to only get the contact's customization color. Might be better to have a separate sub e.g. :contacts/customization-color-by-address
WDYT?
@@ -62,7 +66,7 @@ | |||
[quo/button | |||
{:icon-only? true | |||
:size 32 | |||
:customization-color customization-color | |||
:customization-color (or contact-customization-color color customization-color) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very confused by these variable names, they all seem the same. Can we change the names to provide a bit more of clarity why it's done this way?
b7ba08e
to
8d262f5
Compare
88% of end-end tests have passed
Failed tests (5)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
6c28d1e
to
40f5d6d
Compare
60% of end-end tests have passed
Failed tests (2)Click to expandClass TestDeepLinksOneDevice:
Passed tests (3)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
Hi @yqrashawn ! Tested - OK ✅ |
40f5d6d
to
3d997b8
Compare
Signed-off-by: yqrashawn <namy.19@gmail.com>
3d997b8
to
592dd6a
Compare
fixes #19503
fxies #18829
Summary
follow up of PR #19087
update system icon color based on chat contexts
Testing notes
I've tested one-one, group and community channel on iOS simulator
Platforms
Areas that maybe impacted
system message and send button color
status: ready