Wallet: Token Options should be specific to watch only account #18543 #19583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmilad75
requested review from
OmarBasem,
smohamedjavid,
J-Son89 and
vkjr
and removed request for
OmarBasem and
J-Son89
Jenkins BuildsClick to see older builds (20)
|
shivekkhurana
approved these changes
Apr 10, 2024
| [:show-bottom-sheet | ||
| {:content (fn [] [token-value-drawer item]) | ||
| :selected-item (fn [] [quo/token-value item])}])))]) | ||
| (merge item |
There was a problem hiding this comment.
This can go in as it as, but my preference is to use assoc when adding a single element to a map.
There was a problem hiding this comment.
or multiple as it's variadic, merge should only be used when the second argument is dynamic, but if the keys are hardcoded, assoc is much faster and more explicit
J-Son89
reviewed
Apr 10, 2024
| {:content (fn [] | ||
| (if watch-only? | ||
| [watch-only-token-value-drawer] | ||
| [token-value-drawer item])) |
There was a problem hiding this comment.
I would prefer we just have one token-value-drawer component and we filter/ configure the options based on certain props. That's how we do it in other parts of the codebase
There was a problem hiding this comment.
If you look up other uses of token-drawer you'll see what I mean.
The thing is that both of these watch only / regular account will likely share the same options and one is a subset of the other
J-Son89
reviewed
Apr 10, 2024
| (defn watch-only-token-value-drawer | ||
| [] | ||
| [quo/action-drawer | ||
| [[{:icon :i/settings |
There was a problem hiding this comment.
I think we want to stop adding features with "to be done".
They can be added but should be under a common feature flag/ a particular feature flag.
Cc @seanstrom @cammellos
There was a problem hiding this comment.
I would agree, yes, basically it should make sense to the user without being disruptive, so 99.99% of the times, a user would find confusing clicking on something and seeing "Not implemented" (and rather disappointing), with the only exception stuff like an entry "New feature (coming soon :) )" (i.e a teaser), but that's not the case here
There was a problem hiding this comment.
so hide everything (if you want to keep in development is up to us) behind a feature flag
| {:content (fn [] | ||
| (if watch-only? | ||
| [watch-only-token-value-drawer] | ||
| [token-value-drawer item])) |
There was a problem hiding this comment.
If you look up other uses of token-drawer you'll see what I mean.
The thing is that both of these watch only / regular account will likely share the same options and one is a subset of the other
mmilad75
force-pushed
the
milad/18543-add-token-options-to-watch-only-accounts
branch
from
faccc98 to
2c16353
Compare
|
@smohamedjavid |
OmarBasem
approved these changes
Apr 15, 2024
| @@ -47,7 +47,7 @@ | |||
| :image :icon | |||
| :image-props :i/derivated-path | |||
| :action :button | |||
| :action-props {:on-press #(if (ff/enabled? :ff/wallet.edit-derivation-path) | |||
| :action-props {:on-press #(if (ff/enabled? ::ff/wallet.edit-derivation-path) | |||
44% of end-end tests have passedFailed tests (28)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (23)Click to expandClass TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
J-Son89
approved these changes
Apr 15, 2024
VolodLytvynenko
force-pushed
the
milad/18543-add-token-options-to-watch-only-accounts
branch
from
517a8d8 to
031be1d
Compare
|
HI @mmilad75 , thank you for the PR. Could you take a look at the latest builds? It seems that the commits related to list with options related to watch only might not be included into last build PR_ISSUE 1: Drawer with a list of options not shown when tapping Watch-Only assetSteps:
Actual result:The drawer is not shown when the Watch-Only asset is long tapped watchonly.mp4Expected result:The drawer is shown when the Watch-Only asset is long-tapped OS:IOS, Android |
|
@mmilad75 could you please share the link to the Figma or Discord message where this feature is aligned with the design team? I'm trying to understand here which drawer should be shown for assets that belong to both watch-only and regular accounts, and the answer might be in the information you provide |
|
@mmilad75 Just noticed that the label has been changed to [skip-manual-qa]. Let me know if any manual tests are needed |
87% of end-end tests have passedFailed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
|
Because the features of this PR are hidden behind feature flags. So nothing should've been changed. |
This was decided with the dev team since the features of the drawer are not implemented. It should be brought back in near future. |
mmilad75
force-pushed
the
milad/18543-add-token-options-to-watch-only-accounts
branch
from
7c3c37f to
5a52677
Compare
mmilad75
deleted the
milad/18543-add-token-options-to-watch-only-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18543
Screen.Recording.2024-04-09.at.21.07.49.mov