Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add external icon to OpenSea button in collectible page #19647

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: add external icon to OpenSea button in collectible page #19647

merged 1 commit into from
Apr 17, 2024

Conversation

briansztamfater
Copy link
Member

fixes ?

From design review during offsite note:
16. [Collectibles] Open sea button on collectible detail page should have an arrow to represent an external link
Also fixed left icon color to comply with Figma designs.

Before Fix

Platforms

  • Android
  • iOS
Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Log in
  • Go to wallet tab
  • Go to collectibles > Select a collectible
  • Check OpenSea button has the external icon on the right and correct color for icon on the left

status: ready

@briansztamfater briansztamfater self-assigned this Apr 15, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 15, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 0b110c5 #1 2024-04-15 14:51:01 ~2 min tests 📄log
✔️ 0b110c5 #1 2024-04-15 14:55:39 ~7 min android-e2e 🤖apk 📲
✔️ 0b110c5 #1 2024-04-15 14:55:45 ~7 min android 🤖apk 📲
✔️ 0b110c5 #1 2024-04-15 14:58:41 ~10 min ios 📱ipa 📲
❌ 399a89d #2 2024-04-17 11:30:01 ~2 min tests 📄log
✔️ 399a89d #2 2024-04-17 11:35:51 ~8 min android-e2e 🤖apk 📲
✔️ 399a89d #2 2024-04-17 11:35:55 ~8 min android 🤖apk 📲
✔️ 399a89d #2 2024-04-17 11:45:28 ~17 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 6c2cc30 #3 2024-04-17 14:14:50 ~2 min tests 📄log
❌ 6c2cc30 #4 2024-04-17 14:19:24 ~2 min tests 📄log
✔️ 6c2cc30 #3 2024-04-17 14:20:20 ~7 min android-e2e 🤖apk 📲
✔️ 6c2cc30 #3 2024-04-17 14:20:26 ~7 min android 🤖apk 📲
✔️ 6c2cc30 #3 2024-04-17 14:22:51 ~10 min ios 📱ipa 📲
✔️ 7b62ac2 #5 2024-04-17 14:42:41 ~7 min tests 📄log
✔️ 7b62ac2 #4 2024-04-17 14:44:01 ~8 min android-e2e 🤖apk 📲
✔️ 7b62ac2 #4 2024-04-17 14:45:28 ~9 min android 🤖apk 📲
✔️ 7b62ac2 #4 2024-04-17 14:47:37 ~11 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 52
Failed tests: 0
Expected to fail tests: 2
Passed tests: 50

IDs of expected to fail tests: 703495,703503

Expected to fail tests (2)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495

# STEP: Change device time so chat will be unmuted by timer
Device 2: Long press on `ChatElement` 

critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

[[Chat is not unmuted after expected time: https://github.com//issues/19627]]

Device sessions

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503 

Test is not run, e2e blocker

[[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (50)

Click to expand

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions

2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions

3. test_community_mentions_push_notification, id: 702786
Device sessions

4. test_community_leave, id: 702845
Device sessions

5. test_community_join_when_node_owner_offline, id: 703629
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device sessions

2. test_wallet_send_eth, id: 727229
Device sessions

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions

2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions

2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions

3. test_group_chat_reactions, id: 703202
Device sessions

4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions

5. test_group_chat_offline_pn, id: 702808
Device sessions

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions

2. test_community_one_image_send_reply, id: 702859
Device sessions

3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions

4. test_community_mark_all_messages_as_read, id: 703086
Device sessions

5. test_community_contact_block_unblock_offline, id: 702894
Device sessions

6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions

7. test_community_message_delete, id: 702839
Device sessions

8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions

9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions

10. test_community_message_edit, id: 702843
Device sessions

11. test_community_unread_messages_badge, id: 702841
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

2. test_wallet_add_remove_watch_only_account, id: 727232
Device sessions

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions

2. test_links_deep_links, id: 702775
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions

2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions

3. test_1_1_chat_mute_chat, id: 703496
Device sessions

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions

2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions

2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions

3. test_activity_center_contact_request_decline, id: 702850
Device sessions

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions

2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions

3. test_1_1_chat_push_emoji, id: 702813
Device sessions

4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

5. test_1_1_chat_edit_message, id: 702855
Device sessions

6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions

7. test_1_1_chat_pin_messages, id: 702731
Device sessions

8. test_1_1_chat_message_reaction, id: 702730
Device sessions

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

3. test_community_undo_delete_message, id: 702869
Device sessions

4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions

5. test_community_mute_community_and_channel, id: 703382
Device sessions

@J-Son89
Copy link
Contributor

J-Son89 commented Apr 15, 2024

No point taking notes at this rate :) 🚀 👟

@mariia-skrypnyk mariia-skrypnyk self-assigned this Apr 17, 2024
@mariia-skrypnyk mariia-skrypnyk force-pushed the fix/opensea-external-icon branch from 0b110c5 to 399a89d Compare April 17, 2024 11:27
@mariia-skrypnyk
Copy link

Hi @briansztamfater !
Thank you for the speed and quality!
Send PR to review by @Francesca-G .

@J-Son89
Copy link
Contributor

J-Son89 commented Apr 17, 2024

Hi @briansztamfater !

Thank you for the speed and quality!

Send PR to review by @Francesca-G .

I think given this pr is so small in scope and the icon is generic that we can skip design review for this page just yet 👍
Cc @Francesca-G

@briansztamfater briansztamfater force-pushed the fix/opensea-external-icon branch from 399a89d to 6c2cc30 Compare April 17, 2024 14:12
@briansztamfater
fix: add external icon to OpenSea button in collectible page
7b62ac2 
Signed-off-by: Brian Sztamfater <brian@status.im>
@briansztamfater briansztamfater force-pushed the fix/opensea-external-icon branch from 6c2cc30 to 7b62ac2 Compare April 17, 2024 14:35
@briansztamfater briansztamfater merged commit d12c05a into develop Apr 17, 2024
6 checks passed
@briansztamfater briansztamfater deleted the fix/opensea-external-icon branch April 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulisesmac ulisesmac ulisesmac approved these changes

@smohamedjavid smohamedjavid smohamedjavid approved these changes

@shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

@vkjr vkjr Awaiting requested review from vkjr

@FFFra FFFra Awaiting requested review from FFFra

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

@J-Son89 J-Son89 Awaiting requested review from J-Son89

@mmilad75 mmilad75 Awaiting requested review from mmilad75

Assignees

@briansztamfater briansztamfater

@mariia-skrypnyk mariia-skrypnyk

Labels
request-manual-qa Tested - OK
Projects
Pipeline for QA
Archived in project
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@briansztamfater @status-im-auto @J-Son89 @mariia-skrypnyk @smohamedjavid @ulisesmac