Display private permissions only when the requirements are met #19675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (26)
|
ajayesivan
requested review from
ilmotta,
cammellos,
ibrkhalil and
BalogunofAfrica
ibrkhalil
reviewed
Apr 16, 2024
src/status_im/subs/communities.cljs
Outdated
Comment on lines
334
to
340
| (defn visible-criteria | ||
| [criteria] | ||
| (filter (fn [{:keys [isPrivate criteria]}] | ||
| (or (not isPrivate) (every? identity criteria))) | ||
| criteria)) |
There was a problem hiding this comment.
It's very confusing that we have the argument name and the destructured name the same.
criteria can be destructured differently.
src/status_im/subs/communities.cljs
Outdated
| (defn visible-criteria | ||
| [criteria] | ||
| (filter (fn [{:keys [isPrivate criteria]}] | ||
| (or (not isPrivate) (every? identity criteria))) |
There was a problem hiding this comment.
Why not?
(every? true? [...])
ajayesivan
force-pushed
the
19606-hide-private-permissions
branch
5 times, most recently
from
fbe92ee to
c8673f1
Compare
ilmotta
approved these changes
Apr 17, 2024
96% of end-end tests have passedExpected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (50)Click to expandClass TestWalletMultipleDevice:
Class TestActivityMultipleDevicePR:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
|
|
@ajayesivan thanks for the PR! could you please rebase go and mobile branches? thanks. |
|
Also, please add status-go label to PRs which contain changes on go side. |
ajayesivan
force-pushed
the
19606-hide-private-permissions
branch
from
c8673f1 to
d5fa5c0
Compare
|
@pavloburykh I have rebased both go & mobile branches |
|
@ajayesivan thank you for the PR! LGTM on Android. |
ajayesivan
force-pushed
the
19606-hide-private-permissions
branch
from
d5fa5c0 to
1afc747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19606
status-go pr: status-im/status-go#5059
Hide private permissions when they are not satisfied.
In the below community member permissions, the second and last permissions are private. So those permissions should only be displayed to the user when the user holds the required tokens.
Community overview screen
Non-member permissions are always private
Community permissions sheet
Areas affected
status: ready