Amount input field is highlighted red despite valid amount is entered #19372 #19711

mmilad75 · 2024-04-18T11:14:07Z

fixes #19372

The issue was that the operator > was expecting number but in some cases, a string was passed to it.

status-im-auto · 2024-04-18T11:19:00Z

Jenkins Builds

Click to see older builds (7)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`409f28e`	#1	2024-04-18 11:18:59	~4 min	`tests`	📄`log`
✔️	`409f28e`	#1	2024-04-18 11:21:28	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`409f28e`	#1	2024-04-18 11:21:42	~7 min	`android`	🤖`apk` 📲
✔️	`409f28e`	#1	2024-04-18 11:24:50	~10 min	`ios`	📱`ipa` 📲

✔️	`2f5c3f1`	#2	2024-04-18 13:02:07	~5 min	`tests`	📄`log`
✔️	`2f5c3f1`	#2	2024-04-18 13:02:12	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`2f5c3f1`	#2	2024-04-18 13:03:34	~7 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`06fe6a5`	#3	2024-04-18 13:19:01	~3 min	`tests`	📄`log`
✔️	`06fe6a5`	#3	2024-04-18 13:20:58	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`06fe6a5`	#3	2024-04-18 13:21:11	~6 min	`android`	🤖`apk` 📲
✔️	`06fe6a5`	#3	2024-04-18 13:24:33	~9 min	`ios`	📱`ipa` 📲

✔️	`6700d65`	#4	2024-04-18 15:21:54	~4 min	`tests`	📄`log`
✔️	`6700d65`	#4	2024-04-18 15:23:22	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`6700d65`	#4	2024-04-18 15:24:26	~7 min	`android`	🤖`apk` 📲
✔️	`6700d65`	#4	2024-04-18 15:33:49	~16 min	`ios`	📱`ipa` 📲

ulisesmac

Cool 👍

src/status_im/contexts/wallet/send/input_amount/view.cljs

status-im-auto · 2024-04-18T16:48:32Z

94% of end-end tests have passed

Total executed tests: 52
Failed tests: 1
Expected to fail tests: 2
Passed tests: 49

IDs of failed tests: 702851

IDs of expected to fail tests: 703495,703503

Failed tests (1)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 1: Tap on found: Button
# STEP: Device1 check that contact appeared in contact list mutually

../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
E   http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:
activity_center/test_activity_center.py:141: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.just_fyi('Device1 check that contact appeared in contact list mutually')
../views/base_view.py:409: in just_fyi
    self.driver.execute_script("sauce:context=STEP: %s" % some_str)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:405: in execute_script
    return self.execute(command, {"script": script, "args": converted_args})["value"]
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
    response = self.command_executor.execute(driver_command, params)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
    return self._request(command_info[0], url, body=data)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
    response = self._conn.request(method, url, body=body, headers=headers)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/request.py:78: in request
    return self.request_encode_body(
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
    retries = retries.increment(
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
    raise six.reraise(type(error), error, _stacktrace)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
    raise value.with_traceback(tb)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
 ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Expected to fail tests (2)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` `critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout` [[Chat is not unmuted after expected time: https://github.com//issues/19627]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Passed tests (49)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs
2. test_wallet_add_remove_watch_only_account, id: 727232
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

pavloburykh · 2024-04-19T12:28:16Z

Wlll continue testing once #19729 is fixed (see ISSUE 2 Wrong font colour of amount value)

pavloburykh · 2024-04-24T14:18:12Z

Hey @mmilad75. Could you please rebase the PR and resolve conflicts? After that I will continue with testing. Thank you.

mmilad75 · 2024-04-25T13:50:15Z

Hey @mmilad75. Could you please rebase the PR and resolve conflicts? After that I will continue with testing. Thank you.

The issue that was solved here is already solved in another PR. I will close the PR now

fix issue

409f28e

mmilad75 requested review from ulisesmac, ilmotta, briansztamfater, smohamedjavid, J-Son89, VolodLytvynenko and vkjr and removed request for VolodLytvynenko April 18, 2024 11:14

mmilad75 self-assigned this Apr 18, 2024

ulisesmac approved these changes Apr 18, 2024

View reviewed changes

briansztamfater reviewed Apr 18, 2024

View reviewed changes

src/status_im/contexts/wallet/send/input_amount/view.cljs Outdated Show resolved Hide resolved

replace js/parseFloat with money/bignumber

2f5c3f1

mmilad75 requested a review from briansztamfater April 18, 2024 12:56

Merge branch 'develop' into milad/19372-fix-amount-input-error

06fe6a5

briansztamfater approved these changes Apr 18, 2024

View reviewed changes

smohamedjavid approved these changes Apr 18, 2024

View reviewed changes

mmilad75 added the request-manual-qa label Apr 18, 2024

Merge branch 'develop' into milad/19372-fix-amount-input-error

6700d65

pavloburykh self-assigned this Apr 19, 2024

pavloburykh added the blocked label Apr 19, 2024

ilmotta approved these changes Apr 19, 2024

View reviewed changes

pavloburykh removed the blocked label Apr 24, 2024

pavloburykh mentioned this pull request Apr 25, 2024

Fix for "no routes found" on transaction confirmation page #19789

Merged

VolodLytvynenko self-assigned this Apr 25, 2024

mmilad75 closed this Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amount input field is highlighted red despite valid amount is entered #19372 #19711

Amount input field is highlighted red despite valid amount is entered #19372 #19711

mmilad75 commented Apr 18, 2024

status-im-auto commented Apr 18, 2024 •

edited

Loading

ulisesmac left a comment

status-im-auto commented Apr 18, 2024

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestWalletOneDevice:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Apr 19, 2024

pavloburykh commented Apr 24, 2024 •

edited

Loading

mmilad75 commented Apr 25, 2024

Amount input field is highlighted red despite valid amount is entered #19372 #19711

Amount input field is highlighted red despite valid amount is entered #19372 #19711

Conversation

mmilad75 commented Apr 18, 2024

status-im-auto commented Apr 18, 2024 • edited Loading

Jenkins Builds

ulisesmac left a comment

Choose a reason for hiding this comment

status-im-auto commented Apr 18, 2024

94% of end-end tests have passed

Failed tests (1)

Class TestActivityCenterContactRequestMultipleDevicePR:

Expected to fail tests (2)

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (49)

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestWalletOneDevice:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Apr 19, 2024

pavloburykh commented Apr 24, 2024 • edited Loading

mmilad75 commented Apr 25, 2024

status-im-auto commented Apr 18, 2024 •

edited

Loading

pavloburykh commented Apr 24, 2024 •

edited

Loading