[iOS Only] Enable new architecture for react-native #19748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
7 tasks
Jenkins BuildsClick to see older builds (60)
|
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
2 times, most recently
from
8559bfb to
21a54d6
Compare
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
3 times, most recently
from
9dc3482 to
2888613
Compare
siddarthkay
requested review from
flexsurfer,
ilmotta,
shivekkhurana,
alwx,
OmarBasem,
ulisesmac and
vkjr
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
from
2888613 to
0f70fa3
Compare
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
3 times, most recently
from
c671cec to
77ce308
Compare
jakubgs
approved these changes
Apr 24, 2024
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
2 times, most recently
from
d7de816 to
cb05db7
Compare
|
@status-im/mobile-qa : we just need a smoke test for this PR since we enable new architecture only for iOS |
|
This looks like a small footprint PR, but just so that everyone is aware in case it causes subtle issues. cc @J-Son89 @smohamedjavid @clauxx |
|
iOS build works perfectly, but |
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
2 times, most recently
from
6d4d582 to
292e65a
Compare
|
@ajayesivan : thanks for testing this locally. I fixed it with latest push. |
BalogunofAfrica
approved these changes
Apr 25, 2024
|
@siddarthkay Should this PR also address upgrades we need to do for the new arch as noted here: #18138 (comment) |
90% of end-end tests have passedFailed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (47)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Hi @BalogunofAfrica : good question, We can do those upgrades gradually in separate PRs. 
I was able to set my profile picture and send an image in chat which uses atleast 2 of these "must upgrade" libs. Currently I am waiting on @status-im/mobile-qa to give me the green light to merge this PR. |
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
6 times, most recently
from
d125a45 to
fe0e2f6
Compare
clauxx
approved these changes
Apr 30, 2024
This commit enables `Fabric` and `Hermes` for `iOS` and in my initial tests the app seemed to behave well. We can't do this for Android yet because the blur view implementation is not ported to `Fabric` properly. needed for #18138 Please check builds from this PR to see if you notice any performance improvements or degradation. Please smoke test the iOS builds to see if there are any crashes. - iOS status: ready
siddarthkay
force-pushed
the
try-to-enable-new-architecture
branch
from
fe0e2f6 to
9f02b1d
Compare
|
Tested on IOS, no new issues found, PR is ready, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables
FabricandHermesforiOSand in my initial tests the app seemed to behave well.We can't do this for Android yet because the blur view implementation is not ported to
Fabricproperly.needed for #18138
Review notes
Please check builds from this PR to see if you notice any performance improvements or degradation.
Testing notes
Please smoke test the iOS builds to see if there are any crashes.
Platforms
status: ready