nuke react-native-mail and move over the logic to our native modules #19760
Conversation
siddarthkay
force-pushed
the
nuke-rn-mail
branch
from
6a27333 to
e8f3f93
Compare
Jenkins BuildsClick to see older builds (16)
|
siddarthkay
force-pushed
the
nuke-rn-mail
branch
from
e8f3f93 to
3dd3690
Compare
There was a problem hiding this comment.
I'm not sure if this functionality should go into NetworkManager files, rather than into its own files for easier removal in the future if need be. But that's up for mobile devs to decide.
Also, do we even use this library? Does anyone actually read the emails this genereates?
Wouldn't it be easier just to take someone to github issues page?
Good question!, @status-im/mobile-qa might know
Yes thats a good idea |
siddarthkay
force-pushed
the
nuke-rn-mail
branch
from
3dd3690 to
4d767eb
Compare
|
as far as I understand the question, we need theses emails, as they have logs attached to them. We use it a lot. If there is another mechanizm, it is OK to substitute it, but the main requirement is to be able to extract logs on shake and share them fast (the mean doesn't matter that much) |
1 similar comment
|
as far as I understand the question, we need theses emails, as they have logs attached to them. We use it a lot. If there is another mechanizm, it is OK to substitute it, but the main requirement is to be able to extract logs on shake and share them fast (the mean doesn't matter that much) |
siddarthkay
force-pushed
the
nuke-rn-mail
branch
2 times, most recently
from
08f36a0 to
d16f14e
Compare
|
tested on android simulator and hence using |
In this commit we nuke the unmaintained library `react-native-mail` and move over the logic to our native modules. This also helps to fix `make nix-update-gradle` which would fail because of that library. - Android - iOS status: ready
siddarthkay
force-pushed
the
nuke-rn-mail
branch
from
d16f14e to
953825c
Compare
In this commit we nuke the unmaintained library `react-native-mail` and move over the logic to our native modules. This also helps to fix `make nix-update-gradle` which would fail because of that library. - Android - iOS status: ready
Summary
In this PR we nuke the unmaintained library
react-native-mailand move over the logic to our native modules.This also helps to fix
make nix-update-gradlewhich would fail because of that library.Platforms
status: ready