fix: store node are not available on ios #19785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (12)
|
jo-mut
force-pushed
the
bug/store-nodes-issue
branch
from
028e60b to
92f2554
Compare
jo-mut
force-pushed
the
bug/store-nodes-issue
branch
from
92f2554 to
070d114
Compare
jo-mut
force-pushed
the
bug/store-nodes-issue
branch
from
070d114 to
a90d6dc
Compare
jo-mut
force-pushed
the
bug/store-nodes-issue
branch
from
a90d6dc to
b27df1c
Compare
|
closing this as there is a better approach to solving it in this pr https://github.com/status-im/status-mobile/pull/19798/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19736
Summary
After bumbing golang to 1.20 we experience a dns resolution failure which was fixed on specifically for android by overriding DefaultResolver in the net package as mentioned here #19581 (comment). This pr extends overriding the dns default resolver to iOS devices which fixes the availability of store nodes issue on ios devices
Before and after screenshots comparison
status: ready wip