Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak: hide not-implemented actions from the chat-home screen #19844

Merged
merged 1 commit into from
May 1, 2024
Merged

tweak: hide not-implemented actions from the chat-home screen #19844

merged 1 commit into from
May 1, 2024

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Apr 30, 2024 •
edited
Loading

Summary

  • This PR attempts to temporarily hide not-implemented actions from the chat home screen.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Action menus inside the chat-home screen
  • Action menus inside 1-1 chats
  • Action menus inside group chats

Steps to test

To test these changes it's required that:

  • the user account is in a group
  • the user account has at least one contact
  • the user account has a recent 1-1 chat
  • the user account is in a community they've created

Steps to reproduce

Note, if these steps to reproduce are vague, then the provided screen captures could be helpful for finding the different actions in the app from the chat home screen.

  • Open the Status mobile app
  • Navigate to the chat home screen
    • Long-press on one item under each of the tabs for "Recent", "Groups", and "Contacts".
      • This should open the action menu for that item
    • Open each item of those items and open the actions menu.

Before and after screenshots comparison

1-1 Chat Actions

Before After
Chat.Actions.-.Before.mov
Chat.Actions.-.After.mov

Group Chat Actions

Before After
Group.Actions.-.Before.mov
Group.Actions.-.After.mov

Contact Actions

Before After
Contact.Actions.-.Before.mov
Contact.Actions.-.After.mov

status: ready

@seanstrom seanstrom self-assigned this Apr 30, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 30, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 2f21377 #1 2024-04-30 14:30:11 ~2 min tests 📄log
✔️ 2f21377 #1 2024-04-30 14:34:43 ~7 min android 🤖apk 📲
✔️ 2f21377 #1 2024-04-30 14:34:47 ~7 min android-e2e 🤖apk 📲
✔️ 2f21377 #1 2024-04-30 14:36:22 ~8 min ios 📱ipa 📲
✔️ 8b362dc #2 2024-05-01 08:42:06 ~4 min tests 📄log
✔️ 8b362dc #2 2024-05-01 08:43:35 ~5 min android-e2e 🤖apk 📲
✔️ 8b362dc #2 2024-05-01 08:44:45 ~6 min android 🤖apk 📲
✔️ 8b362dc #2 2024-05-01 08:46:11 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 595dfc6 #3 2024-05-01 15:32:38 ~4 min tests 📄log
✔️ 595dfc6 #3 2024-05-01 15:34:24 ~6 min android 🤖apk 📲
✔️ 595dfc6 #3 2024-05-01 15:35:19 ~7 min android-e2e 🤖apk 📲
✔️ 595dfc6 #3 2024-05-01 15:36:51 ~8 min ios 📱ipa 📲
✔️ 909ea3a #4 2024-05-01 16:48:08 ~3 min tests 📄log
✔️ 909ea3a #4 2024-05-01 16:49:58 ~5 min android-e2e 🤖apk 📲
✔️ 909ea3a #4 2024-05-01 16:52:37 ~8 min ios 📱ipa 📲
✔️ 909ea3a #4 2024-05-01 16:52:40 ~8 min android 🤖apk 📲

@seanstrom seanstrom changed the title tweak: hide any not-implemented actions inside home tweak: hide not-implemented actions from the chat-home screen May 1, 2024
@seanstrom seanstrom requested review from flexsurfer and ibrkhalil May 1, 2024 07:52
@flexsurfer
Copy link
Member

you need to fix lint

@seanstrom seanstrom force-pushed the seanstrom/hide-not-implemented-actions-from-home branch from 2f21377 to 8b362dc Compare May 1, 2024 08:37
@seanstrom seanstrom force-pushed the seanstrom/hide-not-implemented-actions-from-home branch from 8b362dc to 595dfc6 Compare May 1, 2024 15:27
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 2
Passed tests: 47

IDs of failed tests: 727230,702783,703391 

IDs of expected to fail tests: 703495,703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find `Button` by `accessibility id`: `image-0`
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Long press on AssetElement
    Device 1: Find EditBox by accessibility id: address-text-input 

    critical/test_wallet.py:123: in test_wallet_send_asset_from_drawer
    self.wallet_1.send_asset_from_drawer(address=self.receiver['address'], asset_name='Ether',
../views/wallet_view.py:104: in send_asset_from_drawer
    self.address_text_input.send_keys(address)
../views/base_element.py:377: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `address-text-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    Device 2: Find Text by xpath: //*[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_1_1_public_chats.py:614: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to Delivered, it's Sent after back up online!



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (47)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @seanstrom
    Copy link
    Member Author

    @status-im/mobile-qa can you review these E2E results please? 🙏

    @VolodLytvynenko
    Copy link
    Contributor

    Hi @seanstrom
    The e2e results are reviewed, the failed tests are not related to the PR.
    PR can proceed to the next stage.

    @seanstrom seanstrom force-pushed the seanstrom/hide-not-implemented-actions-from-home branch from 595dfc6 to 909ea3a Compare May 1, 2024 16:43
    @seanstrom seanstrom merged commit 3951b8a into develop May 1, 2024
    6 checks passed
    @seanstrom seanstrom deleted the seanstrom/hide-not-implemented-actions-from-home branch May 1, 2024 17:02
    This was referenced May 3, 2024
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees

    @seanstrom seanstrom

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @seanstrom @status-im-auto @flexsurfer @VolodLytvynenko @ibrkhalil