-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement network settings for wallet settings #19995
Implement network settings for wallet settings #19995
Conversation
Jenkins BuildsClick to see older builds (29)
|
85ff4a7
to
b1a853d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review comments 📖
src/status_im/contexts/settings/wallet/network_settings/testnet_mode/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/network_settings/view.cljs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ✅
Non blocking comments
src/status_im/contexts/settings/wallet/network_settings/style.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/network_settings/testnet_mode/style.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/network_settings/testnet_mode/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/network_settings/testnet_mode/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/network_settings/testnet_mode/view.cljs
Show resolved
Hide resolved
b1a853d
to
a72e3e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
e59928a
to
f4ad99b
Compare
f4ad99b
to
165cadb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
src/status_im/contexts/settings/wallet/network_settings/testnet_mode/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/network_settings/testnet_mode/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/wallet_options/view.cljs
Outdated
Show resolved
Hide resolved
165cadb
to
59d3fa7
Compare
69% of end-end tests have passed
Failed tests (14)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (36)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀
Hi @seanstrom ! |
thank you @mariia-skrypnyk 🙏 |
091826f
to
6b59dcc
Compare
@mariia-skrypnyk okie dokie 🧑🌾 conflicts should be resolved 🟢 |
73% of end-end tests have passed
Failed tests (12)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (38)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
|
58% of end-end tests have passed
Failed tests (5)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Passed tests (7)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
# Conflicts: # src/status_im/feature_flags.cljs
6b59dcc
to
490326b
Compare
@status-im/mobile-qa can you review these E2E results please? 🙏 |
Hi @seanstrom ! Thanks for patience, needed to rerun again to be sure every fail is known. Great job as always 🙌 |
Thank you @mariia-skrypnyk 🙌 |
Note: this PR is |
fixes #19924
fixes #19925
Summary
Testing notes
ENABLE_ALERT_BANNER
is set to1
in the.env
file.ENABLE_ALERT_BANNER
should already be activated.Platforms
Areas that maybe impacted
Functional
Steps to test
wallet-settings
andnetwork-settings
feature flags are activeBefore and after screenshots comparison
After changes
Screen.Recording.2024-05-14.at.14.58.16.mov
Screen.Recording.2024-05-14.at.15.32.36.mov
status: ready