fix: non supported network warning is shown on the bridge flow #20098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (32)
|
briansztamfater
force-pushed
the
fix/bridge-not-supported-network
branch
3 times, most recently
from
7bf2970 to
17be57b
Compare
briansztamfater
requested review from
vkjr,
J-Son89,
OmarBasem,
BalogunofAfrica,
mmilad75 and
ulisesmac
briansztamfater
changed the title
J-Son89
reviewed
May 20, 2024
| [quo/network-list | ||
| {:label (name network-name) | ||
| {:theme theme |
There was a problem hiding this comment.
we don't need to pass theme this way. The provider does it.
The problem in that component is the schema was not updated to remove it.
There was a problem hiding this comment.
There was a problem hiding this comment.
Nice, the solely purpose of adding this change was to remove schema errors. I'll remove this and update the schema then
There was a problem hiding this comment.
yep for sure, but just as an FYI passing theme as a prop will actually do nothing because the component gets it from the context provider.
you'll have to remove in the respective component test too 👍
J-Son89
reviewed
May 20, 2024
| token-networks (network-utils/network-list token networks) | ||
| token-networks-ids (mapv #(:chain-id %) token-networks) | ||
| token-networks-ids-set (set token-networks-ids) | ||
| token-available-on-network? (contains? token-networks-ids-set chain-id)] |
There was a problem hiding this comment.
do you really need token-networks, token-networks-ids, token-networks-ids-set?
seems like this should all be done in the sub for token-available-on-network? ??
There was a problem hiding this comment.
or at least a util for that 🤔
There was a problem hiding this comment.
imo the let binding should just include the minimal data needed by the view's props. Other data can be taken out to utils or subs
Also this can help with allowing us to write tests for the underlying logic that prepares the props
There was a problem hiding this comment.
Yep, simplified the approach
J-Son89
approved these changes
May 20, 2024
briansztamfater
force-pushed
the
fix/bridge-not-supported-network
branch
from
17be57b to
7bd7278
Compare
Comment on lines
230
to
233
| token-not-supported-in-receiver-networks? (and (not= tx-type :tx/bridge) | ||
| (every? #(= (:type %) :not-available) | ||
| (filter #(not= (:type %) :add) | ||
| receiver-network-values))) |
There was a problem hiding this comment.
I think that every and filter operation can be simplified with threading for readability. What do you think?
token-not-supported-in-receiver-networks? (and (not= tx-type :tx/bridge)
(->> receiver-network-values
(remove #(= (:type %) :add))
(every? #(= (:type %) :not-available))))There was a problem hiding this comment.
Thanks for the suggestion, updated!
briansztamfater
force-pushed
the
fix/bridge-not-supported-network
branch
3 times, most recently
from
5f258ca to
6d88b52
Compare
83% of end-end tests have passedFailed tests (8)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (43)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
OmarBasem
approved these changes
May 22, 2024
mariia-skrypnyk
force-pushed
the
fix/bridge-not-supported-network
branch
from
6d88b52 to
c7cf202
Compare
briansztamfater
force-pushed
the
fix/bridge-not-supported-network
branch
2 times, most recently
from
2093d44 to
c0f02be
Compare
BalogunofAfrica
approved these changes
May 24, 2024
|
Hey @briansztamfater, thanks for the fix! ISSUE 1: Cursor disappears from the amount field when you start typingIt appears again if you set the focus on the field by tapping it Steps:
Actual result (PR): video_2024-05-24_15-51-57.mp4Expected result (nightly): kekkekeke.mp4 |
|
Hey @qoqobolo thanks for testing! Does that only happens on Android or also on iOS? |
@briansztamfater Should we open an issue instead? seems this input has been changed and now is having problems |
|
Actually, I was able to reproduce it on develop on iOS Simulator. I think this was introduced after merging #20099. Can you please check @qoqobolo? If it a new issue, yes, we should log it and work on it separately @ulisesmac cc @J-Son89 |
@briansztamfater yep, I can see this issue now on today's nightly, will log it separately. |
briansztamfater
force-pushed
the
fix/bridge-not-supported-network
branch
2 times, most recently
from
96c9eae to
08dac03
Compare
Signed-off-by: Brian Sztamfater <brian@status.im>
briansztamfater
force-pushed
the
fix/bridge-not-supported-network
branch
from
08dac03 to
823ff32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20080
Summary
This PR fixes warning about non supported networks being shown in the bridge flow, and disables unavailable networks for token in the
Bridge token toscreen.Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready