chore(wallet): hide share button on scanner page #20105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Son89
requested review from
briansztamfater,
OmarBasem,
mohsen-ghafouri,
seanstrom and
vkjr
|
@status-im/mobile-qa - I will skip manual qa here as it is just hiding a button on a page. Should be relatively safe 👍 |
Jenkins BuildsClick to see older builds (21)
|
OmarBasem
reviewed
May 20, 2024
| @@ -28,6 +28,7 @@ | |||
| [scan-qr-code/view | |||
| {:title (i18n/label :t/scan-qr) | |||
| :subtitle (i18n/label :t/scan-an-account-qr-code) | |||
| :share-button? false | |||
There was a problem hiding this comment.
I think this is redundant since if it is not passed its value would be nil
Also, I see we have 3 instances of scan-qr-code/view so we need to pass :share-button? true to the ones where we need the share button (?)
There was a problem hiding this comment.
yeah, you're right. I'll swap the order of this and set the other ones to true and remove this 👍
thanks!
There was a problem hiding this comment.
actually I think the other instances don't need it. Only the universal scanner does
mohsen-ghafouri
approved these changes
May 20, 2024
OmarBasem
approved these changes
May 20, 2024
vkjr
approved these changes
May 20, 2024
briansztamfater
approved these changes
May 20, 2024
|
@status-im/mobile-qa - lmk how the e2e look :) |
87% of end-end tests have passedFailed tests (5)Click to expandClass TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
|
|
@status-im/mobile-qa - e2e look alright? :) |
Yes, e2e failures are not related, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #20104
This pr hides the share button on the scanners used in the following wallet flows.
design ref https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Descoped-Wallet?node-id=689-193099&t=2FynnrOKOXUQjmFn-4
Sending - select an address
Add a watch address
Before
After
