feat!: add key pairs and accounts settings to wallet settings #20464
Conversation
Jenkins BuildsClick to see older builds (76)
|
src/status_im/contexts/settings/wallet/wallet_options/view.cljs
Outdated
Show resolved
Hide resolved
seanstrom
force-pushed
the
seanstrom/unflag-key-pairs-and-accounts
branch
from
2d42cba to
612562f
Compare
76% of end-end tests have passedFailed tests (8)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (39)Click to expandClass TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
@seanstrom thanks for the PR. Please take a look at the issues. ISSUE 1 Save button is overlapped by keyboard on "Rename key pair" screen when Testnet banner is enabled (IOS)IOS ONLY Reproducing on iPhone X, IOS 16.7.7 Steps:
Actual result: Save button is overlapped by keyboard
|
|
@pavloburykh thanks for finding that issue 🙌 I've updated the rename key-pair screen to use the full-screen modal appearance, and I've made sure the button is visible when the keyboard is displayed too. Let me know if that resolves the issue please 🙏 Here's a screen recording of the changes that I made: Screen.Recording.2024-06-19.at.11.03.21.mov |
|
Hey @seanstrom! thank you for fixing issue 1. I have a question related to importing multiple missing key pairs: does this feature supposed to work? There is no way to generate QR code for multiple keypairs as shown here If this feature is not ready - then maybe we should hide "import" button? Is this feature tracked somewhere? Currently scanning QR code of separate keypair results in errors. And there is no way generate QR for multiple keypairs as I mentioned above. telegram-cloud-document-2-5447256027370115758.mp4 |
ISSUE 2 User is able to rename keypair using existing nameActual result: telegram-cloud-document-2-5447256027370115843.mp4Expected result: validation error should be shown 
|
ISSUE 3 Long keypair limitation does not match the design@seanstrom for me it is not an issue, I like characters limit solution more than suggested by designers. But still, I am ponting this out as an issue because it differs from the design. Actual result: telegram-cloud-document-2-5447256027370115843.mp4Expected result: according to Figma user is able to enter more than 20 characters which will result in validation error 
|
|
@seanstrom another question: In feature description I see the following:
At the same time I do not see such possibility neither in designs nor in app. There are only 2 available options: import via seed phrase + import via QR code. 
Do we expect a possibility to import via private key or there is a mistake in feature descriprion? |
Overall, none of scan QR validation errors are implemented. So I am logging it as separate issue ISSUE 4 Scan QR validation errors do match the designsSteps:
Actual result: non of the above cases is covered. Errors do match the designs. QR code that belongs to the wrong key pair Already used keypair QR Invalid QR (non keypair QR) Expected result: 
|
Hey @pavloburykh thanks for finding this issue 🙌 I double checked with the team and it seems that this import button should be feature-flagged since we don't currently have a way to export all the key-pairs in a single QR code. I'll add the feature-flag for this button soon 👍 |
Hey @pavloburykh 👋 The designs for importing by a private-key should be here: https://www.figma.com/design/QWJV5WRbroXVDsdubEDjAT/Wallet-settings-for-Mobile?node-id=232-32719&t=xGA37vRLf3OvxIOl-4 And importing via a private-key will only be visible on key-pairs that have the "key" icon next to them. Here's an example of the two different action menus for a key-pair that's based on a private-key vs a key-pair that's based on a seed-phrase. Screen.Recording.2024-06-19.at.14.27.30.mov |
ISSUE 5 Seed phrase validation error issuesIOS: validation errors are not visible on IOS telegram-cloud-document-2-5447256027370116245.mp4Android: validation errors are not visible when keyboard is closed telegram-cloud-document-2-5447256027370116252.mp4Also, slider does not return to it's initial position when using biometry (both IOS and Android)
|
Thank you @seanstrom. But how can I generate such case with key pair that have the "key" icon next to it? We even do not have possibility to add new keypairs using private key. Wondering how you managed to generate such case. |
Ah in this case I used a combination of status-desktop and a Metamask account:
The missing key-pairs should display the key-pair that's based on the private-key after those steps. Lmk if that works for you 🙏 |
Great, thank you @seanstrom! |
seanstrom
force-pushed
the
seanstrom/unflag-key-pairs-and-accounts
branch
from
29ccc6d to
d26f1e7
Compare
|
@pavloburykh I've pushed up some fixes for Issues 2 & 3 related to validation when renaming a key-pair. Here's a screen recording of the changes 🎥 Screen.Recording.2024-06-19.at.15.15.48.mov |
seanstrom
force-pushed
the
seanstrom/unflag-key-pairs-and-accounts
branch
2 times, most recently
from
89e5863 to
1546de2
Compare
seanstrom
changed the title
seanstrom
force-pushed
the
seanstrom/unflag-key-pairs-and-accounts
branch
from
1546de2 to
f0ee03b
Compare
fixes #19936
Summary
Review notes
Testing notes
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready