[#21476] Part 2 - Code style fixes #21629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulisesmac
requested review from
ilmotta,
flexsurfer,
Parveshdhull and
mohsen-ghafouri
ulisesmac
commented
Nov 14, 2024
| @@ -70,8 +70,8 @@ | |||
| (rf/defn create-account-and-login | |||
| {:events [:onboarding/create-account-and-login]} | |||
| [{:keys [db] :as cofx}] | |||
| (let [{:keys [display-name seed-phrase password image-path color] :as profile} | |||
There was a problem hiding this comment.
This had unused vars destructured 👀
ulisesmac
commented
Nov 14, 2024
Comment on lines
17
to
+18
| (fn [{:keys [db]} [setting setting-value {:keys [dont-sync? on-success]}]] | ||
| {:db (-> db | ||
| (set-setting-value setting setting-value)) | ||
| {:db (set-setting-value db setting setting-value) |
There was a problem hiding this comment.
Removed 1 step thread macro usage
Jenkins Builds
|
ulisesmac
changed the base branch from
develop
to
21476-fix-biometrics-in-profile-switching-main
Horupa-Olena
force-pushed
the
21476-fix-biometrics-in-profile-switching-main
branch
from
9c44fd6 to
7be1be9
Compare
yevh-berdnyk
force-pushed
the
21476-fix-biometrics-in-profile-switching-main
branch
from
ca3973b to
b3da606
Compare
VolodLytvynenko
force-pushed
the
21476-fix-biometrics-in-profile-switching-main
branch
from
b3da606 to
04b10bf
Compare
ulisesmac
merged commit ccc45ea
into
21476-fix-biometrics-in-profile-switching-main
5 checks passed
ulisesmac
deleted the
21476-fix-biometrics-in-profile-switching-code-style
branch
ulisesmac
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21476
Summary
While solving:
I noticed some pieces of code could be fixed or improved, this has been created as a separate PR in order to make the review easier
status: ready