[#21567] - Remove steps to set up profile on new profile creation #21715

ulisesmac · 2024-11-29T04:00:41Z

Summary

~~⚠️ This PR only fixes the flow after pressing the "Let's go" button, this is the "create new profile" flow, the "login" flow must work as before. ⚠️~~

Update:
This PR completely removes the "create profile" screen for both "log in" and "create profile" flows.

Testing notes

Please make sure to test all posible flows, such as login, new profile generations when there are other existing profiles, etc.

Platforms

Android
iOS

status: ready

src/status_im/contexts/onboarding/create_password/view.cljs

src/status_im/contexts/onboarding/events.cljs

status-im-auto · 2024-11-29T04:06:00Z

Jenkins Builds

Click to see older builds (40)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`6d9de75`	#1	2024-11-29 04:05:59	~5 min	`tests`	📄`log`
✔️	`6d9de75`	#1	2024-11-29 04:08:45	~7 min	`android`	🤖`apk` 📲
✔️	`6d9de75`	#1	2024-11-29 04:09:52	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`6d9de75`	#1	2024-11-29 04:12:09	~11 min	`ios`	📱`ipa` 📲

✔️	`b473895`	#3	2024-11-30 04:59:19	~4 min	`tests`	📄`log`
✔️	`b473895`	#3	2024-11-30 05:01:49	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b473895`	#3	2024-11-30 05:01:59	~7 min	`android`	🤖`apk` 📲
✔️	`b473895`	#3	2024-11-30 05:03:56	~9 min	`ios`	📱`ipa` 📲

✔️	`b778e99`	#4	2024-12-02 21:13:12	~5 min	`tests`	📄`log`
✔️	`b778e99`	#4	2024-12-02 21:15:03	~6 min	`ios`	📱`ipa` 📲
✔️	`b778e99`	#4	2024-12-02 21:15:09	~6 min	`android`	🤖`apk` 📲
✔️	`b778e99`	#4	2024-12-02 21:16:20	~8 min	`android-e2e`	🤖`apk` 📲

✔️	`ed3e170`	#6	2024-12-03 16:09:25	~4 min	`tests`	📄`log`
✔️	`ed3e170`	#6	2024-12-03 16:12:02	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ed3e170`	#6	2024-12-03 16:13:15	~8 min	`ios`	📱`ipa` 📲
✔️	`ed3e170`	#6	2024-12-03 16:13:41	~8 min	`android`	🤖`apk` 📲

✔️	`cf66762`	#7	2024-12-06 02:33:17	~4 min	`tests`	📄`log`
✔️	`cf66762`	#7	2024-12-06 02:35:18	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`cf66762`	#7	2024-12-06 02:35:47	~7 min	`ios`	📱`ipa` 📲
✔️	`cf66762`	#7	2024-12-06 02:36:37	~7 min	`android`	🤖`apk` 📲

✔️	`138c638`	#8	2024-12-06 02:41:42	~4 min	`tests`	📄`log`
✔️	`138c638`	#8	2024-12-06 02:43:49	~7 min	`ios`	📱`ipa` 📲
✔️	`138c638`	#8	2024-12-06 02:45:35	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`138c638`	#8	2024-12-06 02:46:04	~9 min	`android`	🤖`apk` 📲

✔️	`45b2588`	#9	2024-12-06 19:54:20	~4 min	`tests`	📄`log`
✔️	`45b2588`	#9	2024-12-06 19:57:02	~7 min	`ios`	📱`ipa` 📲
✔️	`45b2588`	#9	2024-12-06 19:58:19	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`45b2588`	#9	2024-12-06 19:58:52	~9 min	`android`	🤖`apk` 📲

✔️	`cb3d53a`	#10	2024-12-06 20:39:55	~4 min	`tests`	📄`log`
✔️	`cb3d53a`	#10	2024-12-06 20:42:34	~6 min	`ios`	📱`ipa` 📲
✔️	`cb3d53a`	#10	2024-12-06 20:43:29	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`cb3d53a`	#10	2024-12-06 20:44:06	~8 min	`android`	🤖`apk` 📲

✔️	`505632a`	#11	2024-12-09 14:12:44	~4 min	`tests`	📄`log`
✔️	`505632a`	#11	2024-12-09 14:15:01	~6 min	`ios`	📱`ipa` 📲
✔️	`505632a`	#11	2024-12-09 14:15:12	~7 min	`android`	🤖`apk` 📲
✔️	`505632a`	#11	2024-12-09 14:17:11	~9 min	`android-e2e`	🤖`apk` 📲

✔️	`c37bea5`	#12	2024-12-09 14:33:24	~4 min	`tests`	📄`log`
✔️	`c37bea5`	#12	2024-12-09 14:35:42	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`c37bea5`	#12	2024-12-09 14:36:38	~7 min	`ios`	📱`ipa` 📲
✔️	`c37bea5`	#12	2024-12-09 14:36:47	~8 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`94002c0`	#13	2024-12-09 17:00:18	~4 min	`tests`	📄`log`
✔️	`94002c0`	#13	2024-12-09 17:03:03	~7 min	`ios`	📱`ipa` 📲
✔️	`94002c0`	#13	2024-12-09 17:04:19	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`94002c0`	#13	2024-12-09 17:04:46	~9 min	`android`	🤖`apk` 📲

✔️	`17c0923`	#14	2024-12-09 19:41:39	~4 min	`tests`	📄`log`
✔️	`17c0923`	#14	2024-12-09 19:43:44	~7 min	`ios`	📱`ipa` 📲
✔️	`17c0923`	#14	2024-12-09 19:45:24	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`17c0923`	#14	2024-12-09 19:45:58	~9 min	`android`	🤖`apk` 📲

src/status_im/contexts/profile/login/events.cljs

translations/en.json

src/status_im/contexts/profile/edit/name/events.cljs

src/status_im/contexts/onboarding/create_password/view.cljs

src/status_im/contexts/onboarding/events.cljs

src/status_im/common/floating_button_page/view.cljs

src/status_im/contexts/onboarding/create_password/view.cljs

src/status_im/contexts/onboarding/events.cljs

ilmotta

LGTM! And thank you for the refactors along the way!

src/status_im/contexts/onboarding/events.cljs

src/status_im/common/floating_button_page/view.cljs

status-im-auto · 2024-12-03T17:24:03Z

0% of end-end tests have passed

Total executed tests: 8
Failed tests: 8
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 727230,727231,702745,702742,740490,727229,703133,702843

Failed tests (8)

Click to expand

Rerun failed tests

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//*[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_balance_mainnet, id: 740490
Device 1: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Device 1: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//*[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Device 2: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: Find `Button` by `accessibility id`: `start-fresh-main-card` Device 1: Find `EditBox` by `accessibility id`: `profile-title-input` Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:252: in create_user self.set_profile(username) ../views/sign_in_view.py:236: in set_profile self.profile_title_input.send_keys(username) ../views/base_element.py:388: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:252: in create_user self.set_profile(username) ../views/sign_in_view.py:236: in set_profile self.profile_title_input.send_keys(username) ../views/base_element.py:388: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 1: Find EditBox by accessibility id: profile-title-input
Device 2: Find EditBox by accessibility id: profile-title-input

Test setup failed: critical/chats/test_public_chat_browsing.py:310: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:252: in create_user
    self.set_profile(username)
../views/sign_in_view.py:236: in set_profile
    self.profile_title_input.send_keys(username)
../views/base_element.py:388: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 2: Find Button by accessibility id: start-fresh-main-card
Device 2: Find EditBox by accessibility id: profile-title-input

Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:252: in create_user
    self.set_profile(username)
../views/sign_in_view.py:236: in set_profile
    self.profile_title_input.send_keys(username)
../views/base_element.py:388: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

mariia-skrypnyk · 2024-12-04T15:55:04Z

Hey @ulisesmac !

Thanks for your PR.

Found new screen that appeared at Login.

ISSUE 1: simplification user creation appeared after sync fallback

Precondition: you should have any recovery phrase to use on mobile and to login this user to the desktop as well

Login to desktop as User A
Go to Settings -> Sync -> setup syncing -> Reveal QR code
Install mobile app
Go to Login -> Login by syncing -> Scan desktop QR -> Recovery phrase
Enter recovery phrase of User A

Actual result:

New simplification user creation appears in this flow.
User name generates as in old app version.

video_2024-12-04_16-53-00.mp4

ulisesmac · 2024-12-04T17:11:45Z

Hi @mariia-skrypnyk

Sorry, I don't get what is wrong, could you please add the "expected result" section.

Thank you!

Note: I'm not sure if the issue you are pointing out is the current behavior on develop or not 🤔

Update

I can't replicate the behaviour you showed 🤔 maybe you are performing an additional step?

BTW, I can see the onboarding images in your build are the new ones, but the branch in this PR hasn't updated them yet, so maybe the versions tested are different?

video:

video_2024-12-04_13-48-04.mp4

status-im-auto · 2024-12-05T10:27:46Z

0% of end-end tests have passed

Total executed tests: 8
Failed tests: 8
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 727230,727231,702745,702742,740490,727229,703133,702843

Failed tests (8)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: Find `Button` by `accessibility id`: `start-fresh-main-card` Device 1: Find `EditBox` by `accessibility id`: `profile-title-input` Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:252: in create_user self.set_profile(username) ../views/sign_in_view.py:236: in set_profile self.profile_title_input.send_keys(username) ../views/base_element.py:388: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Test setup failed: critical/chats/test_public_chat_browsing.py:26: in prepare_devices self.home = self.sign_in.create_user(username=self.username) ../views/sign_in_view.py:252: in create_user self.set_profile(username) ../views/sign_in_view.py:236: in set_profile self.profile_title_input.send_keys(username) ../views/base_element.py:388: in send_keys self.find_element().send_keys(value) ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 2: Click until EditBox by accessibility id: profile-title-input will be presented
Device 2: Find Button by accessibility id: start-fresh-main-card

Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:252: in create_user
    self.set_profile(username)
../views/sign_in_view.py:236: in set_profile
    self.profile_title_input.send_keys(username)
../views/base_element.py:388: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 1: Find Button by accessibility id: start-fresh-main-card
Device 1: Find EditBox by accessibility id: profile-title-input

Test setup failed: critical/chats/test_public_chat_browsing.py:310: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:252: in create_user
    self.set_profile(username)
../views/sign_in_view.py:236: in set_profile
    self.profile_title_input.send_keys(username)
../views/base_element.py:388: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `profile-title-input` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//*[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_balance_mainnet, id: 740490
Device 1: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Device 1: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Test setup failed: critical/test_wallet.py:210: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase'], username=self.sender_username) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//*[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Device 2: Find `CheckBox` by `xpath`: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` Test setup failed: critical/test_wallet.py:28: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/sign_in_view.py:279: in recover_access self.set_password(password) ../views/sign_in_view.py:231: in set_password self.checkbox_button.scroll_to_element() ../views/base_element.py:205: in scroll_to_element raise NoSuchElementException( Device 1: CheckBox by xpath: `//[@content-desc='checkbox-off'][@resource-id='checkbox-component']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

mariia-skrypnyk · 2024-12-05T10:36:22Z

Hey @ulisesmac !

Thanks for checking.
My bad, I didn't check sync fallback design and it also contains simplified profile creation flow.
That's why I was thought we have a PR issue.

We will fix E2E tests and I let you know.

status-im-auto · 2024-12-09T14:24:19Z

62% of end-end tests have passed

Total executed tests: 8
Failed tests: 3
Expected to fail tests: 0
Passed tests: 5

IDs of failed tests: 727230,703133,727229

Failed tests (3)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]` Device 2: `Text` is `0.13939 ETH` `critical/test_wallet.py:187: in test_wallet_send_asset_from_drawer self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the shdUaM8M6QcxQ4qn32nQs wallet is 0.3402 but should be 0.3404 E Eth amount in the shhWMbdtFbqsHau8w2CJs wallet is 0.1394 but should be 0.1394`
2. test_wallet_send_eth, id: 727229
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]` Device 2: `Text` is `0.13929 ETH` `critical/test_wallet.py:156: in test_wallet_send_eth self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the shdUaM8M6QcxQ4qn32nQs wallet is 0.3403 but should be 0.3405 E Eth amount in the shhWMbdtFbqsHau8w2CJs wallet is 0.1393 but should be 0.1393`

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

Device 1: Click until Button by accessibility id: icon, Password, label-component, icon will be presented
Device 1: Find ProfileButton by accessibility id: open-profile

critical/chats/test_public_chat_browsing.py:162: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
    recover_user_name = self.home.get_username()
../views/home_view.py:630: in get_username
    profile.default_username_text.wait_for_element(3)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `Text` by` accessibility id`: `username` is not found on the screen after wait_for_element

Device sessions

Device 1:

Steps, video, logs

Passed tests (5)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

status-im-auto · 2024-12-09T14:43:14Z

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6

IDs of failed tests: 727230,727229

Failed tests (2)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]` Device 2: `Text` is `0.13959 ETH` `critical/test_wallet.py:187: in test_wallet_send_asset_from_drawer self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the shdUaM8M6QcxQ4qn32nQs wallet is 0.34 but should be 0.3402 E Eth amount in the shhWMbdtFbqsHau8w2CJs wallet is 0.1396 but should be 0.1396`
2. test_wallet_send_eth, id: 727229
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]` Device 2: `Text` is `0.13949 ETH` `critical/test_wallet.py:156: in test_wallet_send_eth self.errors.verify_no_errors() base_test_case.py:192: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the shdUaM8M6QcxQ4qn32nQs wallet is 0.3401 but should be 0.3403 E Eth amount in the shhWMbdtFbqsHau8w2CJs wallet is 0.1395 but should be 0.1395`

Passed tests (6)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

yevh-berdnyk · 2024-12-09T14:53:52Z

Hi @ulisesmac @mariia-skrypnyk,
E2E test are updated, failures are not related to the PR. Thanks!

churik · 2024-12-09T15:59:20Z

Please, let me know when it is merged and notify in release-coordination channel to cherry-pick it, thanks!

* Remove password disclaimer, update copy and simplify implementation * Remove non-existing wallet event * Skip profile configuration for the "create profile" onboarding flow * Include flow for new profiles when another profile already exists * Add explanation about temp username * Point 20 to a constant * Simplify create profile password screen * Fix password creation screen jump on mount * e2e: updated tests * Completely remove the "create profile" onboarding screen * e2e: updated tests with recovering user --------- Co-authored-by: Yevheniia Berdnyk <ie.berdnyk@gmail.com>

ulisesmac requested review from ilmotta, seanstrom and Parveshdhull November 29, 2024 04:00

ulisesmac self-assigned this Nov 29, 2024