-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sha3)_: support hex string #21824
Conversation
Jenkins BuildsClick to see older builds (4)
|
75% of end-end tests have passed
Failed tests (2)Click to expandClass TestWalletMultipleDevice:
Passed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
|
Hey @qfrank! Thank you for the fix. Please ping me up once PR is reviewed and ready for QA. |
ready for QA now :) @pavloburykh |
Would be great if go PR status-im/status-go#6216 is reviewed prior to QA as there might be some additional changes based on review. |
@pavloburykh approved both |
34% of end-end tests have passed
Failed tests (37)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (19)Click to expandClass TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestFallbackMultipleDevice:
|
86% of end-end tests have passed
Failed tests (5)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Passed tests (32)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
@qfrank @flexsurfer thanks for the PR. Unfortunately we still have critical issue during upgrade flow ISSUE 1 Wrong derived addresses are created after upgrade from v1 Status appSteps:
Actual result: account address is incorrect Status-debug-logs - 2024-12-16T172321.128.zip Expected result: |
@qfrank @flexsurfer Because of ISSUE 1 it was decided to disable possibility to create additional accounts via keycard #21828 |
v1 upgrade is a separate isssue, keycard doesn't support paths like |
@pavloburykh could you please create a new issue for |
@qfrank could you pls bump go version and merge pls |
@pavloburykh PR is now updated to latest commit from status-go release branch and also rebased against latest mobile |
hey @ilmotta i believe this change won't go to release, because we have another issue and we just disabled account creation in the release |
Sure thing @flexsurfer, in that case I'll leave it up for @qfrank to handle this PR since it's not urgent anymore. The status-go PR needs to be applied onto status-go |
@flexsurfer created a separate issue about derivation paths #21836 |
we only need to merge the changes into |
fix relate mobile issue
relate status-go PR
Platforms
status: ready.