[FIX #2118] ui: store search-key under [:toolbar-search :show] #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
approved these changes
Dec 6, 2017
|
Same comment as #2584 (comment) - sorry to be a stickler but it really makes it easier (and quicker!) for devs and QA to review, test and merge your changes. |
oskarth
approved these changes
Dec 6, 2017
rasom
reviewed
Dec 14, 2017
| @@ -77,13 +77,13 @@ | |||
| (defview chats-list [] | |||
| (letsubs [chats [:filtered-chats] | |||
| edit? [:get-in [:chat-list-ui-props :edit?]] | |||
| search? [:get-in [:toolbar-search :show]] | |||
There was a problem hiding this comment.
Use of undeclared Var status-im.ui.screens.chats-list.views/search? at line 98 /Users/jenkins/workspace/status-react/parametrized build/src/status_im/ui/screens/chats_list/views.cljs
search? symbol is used later in this function
vitvly
force-pushed
the
bug/empty-chats-#2118
branch
from
462b563
to
daae98e
Compare
|
Sorry, lame mistake. Fixed. |
rasom
approved these changes
Dec 21, 2017
Chat list used to store booleans under [:toolbar-search :show] which is different from other views and caused the issue described in status-im#2118.
rasom
force-pushed
the
bug/empty-chats-#2118
branch
from
daae98e
to
907d3c7
Compare
|
i've just rebased it onto |
|
Checked:
|
qoqobolo
added a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2118.
Summary:
Chat list used to store booleans under [:toolbar-search :show] which is
different from other views and caused the toolbar to appear in Chats if search was used in Discover or Contacts. With this change search key (= :chat-list) is stored under the above path.
Review notes (optional):
Testing notes (optional):
Steps to test:
status: ready