Remove message data remnants #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenda
approved these changes
Jan 5, 2018
flexsurfer
approved these changes
Jan 5, 2018
dmitryn
approved these changes
Jan 6, 2018
|
@janherich Please resolve conflicts. If you are confident this change doesn't introduce regressions, and CI passes, please merge it in develop. |
janherich
force-pushed
the
feature/remove-message-data-remnants
branch
from
7def32a
to
17ef368
Compare
|
@oskarth I'm quite sure it doesn't, checking CI for the last time, then merging. |
janherich
force-pushed
the
feature/remove-message-data-remnants
branch
from
17ef368
to
4ce70f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the recent #1875 and #2807 PRs,
:message-datakey in db was completely removed and replaced by messages indexed by their id.I discovered that I forgot to remove this last place where it was used, so this PR finishes the work.
Testing notes (optional):
Make sure that chats in chat list are still displayed correctly. No upgrade testing necessary
status: ready