-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug #4491 - changed the copy for amount too precise validation error #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
approved these changes
May 29, 2018
rasom
approved these changes
May 29, 2018
apk uploaded to https://i.diawi.com/zwryWk for branch PR-4505 |
ipa uploaded to https://i.diawi.com/5YUsgJ for branch PR-4505 |
71% of end-end tests have passed
Failed tests (8)Click to expand
Passed tests (20)Click to expand
|
goranjovic
force-pushed
the
bug/precise-warning-decimals-4491
branch
from
May 29, 2018 13:07
e41af2f
to
6e308c8
Compare
This PR also comments out translations for bots other than English |
apk uploaded to https://i.diawi.com/vrLU8E for branch PR-4505 |
ipa uploaded to https://i.diawi.com/null for branch PR-4505 |
rasom
force-pushed
the
bug/precise-warning-decimals-4491
branch
from
May 29, 2018 14:13
6e308c8
to
40e6f36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4491
Summary:
Small copy change PR - now that we have tokens, validation message should depend on number of decimals that the selected asset supports.
Steps to test:
status: ready