Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #4491 - changed the copy for amount too precise validation error #4505

Merged
merged 1 commit into from
May 29, 2018

Conversation

goranjovic
Copy link
Contributor

fixes #4491

Summary:

Small copy change PR - now that we have tokens, validation message should depend on number of decimals that the selected asset supports.

Steps to test:

  • Try sending ETH amount with too many decimals from chat
  • Try sending ETH amount with too many decimals from wallet
  • Try sending token amount with too many decimals from wallet for a number of token types

status: ready

@goranjovic goranjovic requested a review from jeluard May 29, 2018 08:44
@goranjovic goranjovic self-assigned this May 29, 2018
@goranjovic
Copy link
Contributor Author

screenshot-2018-05-29_10 39 28 900
screenshot-2018-05-29_10 40 27 197

@rasom
Copy link
Contributor

rasom commented May 29, 2018

@rasom
Copy link
Contributor

rasom commented May 29, 2018

@asemiankevich asemiankevich self-assigned this May 29, 2018
@statustestbot
Copy link

71% of end-end tests have passed

Total executed tests: 28
Failed tests: 8
Passed tests: 20

Failed tests (8)

Click to expand
1. test_sign_transaction_twice

Tap on WalletButton
Looking for SendButton

E selenium.common.exceptions.NoSuchElementException: Message: 'SendButton' is not found on screen, using: 'accessibility id:send-transaction-button'

Device sessions:

2. test_send_eth_from_wallet_sign_now

Tap on WalletButton
Looking for SendButton

E selenium.common.exceptions.NoSuchElementException: Message: 'SendButton' is not found on screen, using: 'accessibility id:send-transaction-button'

Device sessions:

3. test_open_transaction_on_etherscan

Tap on WalletButton
Looking for TransactionsButton

E selenium.common.exceptions.NoSuchElementException: Message: 'TransactionsButton' is not found on screen, using: 'accessibility id:transaction-history-button'

Device sessions:

4. test_send_eth_to_request_from_wallet

Wait for SendTransactionRequestButton
Looking for SendTransactionRequestButton

E selenium.common.exceptions.NoSuchElementException: Message: 'SendTransactionRequestButton' is not found on screen, using: 'accessibility id:sent-transaction-request-button'

Device sessions:

5. test_public_chat_management

Tap on SendMessageButton
Looking for an element by text: '#aqmmhfgpqiaqbhrdgpt'

E selenium.common.exceptions.NoSuchElementException: Message: 'BaseButton' is not found on screen, using: 'xpath://*[@text="#aqmmhfgpqiaqbhrdgpt"]'

Device sessions:

6. test_wallet_error_messages

Tap on WalletButton
Looking for SendButton

E selenium.common.exceptions.NoSuchElementException: Message: 'SendButton' is not found on screen, using: 'accessibility id:send-transaction-button'

Device sessions:

7. test_send_eth_to_request_in_one_to_one_chat

Tap on WalletButton
Looking for TransactionsButton

E selenium.common.exceptions.NoSuchElementException: Message: 'TransactionsButton' is not found on screen, using: 'accessibility id:transaction-history-button'

Device sessions:

8. test_send_stt_from_wallet_via_enter_recipient_address

Tap on WalletButton
Looking for SendButton

E selenium.common.exceptions.NoSuchElementException: Message: 'SendButton' is not found on screen, using: 'accessibility id:send-transaction-button'

Device sessions:

Passed tests (20)

Click to expand
1. test_swipe_and_delete_1_1_chat
Device sessions:

2. test_one_to_one_chat_messages
Device sessions:

3. test_copy_and_paste_messages
Device sessions:

4. test_send_transaction_from_daap
Device sessions:

5. test_faucet_console_command
Device sessions:

6. test_username_and_profile_picture_in_chats
Device sessions:

7. test_incorrect_password
Device sessions:

8. test_backup_seed_phrase_and_recover_account
Device sessions:

9. test_offline_messaging_1_1_chat
Device sessions:

10. test_contact_profile_view
Device sessions:

11. test_public_chat
Device sessions:

12. test_network_switch
Device sessions:

13. test_delete_1_1_chat
Device sessions:

14. test_transaction_send_command_one_to_one_chat
Device sessions:

15. test_browse_link_entering_url_in_dapp_view
Device sessions:

16. test_transaction_send_command_wrong_password
Device sessions:

17. test_profile_picture
Device sessions:

18. test_switch_users
Device sessions:

19. test_set_up_wallet
Device sessions:

20. test_qr_code_and_its_value
Device sessions:

@goranjovic goranjovic force-pushed the bug/precise-warning-decimals-4491 branch from e41af2f to 6e308c8 Compare May 29, 2018 13:07
@goranjovic
Copy link
Contributor Author

This PR also comments out translations for bots other than English

@rasom
Copy link
Contributor

rasom commented May 29, 2018

@rasom
Copy link
Contributor

rasom commented May 29, 2018

@rasom rasom force-pushed the bug/precise-warning-decimals-4491 branch from 6e308c8 to 40e6f36 Compare May 29, 2018 14:13
@rasom rasom merged commit 40e6f36 into develop May 29, 2018
@rasom rasom deleted the bug/precise-warning-decimals-4491 branch May 29, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Validation error message is incorrect for assets
5 participants