-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4901]: Fix npm version issue; updated scripts/setup #4974
Conversation
ios/Podfile.lock
Outdated
|
||
DEPENDENCIES: | ||
- FirebaseMessaging | ||
- React (from `../node_modules/react-native`) | ||
- react-native-background-timer (from `../node_modules/react-native-background-timer`) | ||
- RNKeychain (from `../node_modules/react-native-keychain`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the same changes automatically in Xcode in a different PR https://github.com/status-im/status-react/pull/4988/files , probably at some point some code got through which did not update these files, so it's probably safer to include them at some point, otherwise we might be using different versions locally from prod (0.53 vs 0.55 seems like a big difference), but I know very little of mac build
ios/Podfile.lock
Outdated
|
||
COCOAPODS: 1.3.1 | ||
COCOAPODS: 1.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather leave pod changes out if they are not strictly mandatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, there are a lot of version changes in package-lock.json
, is it all required for this upgrade?
03ef56e
to
61c5d15
Compare
Signed-off-by: Aleksandr Pantiukhov <alwxndr@gmail.com>
Fixes #4901
Tested on node v7.10.1 (npm v5.5.1) and node v9.11.2 (npm v6.1.0).
Node 10 is not supported by Realm: realm/realm-js#1813
Also updated our build scripts, added the installation of Clojure CLI there (to build status with
clj-rn
) and made sure it works.