-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #7325] Add EIP681 deeplink support #8004
Conversation
Jenkins BuildsClick to see older builds (26)
|
@jeluard please, rebase to current |
@churik Done! |
100% of end-end tests have passed
Passed tests (48)Click to expand
|
Pull Request Checklist
|
@jeluard Please, elaborate:
I tested the following scenarios using "Scan QR" on home screen (generating them using https://www.qr-code-generator.com/ > Text) or via Wallet > Send > Scan QR (result is that same)
So the asset was changed to tokens, but the value is not displayed.
|
33% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (1) |
@jeluard please, rebase PR to current Also some notes:
|
@churik Done |
@jeluard any comments on #8004 (comment)? |
@churik Sorry missed that comment!
|
9f2adab
to
3ff08f8
Compare
@churik 1) should be fixed, with the caveat that onboarding will loose the wallet details. User would have to click a second time on the deep link. |
96% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (46)Click to expand
|
96% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (46)Click to expand
|
Created #8150 |
0% of end-end tests have passed
Failed tests (1)Click to expand
|
|
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
fixes #7325
Summary
Added EIP681 deep link support.
NOTE to testers EIP681 clicked in mobile stock browser should open status / send screen.
status: ready