Use react-native-fast-image for remote images #8399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (85)
|
shamardy
changed the title
|
hey @shamardy is it WIP? |
No. Also I dont have Overall/Read permission in Jenkins to check the logs and errors. |
|
but i couldn't find any usage of this new component in the code, we should replace react native image on this new component |
flexsurfer
requested changes
Jun 12, 2019
| @@ -26,6 +26,7 @@ | |||
| (def status-keycard (fn [] #js {:default #js {}})) | |||
| (def dialogs (fn [] #js {})) | |||
| (def dismiss-keyboard (fn [] #js {})) | |||
| (def fast-image (fn [] #js {})) | |||
There was a problem hiding this comment.
i'm not sure about desktop, @vkjr ?
| @@ -51,7 +52,7 @@ | |||
| (when style {:style style}))] children)) | |||
|
|
|||
| (defn image [{:keys [source uri style]}] | |||
| [react/image (merge {:style (merge {:width 100 :height 100} style)} {:source (if source source {:uri uri})})]) | |||
| [rn-dependencies/fast-image (merge {:style (merge {:width 100 :height 100} style)} {:source (if source source {:uri uri})})]) | |||
There was a problem hiding this comment.
we need to replace usage of class inside react/image itself, here https://github.com/status-im/status-react/blob/c2b55233225f6e4d59c9ca5174b5261cc1137fec/components/src/status_im/ui/components/react.cljs#L78, thanks
flexsurfer
reviewed
Jun 16, 2019
| @@ -61,7 +61,7 @@ | |||
|
|
|||
| (def text-class ((get-class "Text"))) | |||
| (def text-input-class (get-class "TextInput")) | |||
| (def image-class (get-class "Image")) | |||
| (def fast-image-class (get-class "fast-image")) | |||
There was a problem hiding this comment.
get-class retrieves class from react native package, but you need to get it from react-native-fast-image, see how it works for image picker for example https://github.com/status-im/status-react/blob/f3aa376d167ed7d7dd5073b83f641cba7f861b03/components/src/status_im/ui/components/react.cljs#L202-L213
|
hey @shamardy thanks for your effort, there is an error in ios build |
|
|
2 similar comments
|
|
|
|
|
|
2 similar comments
|
|
|
|
yenda
reviewed
Jun 26, 2019
react-native/src/desktop/status_im/react_native/js_dependencies.cljs
Outdated
Show resolved
Hide resolved
|
hey @shamardy any updates? |
commit 4121c29 Author: shamardy <shamardy@yahoo.com> Date: Wed Jul 10 15:18:46 2019 +0200 fix desktop dependencies commit 51ad41b Author: shamardy <shamardy@yahoo.com> Date: Mon Jun 24 08:51:09 2019 +0200 fix commit 5383bf8 Author: shamardy <shamardy@yahoo.com> Date: Sun Jun 23 08:31:35 2019 +0200 fix commit 97087a4 Author: shamardy <shamardy@yahoo.com> Date: Sun Jun 23 04:54:58 2019 +0200 fix commit 74b2ad3 Author: shamardy <shamardy@yahoo.com> Date: Thu Jun 20 08:13:08 2019 +0200 fix project.pbxproj commit 2eeb4d5 Author: shamardy <shamardy@yahoo.com> Date: Thu Jun 20 07:20:34 2019 +0200 fix project.pbxproj commit 58bdcac Author: shamardy <shamardy@yahoo.com> Date: Thu Jun 20 06:58:54 2019 +0200 fix commit 2fe99a9 Author: shamardy <shamardy@yahoo.com> Date: Wed Jun 19 06:08:45 2019 +0200 fix commit b3e514e Author: shamardy <shamardy@yahoo.com> Date: Tue Jun 18 20:26:37 2019 +0200 Squashed commit of the following: commit 56ae978 Author: shamardy <shamardy@yahoo.com> Date: Tue Jun 18 20:18:47 2019 +0200 Fix Podfile.lock commit e3b5368 Author: shamardy <shamardy@yahoo.com> Date: Sun Jun 16 17:11:55 2019 +0200 fix commit ffc4b2f Author: shamardy <shamardy@yahoo.com> Date: Sun Jun 16 16:29:57 2019 +0200 fix fast-image-class commit a7dfa66 Author: shamardy <shamardy@yahoo.com> Date: Sun Jun 16 03:11:35 2019 +0200 Squashed commit of the following: commit cd7f03e Author: shamardy <shamardy@yahoo.com> Date: Sun Jun 16 02:56:31 2019 +0200 Fixes commit 2cc1243 Author: shamardy <shamardy@yahoo.com> Date: Wed Jun 12 05:50:56 2019 +0200 Use FastImage instead of Native Image commit d404c04 Author: shamardy <shamardy@yahoo.com> Date: Mon Jun 10 14:55:13 2019 +0200 Squashed commit of the following: commit 42c89c1 Author: shamardy <shamardy@yahoo.com> Date: Mon Jun 10 14:48:12 2019 +0200 Use react-native-fast-image for remote images
|
@shamardy could you rebase onto develop please, thanks |
|
Closing PR as no longer active. Please re-open if this is in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7633