Changed placeholder to show "Enter password" #8468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally both the password label and the placeholder were displaying "Password" on login. I corrected the placeholder to show "Enter password" instead.
|
Hey @demmojo, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Pull Request Checklist
|
Jenkins Builds
|
|
@demmojo Does this reflect some Figma/design decision? |
|
@jeluard having both the label and placeholder be the same is redundant. It would be better to either differentiate them or even have a blank placeholder (this is done on GitHub for e.g) |
|
@errorists @hesterbruikman Any thoughts about that? |
|
thanks for looking in. It's something we corrected in the ongoing onboarding redesign, the password label is removed and placeholder says 'Enter password' |
|
Thanks for the update and sharing the redesign link! @errorists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally both the password label and the placeholder were displaying "Password" on login. I corrected the placeholder to show "Enter password" instead.
Platforms