Don't provide --apk=, it's already there

[jakubgs]

Tiny fix for how Nightly builds trigger e2e tests by passing the filename of the APK to test.

Also updated the name of the SauceLabs credential in Jenkins.

Related to: #8451

[status-github-bot]

Pull Request Checklist

• Have you updated the documentation, if impacted (e.g. docs.status.im)?

[status-im-auto]

Jenkins Builds

Click to see older builds (18)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	4a22727	#1	2019-07-01 15:53:56	~12 min	android	📦 apk
✔️	4a22727	#1	2019-07-01 15:54:44	~13 min	android-e2e	📦 apk
✔️	4a22727	#1	2019-07-01 15:54:50	~13 min	ios	📦 ipa
✔️	4a22727	#1	2019-07-01 15:55:27	~13 min	linux	📦 App
✔️	4a22727	#1	2019-07-01 15:56:01	~14 min	macos	📦 dmg
✔️	4a22727	#1	2019-07-01 15:57:53	~16 min	windows	📦 exe
✔️	0037d9d	#3	2019-07-01 16:48:08	~11 min	android	📦 apk
✔️	0037d9d	#3	2019-07-01 16:48:09	~11 min	android-e2e	📦 apk
✔️	0037d9d	#3	2019-07-01 16:50:21	~13 min	ios	📦 ipa
✔️	0037d9d	#3	2019-07-01 16:51:54	~14 min	linux	📦 App
✔️	0037d9d	#3	2019-07-01 16:52:45	~15 min	windows	📦 exe
✔️	0037d9d	#3	2019-07-01 17:00:27	~23 min	macos	📦 dmg
✔️	cecfb70	#4	2019-07-02 14:57:33	~10 min	android	📦 apk
✔️	cecfb70	#4	2019-07-02 14:57:35	~10 min	android-e2e	📦 apk
✔️	cecfb70	#4	2019-07-02 14:59:30	~12 min	ios	📦 ipa
✔️	cecfb70	#4	2019-07-02 14:59:32	~12 min	linux	📦 App
✔️	cecfb70	#4	2019-07-02 15:00:01	~13 min	macos	📦 dmg
✔️	cecfb70	#4	2019-07-02 15:01:25	~14 min	windows	📦 exe

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	4eb31a3	#5	2019-07-02 18:20:21	~6 min	android	📄 log
✔️	4eb31a3	#5	2019-07-02 18:24:06	~10 min	android-e2e	📦 apk
✔️	4eb31a3	#5	2019-07-02 18:26:10	~12 min	ios	📦 ipa
✔️	4eb31a3	#5	2019-07-02 18:27:01	~13 min	linux	📦 App
✔️	4eb31a3	#5	2019-07-02 18:27:57	~14 min	macos	📦 dmg
✔️	4eb31a3	#5	2019-07-02 18:28:13	~14 min	windows	📦 exe
✔️	4eb31a3	#6	2019-07-03 04:14:40	~13 min	android	📦 apk
✔️	aac5426	#8	2019-07-03 05:46:17	~12 min	android	📦 apk
✔️	aac5426	#7	2019-07-03 05:46:47	~13 min	ios	📦 ipa
✔️	aac5426	#7	2019-07-03 05:47:11	~13 min	macos	📦 dmg
✔️	aac5426	#7	2019-07-03 05:47:58	~14 min	linux	📦 App
✔️	aac5426	#7	2019-07-03 05:48:19	~14 min	windows	📦 exe
✔️	aac5426	#7	2019-07-03 06:01:45	~28 min	android-e2e	📦 apk

[jakubgs]

This fixes the recent SauceLabs error:

java.lang.Exception: no credentials provided

But we have another one:

hudson.AbortException: No test report files were found. Configuration error?

But if we look at much older builds the same would happen on failed tests:

ERROR: No test report files were found. Configuration error?
Finished: FAILURE

https://ci.status.im/job/end-to-end-tests/job/status-app-nightly/942/console

The saucePublisher() call succeeds even when tests fail, but the junit() call fails. Maybe it should be called in post { success {} } block.

[jakubgs]

Hmmmm, but there is something different, before it was:

Starting Sauce Labs test publisher
Finished Sauce Labs test publisher

But now it's:

Starting Sauce Labs test publisher
The Sauce OnDemand plugin is configured, but no session IDs were found in the test output.
Finished Sauce Labs test publisher

I found this:

Output the Sauce session ID to the standard output (stdout) to allow the Sauce plugin to associate test results to Sauce Jobs. See the topic on Outputting Session IDs to stdout for more information.

https://wiki.saucelabs.com/display/DOCS/Installing+and+Configuring+the+Sauce+OnDemand+Plugin+for+Jenkins

And for more detail:

...to make it easy for you to integrate your Sauce Labs testing with Jenkins, we developed the Sauce Jenkins Plugin.

https://wiki.saucelabs.com/display/DOCS/Setting+Up+Sauce+Labs+with+Jenkins

So it seems like the plugin should be the one providing the "Sauce session ID".

[jakubgs]

The tests are also getting lots of these:

Infrastructure Error -- The Sauce VMs failed to start the browser or device.

Trace:

raceback (most recent call last):
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.5/dist-packages/appium/webdriver/webdriver.py", line 97, in __init__
    super(WebDriver, self).__init__(command_executor, desired_capabilities, browser_profile, proxy, keep_alive)
  File "/usr/local/lib/python3.5/dist-packages/selenium/webdriver/remote/webdriver.py", line 157, in __init__
    self.start_session(capabilities, browser_profile)
  File "/usr/local/lib/python3.5/dist-packages/appium/webdriver/webdriver.py", line 136, in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, parameters)
  File "/usr/local/lib/python3.5/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.5/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: Infrastructure Error -- The Sauce VMs failed to start the browser or device.
For more info, please check https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages

Based on the link:

Causes

• If you're running a Selenium test, this usually means that you're specifying a Selenium version that isn't compatible with the browser/version/operating system you selected
• If you're running an Appium test, this usually means that you're specifying a Appium version that isn't compatible with the browser/version/operating system you selected
• You may have also requested a platform/operating system/browser combination that is incompatible, like Mac/OS X/Internet Explorer

How to Resolve

• You can usually resolve this error by choosing a new version of Selenium or Appium for your test, or leaving the version blank to default to the latest version.
• You can also check the Desired Capabilities of your test to make sure you haven't set an incompatible platform/operating system/browser combination'
• Use the Platform Configurator to set the Desired Capabilities of your test

https://wiki.saucelabs.com/display/DOCS/Common+Error+Messages#CommonErrorMessages-TheSauceLabsVirtualMachineFailedtoStarttheBrowserorDevice

[jakubgs]

Manual nightly build to verify SauceLabs upload stage works:
https://ci.status.im/job/status-react/job/manual/382/