[8556] fix - Last message jumps up after chat is opened #8589
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (37)
|
|
please bare with me.. got too excited
|
#2 is fixed.. at some point though.. structure of components in chat view probably needs refactoring #1 made test pass by doing this |
|
for #1 looks like doing this https://github.com/status-im/status-react/blob/709f50cb1ec7cbf8681daad7553ca0b80ce10b6a/src/status_im/ui/screens/desktop/main/chat/views.cljs#L257 should still work All builds have passed, so, going to call it ready for review |
|
found and fixed(in the last force push) an issue in home screen where if you deleted a chat with long-press chat search field would show up after deletion. |
98% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (43)Click to expand |
|
Please still bare with me on this! In the current solution I have been quite unsatisfied with the weird hacky trick I discovered and used (where, a non-animatable property :margin-bottom is being animated). Use of convolutedly-passing-around-padding-value, and use of listening-and-using-anim-actual-value wasn't sparking joy either. It feels like it makes the revealing and hiding of connectivity bar not so smooth, or something subtly wrong. So I couldn't help looking for better solution. I think I found it! a solution where hacky tricks are not(or minimally) needed. With some more testing and cleaning up I will update the PR soon. |
|
@flexsurfer @annadanchenko / test team MacOS build failed and I suspect there are things that may be broken in desktops. I don't know how much of a priority this is, but I have stayed away from dev building/testing desktop so far. Anyway, this should be fairly easy to fix on desktop when required/needed. |
This issue which is fixed in this PR is actually a search-bar bug that happens in Nightly also. Similar appearance of bug identified by @asemiankevich in #8599 (comment) |
flexsurfer
requested review from
vitvly and
flexsurfer
and removed request for
yenda and
vkjr
Got it! |
84% of end-end tests have passedFailed tests (7)Click to expand
Passed tests (37)Click to expand |
|
@pombeirp @vkjr I have been unable to setup dev build for desktop following instructions in https://status.im/build_status/desktop.html I twiddled and fiddled trying to bypass various errors without luck for a while, giving up finally. The documentation I linked itself seems to be needing update. It talks of doing But even before that there were other problems I tried to resolve, like trying to get help! @asemiankevich I'm afraid I cannot troubleshoot the problem without being able to have dev build setup. |
|
Help! In the process of trying to get dev build of desktop going I tried starting over with Now I cannot get iOS dev build setup with following error. for those continuing with their setups from while ago, things probably continue to work, but for starting/re-starting from fresh folks setting up build environment seems to have become broken except maybe for Android. |
|
based on discussion with @rachelhamlin @flexsurfer @yenda we will not block mobile app release because of the desktop issue in this PR. Reasons:
So, moving this PR back to TO TEST and we focus only on mobile platforms while testing it |
Great! I thought so too. Wise to focus on mobile for now. I will be contributing to desktop for sure when the time comes, as I was initially more interested, still equally interested, about desktop. Thanks! |
|
i logged #8636 for desktop issue. Mobile builds look good to me, message is not jumping anymore (1x1, public , group chat). Also, search problem on Home seems to be fixed here as well . |
|
Thanks @asemiankevich! |
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
|
🎉 thanks everyone! |
|
@bitsikka sorry you're running into issues with setting up the environment. Regarding |
|
OK, I already found an issue in https://github.com/status-im/status-react/blob/develop/nix/shell.sh#L48, please try adding |
|
I'm now seeing a yarn build issue with the Detox dependency, my guess is that this was introduced by the latest RN Desktop upgrade. cc @vkjr |
|
@pombeirp I managed to get a dev build environment for iOS by turning off I will wait until your latest PRs and issues you have found to be fixed/merged, cache be populated(or something), before I rebase anything else new, and to I'm good to continue working on issues for now. Note(not priority): Going to NOT run |
Why was this necessary?
Wrong, now |
I didn't know anything better. I ran regular setup after clean and ran into either or something else so I tried different things, and ended up with long thingy that ended up giving me result I needed.
That is wonderful! Did not know that.. I just assumed the old behavior.. having done that couple of times before. :( I manually cleaned /nix and re-installed system stuff, having gotten the list of system installed packages first. I was thinking maybe there was something in /nix/* that was dirty or something. |
fixes #8556
This bothered me so much that I kept thinking about it and looking for solution, even though, I'd committed to work on other issues 😛.
I may have found the solution (maybe could be better). Please review/test and see if it is acceptable.
Solution was achieved still using native animation introduced in #8498, and not by reverting to old non-native solution before #8498.
Testing Notes:
homeandchatscreensmobileand may affectdesktopTested only on iOS-Simulator so far (all below were done in iOS-Simulator)
homeandchatscreen checked turning on/off networkwallet offlinemessage shows and does not go away; But I think it is not related to this PR.homescreen checked triggering/focusing/entering text/cancelling withchat searchhomescreen added more chats than fits the height of screen, checked scrolling, navigating to different chatshomescreen deleted chatsIn some manual tests above, problems were found and resolved
status: ready for review