[#8945] "null is not an object" error when tap on sticker sent in chat

[flexsurfer]

fixes #8945

tested on ios simulator

[status-github-bot]

Pull Request Checklist

• Docs: Updated the documentation, if affected
• Docs: Added or updated inline comments explaining intention of the code
• Tests: Ensured that all new UI elements have been assigned accessibility IDs
• Tests: Signaled need for E2E tests with label, if applicable
• Tests: Briefly described what was tested and what platforms were used
• UI: In case of UI changes, ensured that UI matches Figma
• UI: In case of UI changes, requested review from a Core UI designer
• UI: In case of UI changes, included screenshots of implementation

[status-im-auto]

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	902f83b	#1	2019-09-30 10:38:57	~9 min	ios	📦ipa 📲
✔️	902f83b	#1	2019-09-30 10:42:08	~12 min	android-e2e	📦apk 📲
✔️	902f83b	#1	2019-09-30 10:42:16	~12 min	android	📦apk 📲
✔️	902f83b	#1	2019-09-30 10:42:23	~13 min	macos	📦dmg
✔️	902f83b	#1	2019-09-30 10:44:27	~15 min	linux	📦App
✔️	902f83b	#1	2019-09-30 10:45:32	~16 min	windows	📦exe

[statustestbot]

85% of end-end tests have passed

Total executed tests: 47
Failed tests: 7
Passed tests: 40

Failed tests (7)

Click to expand

1. test_send_transaction_from_daap

Device 1: Wait for OkButton Device 1: Tap on OkButton Balance is not changed during 360 seconds, funds were not received! Device sessions Device 1: Steps, video, logs Failure screenshot

2. test_deploy_contract_from_daap

Device 1: Tap on SignButton Device 1: Wait for OkButton Device 1: 'OkButton' is not found on the screen; also Unexpected Alert is shown: 'Consider it complete after 12 confirmations on the network.' Device sessions Device 1: Steps, video, logs Failure screenshot

3. test_send_token_with_7_decimals

Device 1: Wait for OkButton Device 1: Tap on OkButton Transaction with amount 0.0934991 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D Device sessions Device 1: Steps, video, logs Failure screenshot

4. test_modify_transaction_fee_values

Device 1: Tap on SignButton Device 1: Looking for an element by text: 'intrinsic gas too low' Device 1: 'BaseText' is not found on the screen; also Unexpected Alert is shown: 'intrinsic gas too low' Device sessions Device 1: Steps, video, logs Failure screenshot

5. test_send_eth_from_wallet_to_address

Device 1: Wait for OkButton Device 1: Tap on OkButton Transaction with amount 0.003012219 is not found in list of transactions, address is 9164f86170290ba3080e37d19d1953d3c5945913 Device sessions Device 1: Steps, video, logs Failure screenshot

6. test_logcat_backup_recovery_phrase

Device 1: Tap on DoneButton Device 1: Tap on YesButton Device 1: ['Passphrase1 in logcat!!!', 'Passphrase2 in logcat!!!'] Device sessions Device 1: Steps, video, logs Failure screenshot

7. test_send_stt_from_wallet

Device 1: Wait for OkButton Device 1: Tap on OkButton Transaction with amount 0.0030121643 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (40)

Click to expand

1. test_block_user_from_public_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

2. test_filters_from_daap

Device sessions Device 1: Steps, video, logs

3. test_copy_and_paste_messages

Device sessions Device 1: Steps, video, logs

4. test_open_transaction_on_etherscan

Device sessions Device 1: Steps, video, logs

5. test_public_chat_messaging

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

6. test_long_press_to_delete_1_1_chat

Device sessions Device 1: Steps, video, logs

7. test_password_in_logcat_sign_in

Device sessions Device 1: Steps, video, logs

8. test_text_message_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

9. test_add_to_contacts

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

10. test_sign_typed_message

Device sessions Device 1: Steps, video, logs

11. test_unread_messages_counter_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

12. test_ens_in_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

13. test_logcat_send_transaction_from_daap

Device sessions Device 1: Steps, video, logs

14. test_send_message_in_group_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

15. test_logcat_send_transaction_from_wallet

Device sessions Device 1: Steps, video, logs

16. test_offline_messaging_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

17. test_add_account_to_multiaccount_instance

Device sessions Device 1: Steps, video, logs

18. test_manage_assets

Device sessions Device 1: Steps, video, logs

19. test_long_press_to_delete_public_chat

Device sessions Device 1: Steps, video, logs

20. test_send_emoji

Device sessions Device 1: Steps, video, logs

21. test_search_chat_on_home

Device sessions Device 1: Steps, video, logs

22. test_logcat_recovering_account

Device sessions Device 1: Steps, video, logs

23. test_can_add_existing_ens

Device sessions Device 1: Steps, video, logs

24. test_messaging_in_different_networks

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

25. test_logcat_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

26. test_switch_users_and_add_new_account

Device sessions Device 1: Steps, video, logs

27. test_login_with_new_account

Device sessions Device 1: Steps, video, logs

28. test_start_chat_with_ens

Device sessions Device 1: Steps, video, logs

29. test_add_contact_from_public_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

30. test_send_two_transactions_one_after_another_in_dapp

Device sessions Device 1: Steps, video, logs

31. test_password_in_logcat_creating_account

Device sessions Device 1: Steps, video, logs

32. test_backup_recovery_phrase

Device sessions Device 1: Steps, video, logs

33. test_offline_status

Device sessions Device 1: Steps, video, logs

34. test_open_google_com_via_open_dapp

Device sessions Device 1: Steps, video, logs

35. test_unread_messages_counter_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

36. test_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

37. test_user_can_remove_profile_picture

Device sessions Device 1: Steps, video, logs

38. test_share_contact_code_and_wallet_address

Device sessions Device 1: Steps, video, logs

39. test_refresh_button_browsing_app_webview

Device sessions Device 1: Steps, video, logs

40. test_backup_recovery_phrase_warning_from_wallet

Device sessions Device 1: Steps, video, logs

[yenda]

@churik what happened with e2e tests here? The failures don't seem to be related to the changes

[flexsurfer]

@yenda @churik @Serhy it seems we have broken e2e in develop, because i can see same results for all PRs

[Serhy]

I reviewed above tests:
Those which failed with Transaction with amount **** is not found in list of transactions... failed because transaction were not mined in the next 6mins after it sent. This is etherscan info for above two addresses https://ropsten.etherscan.io/address/0x9164f86170290ba3080e37d19d1953d3c5945913 and https://ropsten.etherscan.io/address/0xf184747445c3B85CEb147DfB136067CB93d95F1D
I am not sure yet why there is a bunch of pending transactions since I just sent tx between my accounts (in Ropsten) with 2Gwei price and it got confirmation within next 30 seconds... The same gas price I see as the latest tx for above addresses but why it is not picked up by miners (and so all the rest txs are pending as well)...

test_modify_transaction_fee_values - failed because signing of the respective tx were last > 10 sec. I'd say this is more app failure (common fail not this PR fail) rather than test fail. So this test clicks 'Sign' transaction button and what happened is that the process of signing tx (with the spinning spinner) lasts > 10 sec.
But I'll increase the time to wait for transaction sign in process.

test_logcat_backup_recovery_phrase test: false failure (rare case here) where two words from sign in phrase are in logcat but they were used as part of valid logs (currently it was 'expand' and 'index' words). I'll update this test too separately.

[yenda]

was this PR tested? does it fix the bug?

[Serhy]

Tested with iOS 12.3, Android 8.1, Android 6.0.1 - can't reproduce the bug.

[statustestbot]

89% of end-end tests have passed

Total executed tests: 47
Failed tests: 5
Passed tests: 42

Failed tests (5)

Click to expand

1. test_send_transaction_from_daap

Device 1: Wait for OkButton Device 1: Tap on OkButton Balance is not changed during 360 seconds, funds were not received! Device sessions Device 1: Steps, video, logs Failure screenshot

2. test_send_token_with_7_decimals

Device 1: Wait for OkButton Device 1: Tap on OkButton Transaction with amount 0.0258121 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D Device sessions Device 1: Steps, video, logs Failure screenshot

3. test_modify_transaction_fee_values

Device 1: Wait for OkButton Device 1: Tap on OkButton Transaction with amount 0.0030181238 is not found in list of transactions, address is b92496fffd668c2de08694623303456aa98cdf33 Device sessions Device 1: Steps, video, logs Failure screenshot

4. test_send_eth_from_wallet_to_address

Device 1: Wait for OkButton Device 1: Tap on OkButton Transaction with amount 0.0030175917 is not found in list of transactions, address is 9164f86170290ba3080e37d19d1953d3c5945913 Device sessions Device 1: Steps, video, logs Failure screenshot

5. test_send_stt_from_wallet

Device 1: Wait for OkButton Device 1: Tap on OkButton Transaction with amount 0.0030181335 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (42)

Click to expand

1. test_block_user_from_public_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

2. test_filters_from_daap

Device sessions Device 1: Steps, video, logs

3. test_copy_and_paste_messages

Device sessions Device 1: Steps, video, logs

4. test_deploy_contract_from_daap

Device sessions Device 1: Steps, video, logs

5. test_open_transaction_on_etherscan

Device sessions Device 1: Steps, video, logs

6. test_public_chat_messaging

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_long_press_to_delete_1_1_chat

Device sessions Device 1: Steps, video, logs

8. test_password_in_logcat_sign_in

Device sessions Device 1: Steps, video, logs

9. test_text_message_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

10. test_add_to_contacts

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

11. test_sign_typed_message

Device sessions Device 1: Steps, video, logs

12. test_unread_messages_counter_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

13. test_ens_in_public_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

14. test_logcat_send_transaction_from_daap

Device sessions Device 1: Steps, video, logs

15. test_send_message_in_group_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

16. test_logcat_send_transaction_from_wallet

Device sessions Device 1: Steps, video, logs

17. test_offline_messaging_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

18. test_add_account_to_multiaccount_instance

Device sessions Device 1: Steps, video, logs

19. test_manage_assets

Device sessions Device 1: Steps, video, logs

20. test_long_press_to_delete_public_chat

Device sessions Device 1: Steps, video, logs

21. test_send_emoji

Device sessions Device 1: Steps, video, logs

22. test_search_chat_on_home

Device sessions Device 1: Steps, video, logs

23. test_logcat_recovering_account

Device sessions Device 1: Steps, video, logs

24. test_can_add_existing_ens

Device sessions Device 1: Steps, video, logs

25. test_messaging_in_different_networks

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

26. test_logcat_backup_recovery_phrase

Device sessions Device 1: Steps, video, logs

27. test_logcat_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

28. test_switch_users_and_add_new_account

Device sessions Device 1: Steps, video, logs

29. test_login_with_new_account

Device sessions Device 1: Steps, video, logs

30. test_start_chat_with_ens

Device sessions Device 1: Steps, video, logs

31. test_add_contact_from_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

32. test_send_two_transactions_one_after_another_in_dapp

Device sessions Device 1: Steps, video, logs

33. test_password_in_logcat_creating_account

Device sessions Device 1: Steps, video, logs

34. test_backup_recovery_phrase

Device sessions Device 1: Steps, video, logs

35. test_offline_status

Device sessions Device 1: Steps, video, logs

36. test_open_google_com_via_open_dapp

Device sessions Device 1: Steps, video, logs

37. test_unread_messages_counter_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

38. test_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

39. test_user_can_remove_profile_picture

Device sessions Device 1: Steps, video, logs

40. test_share_contact_code_and_wallet_address

Device sessions Device 1: Steps, video, logs

41. test_refresh_button_browsing_app_webview

Device sessions Device 1: Steps, video, logs

42. test_backup_recovery_phrase_warning_from_wallet

Device sessions Device 1: Steps, video, logs