Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycard pin screen fixes #9086

Merged
merged 1 commit into from
Nov 8, 2019
Merged

keycard pin screen fixes #9086

merged 1 commit into from
Nov 8, 2019

Conversation

dmitryn
Copy link
Contributor

@dmitryn dmitryn commented Oct 1, 2019 •
edited by StatusWrike
Loading

fixes #8993
fixes #9059

Summary

  • adjust pin enter screen layout for small screen devices
  • fix pin reset / unblock flow
  • fix sign with keycard button in wallet
  • show warning message when pin blocked and puk being entered
  • show pin retry counter
  • show free pairing slots on device pairing

status: ready

@dmitryn dmitryn added the keycard label Oct 1, 2019
@dmitryn dmitryn requested review from vitvly, yenda and flexsurfer October 1, 2019 16:40
@dmitryn dmitryn requested a review from a team as a code owner October 1, 2019 16:40
@dmitryn dmitryn self-assigned this Oct 1, 2019
@auto-assign auto-assign bot removed the request for review from a team October 1, 2019 16:40
@ghost
Copy link

ghost commented Oct 1, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch from 2ea6604 to a02dce3 Compare October 1, 2019 16:40
@status-im-auto
Copy link
Member

status-im-auto commented Oct 1, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (42)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a02dce3 #2 2019-10-01 16:44:29 ~3 min macos 📄log
❌ a02dce3 #2 2019-10-01 16:50:08 ~9 min linux 📄log
❌ a02dce3 #2 2019-10-01 16:50:14 ~9 min windows 📄log
✔️ a02dce3 #2 2019-10-01 16:51:16 ~10 min ios 📦ipa 📲
✔️ a02dce3 #2 2019-10-01 16:58:40 ~17 min android 📦apk 📲
✔️ a02dce3 #2 2019-10-01 17:00:03 ~19 min android-e2e 📦apk 📲
✔️ cf648de #3 2019-10-02 12:49:27 ~8 min ios 📦ipa 📲
✔️ cf648de #3 2019-10-02 12:52:02 ~11 min macos 📦dmg
✔️ cf648de #3 2019-10-02 12:52:19 ~11 min linux 📦App
✔️ cf648de #3 2019-10-02 12:53:55 ~13 min windows 📦exe
✔️ cf648de #3 2019-10-02 12:56:32 ~16 min android 📦apk 📲
✔️ cf648de #3 2019-10-02 12:57:47 ~17 min android-e2e 📦apk 📲
✔️ 934f769 #4 2019-10-08 09:01:30 ~12 min macos 📦dmg
✔️ 934f769 #4 2019-10-08 09:02:44 ~13 min ios 📦ipa 📲
✔️ 934f769 #4 2019-10-08 09:12:05 ~23 min android-e2e 📦apk 📲
✔️ 934f769 #4 2019-10-08 09:12:22 ~23 min android 📦apk 📲
✔️ 934f769 #4 2019-10-08 09:12:25 ~23 min linux 📦App
✔️ 934f769 #4 2019-10-08 09:14:40 ~25 min windows 📦exe
✔️ b95b3dd #5 2019-10-08 11:28:55 ~8 min ios 📦ipa 📲
✔️ b95b3dd #5 2019-10-08 11:32:35 ~12 min macos 📦dmg
✔️ b95b3dd #5 2019-10-08 11:33:05 ~12 min linux 📦App
✔️ b95b3dd #5 2019-10-08 11:34:29 ~14 min android-e2e 📦apk 📲
✔️ b95b3dd #5 2019-10-08 11:34:34 ~14 min android 📦apk 📲
✔️ b95b3dd #5 2019-10-08 11:35:13 ~14 min windows 📦exe
❌ e82d015 #6 2019-10-09 13:52:31 ~28 sec android 📄log
❌ e82d015 #6 2019-10-09 13:52:31 ~26 sec ios 📄log
❌ e82d015 #6 2019-10-09 13:52:33 ~27 sec linux 📄log
❌ e82d015 #6 2019-10-09 13:52:33 ~24 sec windows 📄log
❌ e82d015 #6 2019-10-09 13:52:33 ~25 sec macos 📄log
✔️ e82d015 #6 2019-10-09 14:05:01 ~13 min android-e2e 📦apk 📲
✔️ 1a4e213 #7 2019-10-10 10:41:10 ~8 min ios 📦ipa 📲
✔️ 1a4e213 #7 2019-10-10 10:44:02 ~11 min linux 📦App
✔️ 1a4e213 #7 2019-10-10 10:44:38 ~12 min macos 📦dmg
✔️ 1a4e213 #7 2019-10-10 10:45:06 ~12 min windows 📦exe
✔️ 1a4e213 #7 2019-10-10 10:47:37 ~15 min android-e2e 📦apk 📲
✔️ 1a4e213 #7 2019-10-10 10:47:45 ~15 min android 📦apk 📲
✔️ e3a2486 #8 2019-10-11 10:29:30 ~11 min ios 📦ipa 📲
✔️ e3a2486 #8 2019-10-11 10:29:56 ~11 min linux 📦App
✔️ e3a2486 #8 2019-10-11 10:31:08 ~12 min windows 📦exe
✔️ e3a2486 #8 2019-10-11 10:31:30 ~13 min macos 📦dmg
✔️ e3a2486 #8 2019-10-11 10:33:28 ~15 min android-e2e 📦apk 📲
✔️ e3a2486 #9 2019-10-11 17:01:28 ~15 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ af34d88 #10 2019-11-06 09:36:46 ~10 min ios 📦ipa 📲
✔️ af34d88 #10 2019-11-06 09:39:04 ~13 min android-e2e 📦apk 📲
✔️ af34d88 #11 2019-11-06 09:39:06 ~13 min android 📦apk 📲
✔️ af34d88 #10 2019-11-06 09:39:22 ~13 min linux 📦App
✔️ af34d88 #10 2019-11-06 09:39:41 ~13 min windows 📦exe
✔️ af34d88 #10 2019-11-06 09:40:59 ~15 min macos 📦dmg
✔️ 2a9da59 #11 2019-11-08 11:22:39 ~8 min ios 📦ipa 📲
✔️ 2a9da59 #11 2019-11-08 11:27:05 ~13 min macos 📦dmg
✔️ 2a9da59 #11 2019-11-08 11:27:20 ~13 min windows 📦exe
✔️ 2a9da59 #11 2019-11-08 11:27:29 ~13 min linux 📦App
✔️ 2a9da59 #11 2019-11-08 11:29:17 ~15 min android-e2e 📦apk 📲
✔️ 2a9da59 #12 2019-11-08 11:29:23 ~15 min android 📦apk 📲

@churik
Copy link
Member

churik commented Oct 2, 2019

@dmitryn please, describe briefly what you tested and what devices did you use.
Thanks.

@dmitryn
Copy link
Contributor Author

dmitryn commented Oct 2, 2019

@churik i was adjusting pin screen for AVD virtual device with 480x800 resolution

@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch from cf648de to 934f769 Compare October 8, 2019 08:48
@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 47
Failed tests: 1
Passed tests: 46

Failed tests (1)

Click to expand
1. test_backup_recovery_phrase

Device 1: Tap on NextButton
Device 1: Tap on MaybeLaterButton

Device 1: 'MaybeLaterButton' is not found on the screen

Device sessions

Passed tests (46)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_ens_in_public_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_offline_messaging_1_1_chat
Device sessions

20. test_modify_transaction_fee_values
Device sessions

21. test_send_eth_from_wallet_to_address
Device sessions

22. test_add_account_to_multiaccount_instance
Device sessions

23. test_manage_assets
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_messaging_in_different_networks
Device sessions

30. test_logcat_backup_recovery_phrase
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_login_with_new_account
Device sessions

35. test_start_chat_with_ens
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture (TestRail link is not found)
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

46. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch from 934f769 to b95b3dd Compare October 8, 2019 11:20
@churik
Copy link
Member

churik commented Oct 8, 2019

@dmitryn failed e2e is not related to your PR.

@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch 2 times, most recently from e82d015 to 1a4e213 Compare October 10, 2019 10:32
@yenda yenda requested review from andmironov and errorists October 10, 2019 19:02
@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch from 1a4e213 to e3a2486 Compare October 11, 2019 10:17
@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
@guylouis
Copy link
Contributor

hey! I need your help understanding what needs to be done to have this one merged. Just following-up on if #8993 and #9059 can be considered closed

@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
@andmironov
Copy link

andmironov commented Oct 21, 2019 •
edited
Loading

Hey! Here are the issues that i've spotted:

Step 1

  • “Recover key” should be renamed to “Access key". "Access key" should be a white block aligned to the bottom with a 1px border at the top. Tap on “Access key" should open a bottom sheet. Tap on "..." in the toolbar should open a bottom sheet as well, but with a single option "Get a new key";

Screen Shot 2019-10-21 at 11 40 30

  • The bottom sheet itself has extra top and bottom paddings. Please keep in mind that in Figma the bottom sheet has extra spacing for iOS's virtual home button which is not needed on all devices

  • The active state of the numpad is missing;

  • “2 retries yet” message is shown incorrectly.

  • The error is persistent, should flash for a ~5 seconds and disappear;

Screen Shot 2019-10-21 at 11 40 15

Step 2

  • If the connection on step 2 is interrupted, I see an endless spinner in the popup.

111

  • The desired behavior of this popup is it to disappear after the connection is re-established. The layout and design of this popup has also slightly changed. I also suggest to show an "Are you sure" prompt after the user cancels;

  • If I tap “Cancel” in the popup I see the welcome screen, but instead, I should see the sign-in step 1 again (or If I have several keys, the “Your keys” screen);

Screen Shot 2019-10-21 at 11 53 31

  • Are we implementing the "Remember me" aka "Don't ask for keycard all the time"? If so, the layout is a bit different. If we implement biometrics ontop it also has a popup shown after the checkbox is checked;

Screen Shot 2019-10-21 at 11 40 49

Screen Shot 2019-10-21 at 12 09 12

P.S

  • We never mention that in order to check if the passcode is correct the user needs to tap the card first. Should we? (No design for that yet, just asking);
  • What about these errors?

Screen Shot 2019-10-21 at 11 41 05

  • What about Frozen accounts?

Screen Shot 2019-10-21 at 12 03 51

Everything I mentioned above is in Figma here https://www.figma.com/file/dEIljL7UPbXgsZUA0Q4qlE5E/Onboarding?node-id=4566%3A12

cc @guylouis

andmironov
andmironov reviewed Oct 21, 2019
View reviewed changes
Copy link

@andmironov andmironov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my review in the comment above

@andmironov
Copy link

andmironov commented Oct 22, 2019 •
edited
Loading

UPD added smaller versions for main screens with specs

Screen Shot 2019-10-22 at 11 30 54

Screen Shot 2019-10-22 at 11 30 45

Figma https://www.figma.com/file/dEIljL7UPbXgsZUA0Q4qlE5E/Onboarding?node-id=5314%3A15

yenda
yenda approved these changes Nov 6, 2019
View reviewed changes
translations/en.json Outdated Show resolved Hide resolved
@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch from e3a2486 to 4fa49fd Compare November 6, 2019 09:23
@dmitryn
Copy link
Contributor Author

dmitryn commented Nov 6, 2019

@andmironov thanks for the input! I suggest to create separate issues from the points you mentioned and proceed with merging current PR as it's open for a while.

@guylouis
Copy link
Contributor

guylouis commented Nov 6, 2019

is @andmironov agreement the only thing missing to merge these changes ?

@dmitryn
Copy link
Contributor Author

dmitryn commented Nov 7, 2019

@guylouis yes. This PR addresses/fixes issues #8993 #9086

What @andmironov is suggesting should be addressed too, but in next PRs.

@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch from af34d88 to 2a9da59 Compare November 8, 2019 11:13
@dmitryn
[#8993] adjust pin screens for small screen devices
5e7785d 
find account by key-uid

show pairing slots info on pairing

fix pin reset flow

pass retry-counter

fix sign with keycard button in wallet

Signed-off-by: Dmitry Novotochinov <dmitry.novot@gmail.com>
@dmitryn dmitryn force-pushed the bug/8993-login-screen-small-screens branch from 2a9da59 to 5e7785d Compare November 8, 2019 14:01
@dmitryn dmitryn merged commit 5e7785d into develop Nov 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/8993-login-screen-small-screens branch November 8, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andmironov andmironov andmironov left review comments

@yenda yenda yenda approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@vitvly vitvly Awaiting requested review from vitvly

@errorists errorists Awaiting requested review from errorists

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
8 participants
@dmitryn @status-im-auto @churik @statustestbot @guylouis @andmironov @yenda @flexsurfer