Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-native-gesture-handler from 1.3.0 to 1.4.1 in /desktop/js_files #9100

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps react-native-gesture-handler from 1.3.0 to 1.4.1.

Release notes

Sourced from react-native-gesture-handler's releases.

1.4.1

Patch release to include component memoization logic fix by @​janicduplessis #654

1.4.0

IMPORTANT!! This version is compatible with React Native @ 0.60+

This version brings support for gesture-handler to react-native-web projects. Many thanks and congratulations to @​EvanBacon for working on this project 🎉 🍾 🙇

As a part of this release we publish changes to resolve compatibility issues with AndroidX that has broken support for imported projects (they way most react native apps are consumed by third party). As upgrade to 0.59 is required in order to be able to publish updates to google play store we decided to publish a release that is only compatible with 0.60 hoping for the community to update to one of the most recent versions of react native anyways.

It is possible to use this release with RN < 0.60 but one have to rely on reverse-jetifying of gesture handler library. Read more on that here https://github.com/mikehardy/jetifier#to-reverse-jetify--convert-node_modules-dependencies-to-support-libraries

🎉 NEW FEATURES

🐛 BUG FIXES

👍 IMPROVEMENTS

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@status-im-auto
Copy link
Member

status-im-auto commented Oct 3, 2019

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fc134d8 #1 2019-10-03 05:51:32 ~9 min ios 📦ipa 📲
✔️ fc134d8 #1 2019-10-03 05:55:00 ~12 min android-e2e 📦apk 📲
✔️ fc134d8 #1 2019-10-03 05:55:00 ~12 min android 📦apk 📲
✔️ fc134d8 #1 2019-10-03 05:55:25 ~13 min macos 📦dmg
✔️ fc134d8 #1 2019-10-03 05:56:55 ~14 min linux 📦App
✔️ fc134d8 #1 2019-10-03 05:58:02 ~15 min windows 📦exe
✔️ 4ba3084 #2 2019-10-03 10:04:48 ~10 min ios 📦ipa 📲
✔️ 4ba3084 #2 2019-10-03 10:08:08 ~14 min android 📦apk 📲
✔️ 4ba3084 #2 2019-10-03 10:08:11 ~14 min android-e2e 📦apk 📲
✔️ 4ba3084 #2 2019-10-03 10:08:26 ~14 min macos 📦dmg
✔️ 4ba3084 #2 2019-10-03 10:08:49 ~14 min linux 📦App
✔️ 4ba3084 #2 2019-10-03 10:09:14 ~15 min windows 📦exe

@status-github-bot
Copy link

status-github-bot bot commented Oct 3, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@pedropombeiro pedropombeiro force-pushed the dependabot/npm_and_yarn/desktop/js_files/react-native-gesture-handler-1.4.1 branch from fc134d8 to 4ba3084 Compare October 3, 2019 09:53
@dependabot-preview dependabot-preview bot requested a review from a team as a code owner October 3, 2019 09:53
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@pedropombeiro
Copy link
Contributor

I'm not sure what part of the code is affected by this library in order to narrow down what needs to be tested.

@jakubgs
Copy link
Member

jakubgs commented Oct 3, 2019

Do we even use gestures? I don't recall such functionality...

@vkjr
Copy link
Contributor

vkjr commented Oct 3, 2019

It is used by react-navigation library since v3

@flexsurfer flexsurfer added the bot label Oct 4, 2019
@jakubgs jakubgs closed this Oct 4, 2019
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/desktop/js_files/react-native-gesture-handler-1.4.1 branch October 4, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants