Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean package json #9102

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Clean package json #9102

merged 1 commit into from
Oct 4, 2019

Conversation

pedropombeiro
Copy link
Contributor

@pedropombeiro pedropombeiro commented Oct 3, 2019 •
edited by StatusWrike
Loading

Summary

We are trying to do the job of yarn.lock in package.json by hardcoding the version number instead of allowing a range. By allowing a range, we let tools like dependabot inform us when new releases are available.

Review notes

Testing notes

This is a purely aesthetical PR, no changes in functionality are expected.

status: ready

@pedropombeiro pedropombeiro requested a review from a team as a code owner October 3, 2019 10:20
@pedropombeiro pedropombeiro self-assigned this Oct 3, 2019
@auto-assign auto-assign bot removed the request for review from a team October 3, 2019 10:20
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@status-github-bot
Copy link

status-github-bot bot commented Oct 3, 2019 •
edited by pedropombeiro
Loading

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Oct 3, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 067fb09 #1 2019-10-03 10:30:24 ~9 min ios 📦ipa 📲
✔️ 067fb09 #1 2019-10-03 10:32:29 ~11 min macos 📦dmg
✔️ 067fb09 #1 2019-10-03 10:33:17 ~12 min android-e2e 📦apk 📲
✔️ 067fb09 #1 2019-10-03 10:34:31 ~13 min windows 📦exe
✔️ 067fb09 #1 2019-10-03 10:36:33 ~15 min linux 📦App
✔️ 067fb09 #1 2019-10-03 10:37:31 ~16 min android 📦apk 📲
✔️ 4e440d1 #2 2019-10-04 10:21:25 ~9 min ios 📦ipa 📲
✔️ 4e440d1 #2 2019-10-04 10:24:11 ~12 min macos 📦dmg
✔️ 4e440d1 #2 2019-10-04 10:24:25 ~12 min android 📦apk 📲
✔️ 4e440d1 #2 2019-10-04 10:25:16 ~13 min windows 📦exe
✔️ 4e440d1 #2 2019-10-04 10:28:10 ~16 min linux 📦App
✔️ 4e440d1 #2 2019-10-04 10:28:42 ~16 min android-e2e 📦apk 📲

jakubgs
jakubgs approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.
thumb_up

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 47
Failed tests: 1
Passed tests: 46

Failed tests (1)

Click to expand
1. test_block_user_from_public_chat

Device 1: Type 'Before block from 1' to ChatMessageInput
Device 1: Tap on SendMessageButton

Device 2: 'ChatMessageInput' is not found on the screen

Device sessions

Passed tests (46)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_deploy_contract_from_daap
Device sessions

5. test_open_transaction_on_etherscan
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_long_press_to_delete_1_1_chat
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_ens_in_public_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_offline_messaging_1_1_chat
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_add_account_to_multiaccount_instance
Device sessions

22. test_manage_assets
Device sessions

23. test_long_press_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_can_add_existing_ens
Device sessions

28. test_messaging_in_different_networks
Device sessions

29. test_logcat_backup_recovery_phrase
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_login_with_new_account
Device sessions

34. test_start_chat_with_ens
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

46. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@jakubgs
Copy link
Member

jakubgs commented Oct 4, 2019

Please squash this PR.

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

Allow Node.js packages to be upgraded by dependabot
e8627f0 
- Move dev dependencies to `devDependencies`

Signed-off-by: Pedro Pombeiro <pombeirp@users.noreply.github.com>
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@pedropombeiro pedropombeiro merged commit e8627f0 into develop Oct 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the clean_package_json branch October 4, 2019 10:12
@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

@vkjr vkjr vkjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pedropombeiro @status-im-auto @statustestbot @jakubgs @vkjr