Suppress back-up-seed prompt when already done (fixes #8938) #9105

acolytec3 · 2019-10-03T20:54:00Z

fixes #8938

Summary

Suppresses backup-seed-phrase option on Pirvacy & Security screen when already backed up

Platforms

Android
iOS

Areas that maybe impacted

Privacy & Security Settings

Functional

Privacy & Security Settings

Steps to test

Open Status
Open Profile
Open Privacy & Security Settings
Back up seed phrase
Navigate back to Privacy & Security Settings
Security section will be suppressed

status: ready

Visual representation on Android

ghost · 2019-10-03T20:54:05Z

Pull Request Checklist

Docs: Updated the documentation, if affected
Docs: Added or updated inline comments explaining intention of the code
Tests: Ensured that all new UI elements have been assigned accessibility IDs
Tests: Signaled need for E2E tests with label, if applicable
Tests: Briefly described what was tested and what platforms were used
UI: In case of UI changes, ensured that UI matches Figma
UI: In case of UI changes, requested review from a Core UI designer
UI: In case of UI changes, included screenshots of implementation

acolytec3 · 2019-10-03T20:55:18Z

To reviewers, is the preference to suppress the whole security section when the backup seed has been saved, just the backup-seed menu option, or else to present the backup-seed option disabled?

As currently coded, it suppresses the whole section since this is what the original issue states as the preferred outcome.

status-im-auto · 2019-10-03T21:04:43Z

Jenkins Builds

Click to see older builds (25)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`40e4722`	#1	2019-10-03 21:04:42	~10 min	`ios`	📦`ipa` 📲
✔️	`40e4722`	#1	2019-10-03 21:06:25	~12 min	`macos`	📦`dmg`
✔️	`40e4722`	#1	2019-10-03 21:07:11	~12 min	`linux`	📦`App`
✔️	`40e4722`	#1	2019-10-03 21:07:46	~13 min	`windows`	📦`exe`
✔️	`40e4722`	#1	2019-10-03 21:09:48	~15 min	`android-e2e`	📦`apk` 📲
✔️	`40e4722`	#1	2019-10-03 21:09:48	~15 min	`android`	📦`apk` 📲

❌	`b5e9c84`	#2	2019-10-04 11:03:24	~1 min	`ios`	📄`log`
❌	`b5e9c84`	#2	2019-10-04 11:03:42	~1 min	`macos`	📄`log`
❌	`b5e9c84`	#2	2019-10-04 11:09:46	~8 min	`android`	📄`log`
❌	`b5e9c84`	#2	2019-10-04 11:10:08	~8 min	`linux`	📄`log`
❌	`b5e9c84`	#2	2019-10-04 11:10:21	~8 min	`windows`	📄`log`
✔️	`b5e9c84`	#2	2019-10-04 11:20:49	~19 min	`android-e2e`	📦`apk` 📲

❌	`e2b5b7d`	#3	2019-10-04 11:51:43	~8 min	`ios`	📄`log`
❌	`e2b5b7d`	#3	2019-10-04 11:55:58	~12 min	`macos`	📄`log`
❌	`e2b5b7d`	#3	2019-10-04 11:56:44	~13 min	`linux`	📄`log`
❌	`e2b5b7d`	#3	2019-10-04 11:56:59	~13 min	`windows`	📄`log`
❌	`e2b5b7d`	#3	2019-10-04 11:57:27	~14 min	`android-e2e`	📄`log`
❌	`e2b5b7d`	#3	2019-10-04 11:57:44	~14 min	`android`	📄`log`
❌	`e2b5b7d`	#4	2019-10-04 15:56:08	~10 min	`ios`	📄`log`

✔️	`6761df7`	#5	2019-10-04 16:54:50	~10 min	`ios`	📦`ipa` 📲
✔️	`6761df7`	#4	2019-10-04 16:56:32	~12 min	`macos`	📦`dmg`
✔️	`6761df7`	#4	2019-10-04 16:57:02	~12 min	`windows`	📦`exe`
✔️	`6761df7`	#4	2019-10-04 16:57:36	~13 min	`linux`	📦`App`
✔️	`6761df7`	#4	2019-10-04 16:59:31	~15 min	`android-e2e`	📦`apk` 📲
✔️	`6761df7`	#4	2019-10-04 16:59:36	~15 min	`android`	📦`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c662fe8`	#6	2019-10-04 17:19:13	~8 min	`ios`	📦`ipa` 📲
✔️	`c662fe8`	#5	2019-10-04 17:22:20	~11 min	`macos`	📦`dmg`
✔️	`c662fe8`	#5	2019-10-04 17:23:54	~13 min	`windows`	📦`exe`
✔️	`c662fe8`	#5	2019-10-04 17:24:46	~14 min	`linux`	📦`App`
✔️	`c662fe8`	#5	2019-10-04 17:27:44	~17 min	`android`	📦`apk` 📲
✔️	`c662fe8`	#5	2019-10-04 17:28:11	~17 min	`android-e2e`	📦`apk` 📲

✔️	`3596899`	#8	2019-10-04 18:22:03	~8 min	`ios`	📦`ipa` 📲
✔️	`3596899`	#7	2019-10-04 18:25:13	~11 min	`android-e2e`	📦`apk` 📲
✔️	`3596899`	#7	2019-10-04 18:25:15	~11 min	`macos`	📦`dmg`
✔️	`3596899`	#7	2019-10-04 18:25:27	~11 min	`linux`	📦`App`
✔️	`3596899`	#7	2019-10-04 18:25:33	~12 min	`android`	📦`apk` 📲
✔️	`3596899`	#7	2019-10-04 18:28:13	~14 min	`windows`	📦`exe`

src/status_im/ui/screens/privacy_and_security_settings/views.cljs

acolytec3 · 2019-10-04T11:46:02Z

@flexsurfer I fixed the merge conflict and it looks another security option around biometric auth got added so I moved the parens to just be around the backup seed phrase option. Unfortunately,my local environment has gotten hosed somehow so I'm not able to run the app locally so can't produce a new visual. Once I get it rebuilt, I'll post one but it may be a while.

andmironov · 2019-10-04T12:02:31Z

Hey! Thanks for bringing this up!

What if we do something like this? But I have not considered all the possible security implications of this? Is this some sort of vulnerability, to show that the seed phrase has been already backed up?

acolytec3 · 2019-10-04T12:20:05Z

@andmironov That should be pretty straight-forward. Let me get my dev environment rebuilt and I can code that. @flexsurfer What do you think of that approach?

andmironov · 2019-10-04T13:09:37Z

UPD let's just grey it out with no "Done" not to confuse anyone

~figma https://www.figma.com/file/bPS9GrvMr7LnH7vnkmuveQfd/Settings?node-id=576%3A0

acolytec3 · 2019-10-04T15:14:11Z

@flexsurfer @andmironov Is there an obvious way to override the default styling on the :title element in in the list-items section? I tried applying a conditional {:style {:color colors/gray}} to it and it threw an error. I guess I can always just show an alternate view using a nested-text element in that row but was curious if I'm missing something obvious.

flexsurfer · 2019-10-04T15:55:53Z

@acolytec3 you can use :disabled? prop

churik · 2019-10-04T16:04:30Z

@acolytec3
all builds are failed.
Can you take a look?

src/status_im/ui/screens/privacy_and_security_settings/views.cljs

acolytec3 · 2019-10-04T17:12:16Z

@andmironov @flexsurfer Here's a screengrab from the Android Emulator with the disabled prop and the chevron suppressed. Does this look about right?

Here's the full screen.

@churik I'm not sure what was happening before but it seems like the builds are working again with my latest push? I don't have access to the jenkins logs so can't tell you specifically what's wrong if anything.

src/status_im/ui/screens/privacy_and_security_settings/views.cljs

statustestbot · 2019-10-07T08:29:12Z

96% of end-end tests have passed

Total executed tests: 47
Failed tests: 2
Passed tests: 45

Failed tests (2)

Click to expand

1. test_unread_messages_counter_1_1_chat
Device 2: Tap on NextButton Device 2: Tap on MaybeLaterButton `Device 2: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_offline_messaging_1_1_chat
Device 2: Tap on AirplaneModeButton Device 1: Tap on AirplaneModeButton `Device 1: 'ConnectionStatusText' is still visible on the screen after 30 seconds` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot

Passed tests (45)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
5. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
6. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
7. test_public_chat_messaging
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
9. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
10. test_text_message_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
11. test_add_to_contacts
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
13. test_ens_in_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
14. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
15. test_send_message_in_group_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
16. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
17. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
18. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
19. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
20. test_add_account_to_multiaccount_instance
Device sessions Device 1: Steps, video, logs
21. test_manage_assets
Device sessions Device 1: Steps, video, logs
22. test_long_press_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
23. test_send_emoji
Device sessions Device 1: Steps, video, logs
24. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
25. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
26. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
27. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
28. test_logcat_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
29. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
30. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
31. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
32. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
33. test_start_chat_with_ens
Device sessions Device 1: Steps, video, logs
34. test_add_contact_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
35. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
36. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
37. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
38. test_offline_status
Device sessions Device 1: Steps, video, logs
39. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
40. test_unread_messages_counter_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
41. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
42. test_user_can_remove_profile_picture (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
43. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
44. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
45. test_backup_recovery_phrase_warning_from_wallet
Device sessions Device 1: Steps, video, logs

statustestbot · 2019-10-07T08:43:47Z

50% of end-end tests have passed

Total executed tests: 2
Failed tests: 1
Passed tests: 1

Failed tests (1)

Click to expand

1. test_offline_messaging_1_1_chat
Device 2: Tap on AirplaneModeButton Device 1: Tap on AirplaneModeButton `Device 1: 'ConnectionStatusText' is still visible on the screen after 30 seconds` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot

Passed tests (1)

Click to expand

1. test_unread_messages_counter_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

churik · 2019-10-07T08:45:01Z

Tested (IOS 11.4.1, Android 8):

interruption of the process of "Back up seed phrase" on different stages;
creating account - back up seed phrase
restoring account
creating account with keycard
restoring account with keycard

Failed e2e is not related to this PR.

Thank you for excellent job @acolytec3 !

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

acolytec3 requested a review from a team as a code owner October 3, 2019 20:54

auto-assign bot removed the request for review from a team October 3, 2019 20:54

flexsurfer requested a review from andmironov October 4, 2019 07:16

flexsurfer added bounty community request-manual-qa labels Oct 4, 2019

flexsurfer reviewed Oct 4, 2019

View reviewed changes

src/status_im/ui/screens/privacy_and_security_settings/views.cljs Outdated Show resolved Hide resolved

flexsurfer approved these changes Oct 4, 2019

View reviewed changes

acolytec3 force-pushed the hide-seed-phrase branch from b5e9c84 to e2b5b7d Compare October 4, 2019 11:43

flexsurfer reviewed Oct 4, 2019

View reviewed changes

src/status_im/ui/screens/privacy_and_security_settings/views.cljs Outdated Show resolved Hide resolved

flexsurfer reviewed Oct 4, 2019

View reviewed changes

src/status_im/ui/screens/privacy_and_security_settings/views.cljs Outdated Show resolved Hide resolved

acolytec3 force-pushed the hide-seed-phrase branch from 59371e0 to 3596899 Compare October 4, 2019 18:13

flexsurfer approved these changes Oct 5, 2019

View reviewed changes

weekly-digest bot mentioned this pull request Oct 6, 2019

Weekly Digest (29 September, 2019 - 6 October, 2019) #9110

Closed

churik self-assigned this Oct 7, 2019

churik added the Tested - OK label Oct 7, 2019

Suppress back-up-seed prompt when already done

5ce678e

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

flexsurfer force-pushed the hide-seed-phrase branch from 3596899 to 5ce678e Compare October 7, 2019 10:13

flexsurfer merged commit 5ce678e into status-im:develop Oct 7, 2019

gitcoinbot mentioned this pull request Oct 7, 2019

'Back up seed phrase' in Profile is present for recovered accounts #8938

Closed

weekly-digest bot mentioned this pull request Oct 13, 2019

Weekly Digest (6 October, 2019 - 13 October, 2019) #9186

Closed

hesterbruikman mentioned this pull request Oct 16, 2019

Styling + add date seed phrase backed up #9226

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suppress back-up-seed prompt when already done (fixes #8938) #9105

Suppress back-up-seed prompt when already done (fixes #8938) #9105

acolytec3 commented Oct 3, 2019

ghost commented Oct 3, 2019

acolytec3 commented Oct 3, 2019

status-im-auto commented Oct 3, 2019 •

edited

Loading

acolytec3 commented Oct 4, 2019

andmironov commented Oct 4, 2019

acolytec3 commented Oct 4, 2019

andmironov commented Oct 4, 2019

acolytec3 commented Oct 4, 2019

flexsurfer commented Oct 4, 2019

churik commented Oct 4, 2019

acolytec3 commented Oct 4, 2019 •

edited

Loading

statustestbot commented Oct 7, 2019

statustestbot commented Oct 7, 2019

churik commented Oct 7, 2019

Suppress back-up-seed prompt when already done (fixes #8938) #9105

Suppress back-up-seed prompt when already done (fixes #8938) #9105

Conversation

acolytec3 commented Oct 3, 2019

Summary

Platforms

Areas that maybe impacted

Functional

Steps to test

ghost commented Oct 3, 2019

Pull Request Checklist

acolytec3 commented Oct 3, 2019

status-im-auto commented Oct 3, 2019 • edited Loading

Jenkins Builds

acolytec3 commented Oct 4, 2019

andmironov commented Oct 4, 2019

acolytec3 commented Oct 4, 2019

andmironov commented Oct 4, 2019

acolytec3 commented Oct 4, 2019

flexsurfer commented Oct 4, 2019

churik commented Oct 4, 2019

acolytec3 commented Oct 4, 2019 • edited Loading

statustestbot commented Oct 7, 2019

96% of end-end tests have passed

Failed tests (2)

Passed tests (45)

statustestbot commented Oct 7, 2019

50% of end-end tests have passed

Failed tests (1)

Passed tests (1)

churik commented Oct 7, 2019

status-im-auto commented Oct 3, 2019 •

edited

Loading

acolytec3 commented Oct 4, 2019 •

edited

Loading