-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable high priority tests in PRs #9171
Conversation
Pull Request Checklist
|
What specifically do you need? |
Jenkins BuildsClick to see older builds (52)
|
https://ci.status.im/job/end-to-end-tests/job/status-app-end-to-end-tests/configure - |
Mind if I commit to your branch? I've already created |
Sure thing! Yes, that makes even more sense for it :) |
94% of end-end tests have passed
Failed tests (6)Click to expand
Passed tests (91)Click to expand |
@Serhy can you explain to me how the jobs at https://ci.status.im/job/end-to-end-tests/job/status-app-end-to-end-tests/ are usually triggered? I see some are manual and some are started by @status-im-auto(like #3500. I can't find how that's configured, do you know? |
@jakubgs builds started automatically when PR is moved from 'Review' in to 'E2E Tests' column from board https://github.com/status-im/status-react/projects/7 |
816be81
to
2e2553b
Compare
@jakubgs with dedicated Jenkinsfile.e2e-prs file, am I right that apk value in https://ci.status.im/job/end-to-end-tests/job/status-app-end-to-end-tests/build?delay=0sec should be provided without |
I intend to get rid of that, as I did in the nightly job, just the path/url. Which is why I didn't modify the currently existing job but created a new one: I will do a separate change later which updates the bot to use that one with new parameters. |
I can see what I would have to change in the GitHub bot: |
I've created status-im/status-github-bot#33 to update the bot. |
1f52ab6
to
394ee7d
Compare
93% of end-end tests have passed
Failed tests (7)Click to expand
Passed tests (90)Click to expand |
394ee7d
to
46c0c51
Compare
I don't get it, I ran a manual build and it's all green: |
46c0c51
to
7e5496d
Compare
dd4468f
to
775132b
Compare
Also: - add ci/tests/Jenkinsfile.e2e-prs - remove maybe_later_button click after new onboarding - update job name for e2e tests - Fix testrail checklist creationg for nightly builds Signed-off-by: Jakub Sokołowski <jakub@status.im>
775132b
to
c872c5c
Compare
Made updates in code in order to enable 'high' priority test suite to be run agains PRs.
Will need to update Jenkins job
Also updated a method when enabling airplane mode to be ready to close 'Mmsservice' pop-up which sporadicly may appear on SauceLabs side.