[fix 8853] fix change of whisper id in ens registration #9182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (32)
|
yenda
force-pushed
the
fix/ens-registration
branch
3 times, most recently
from
5d772c8 to
15862f8
Compare
errorists
approved these changes
Oct 15, 2019
61% of end-end tests have passedFailed tests (38)Click to expand
Passed tests (60)Click to expand |
97% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (95)Click to expand |
|
@yenda please, take my commit when squashing, thanks |
100% of end-end tests have passedPassed tests (3)Click to expand
|
|
@flexsurfer @siphiuel please review |
vitvly
approved these changes
Oct 16, 2019
flexsurfer
approved these changes
Oct 16, 2019
yenda
force-pushed
the
fix/ens-registration
branch
from
3e3374b to
617b742
Compare
yenda
force-pushed
the
fix/ens-registration
branch
from
617b742 to
3380ec7
Compare
|
Tested:
|
A user can type in their existing name in the registration flow. Status can confirm if they own it. After signing a transaction, the user can update the Whisper ID to their new one. Instead of using a hardcoded contract for stateofus, the standard `owner` method is called to find the resolver contract of a ens name. This allows users to set the pubkey even for ens names that are not subdomains of stateofus Signed-off-by: yenda <eric@status.im>
yenda
force-pushed
the
fix/ens-registration
branch
from
3380ec7 to
7b6dfad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8853 fix #8484 connect whisper key
fix #8941
A user can type in their existing name in the registration flow. Status can
confirm if they own it. After signing a transaction, the user can update the
Whisper ID to their new one.
Instead of using a hardcoded contract for stateofus, the standard
ownermethod is called to find the resolver contract of a ens name.
This allows users to set the pubkey even for ens names that are not
subdomains of stateofus
TODOS
update 14/10/19: only thing left that seems buggy from my POV is when adding a username, the details show pending transaction until relogin. willfix