Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix status bar colors and launch screen #9292

Merged
merged 1 commit into from
Nov 6, 2019
Merged

fix status bar colors and launch screen #9292

merged 1 commit into from
Nov 6, 2019

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Oct 26, 2019 •
edited by StatusWrike
Loading

galaxy s10

before after
image image

@flexsurfer flexsurfer requested a review from a team as a code owner October 26, 2019 11:37
@flexsurfer flexsurfer self-assigned this Oct 26, 2019
@auto-assign auto-assign bot removed the request for review from a team October 26, 2019 11:37
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Oct 26, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 650ba15 #1 2019-10-26 11:47:14 ~9 min ios 📦ipa 📲
✔️ 650ba15 #1 2019-10-26 11:50:39 ~13 min android-e2e 📦apk 📲
✔️ 650ba15 #1 2019-10-26 11:50:44 ~13 min macos 📦dmg
✔️ 650ba15 #1 2019-10-26 11:51:44 ~14 min android 📦apk 📲
✔️ 650ba15 #1 2019-10-26 11:51:53 ~14 min linux 📦App
✔️ 650ba15 #1 2019-10-26 11:52:21 ~14 min windows 📦exe
✔️ 21c4af2 #2 2019-11-05 12:31:55 ~9 min ios 📦ipa 📲
✔️ 21c4af2 #2 2019-11-05 12:35:25 ~12 min android-e2e 📦apk 📲
✔️ 21c4af2 #2 2019-11-05 12:36:44 ~13 min android 📦apk 📲
✔️ 21c4af2 #2 2019-11-05 12:36:46 ~13 min linux 📦App
✔️ 21c4af2 #2 2019-11-05 12:37:03 ~14 min macos 📦dmg
✔️ 21c4af2 #2 2019-11-05 12:38:14 ~15 min windows 📦exe

@statustestbot
Copy link

95% of end-end tests have passed

Total executed tests: 100
Failed tests: 5
Passed tests: 95

Failed tests (5)

Click to expand
1. test_modify_transaction_fee_values

Device 1: Tap on SignButton
Device 1: Looking for an element by text: 'intrinsic gas too low'

Device 1: 'BaseText' is not found on the screen; also Unexpected Alert is shown: 'request failed or timed out'

Device sessions

2. test_block_user_from_one_to_one_header

Device 1: Tap on PlusButton
Device 1: Wait for JoinPublicChatButton

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

3. test_logcat_backup_recovery_phrase

Device 1: Tap on DoneButton
Device 1: Tap on YesButton

Device 1: ['Passphrase1 in logcat!!!', 'Passphrase2 in logcat!!!']

Device sessions

4. test_insufficient_funds_wallet_positive_balance

Device 1: Scrolling down to STTAssetText
Device 1: Scrolling down to STTAssetText

Device 1: 'STTAssetText' is not found on the screen

Device sessions

5. test_offline_status

Device 1: Wait for ChatMessageInput
Device 1: ConnectionStatusText is Offline

'Before block from 2' from blocked user 2 are shown in public chat 'After block from 2' from blocked user 2 are shown in public chat

Device sessions

Passed tests (95)

Click to expand
1. test_user_can_switch_network
Device sessions

2. test_block_user_from_public_chat
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

7. test_connection_is_secure
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_redirect_to_public_chat_tapping_tag_message
Device sessions

10. test_remove_member_from_group_chat
Device sessions

11. test_delete_one_to_one_chat_via_delete_button
Device sessions

12. test_mobile_data_usage_popup_continue_syncing
Device sessions

13. test_clear_history_of_group_chat_via_group_view
Device sessions

14. test_decline_invitation_to_group_chat
Device sessions

15. test_open_transaction_on_etherscan
Device sessions

16. test_pass_phrase_validation
Device sessions

17. test_open_blocked_site
Device sessions

18. test_public_chat_messaging
Device sessions

19. test_open_chat_by_pasting_public_key
Device sessions

20. test_add_custom_token
Device sessions

21. test_long_press_to_delete_1_1_chat
Device sessions

22. test_password_in_logcat_sign_in
Device sessions

23. test_set_profile_picture
Device sessions

24. test_text_message_1_1_chat
Device sessions

25. test_add_to_contacts
Device sessions

26. test_sign_typed_message
Device sessions

27. test_home_view
Device sessions

28. test_send_and_open_links
Device sessions

29. test_unread_messages_counter_1_1_chat
Device sessions

30. test_can_use_purchased_stickers_on_recovered_account
Device sessions

31. test_logcat_send_transaction_from_daap
Device sessions

32. test_copy_contact_code_and_wallet_address
Device sessions

33. test_collectible_from_wallet_opens_in_browser_view
Device sessions

34. test_send_message_in_group_chat
Device sessions

35. test_always_allow_web3_permissions
Device sessions

36. test_can_open_dapp_from_dapp_store
Device sessions

37. test_ens_username_recipient
Device sessions

38. test_logcat_send_transaction_from_wallet
Device sessions

39. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

40. test_send_token_with_7_decimals
Device sessions

41. test_offline_messaging_1_1_chat
Device sessions

42. test_fetch_more_history_in_empty_chat
Device sessions

43. test_delete_group_chat_via_delete_button
Device sessions

44. test_token_with_more_than_allowed_decimals
Device sessions

45. test_send_eth_from_wallet_to_address
Device sessions

46. test_contact_profile_view
Device sessions

47. test_add_account_to_multiaccount_instance
Device sessions

48. test_send_funds_between_accounts_in_multiaccount_instance
Device sessions

49. test_request_eth_in_status_test_dapp
Device sessions

50. test_manage_assets
Device sessions

51. test_create_new_group_chat
Device sessions

52. test_wallet_set_up
Device sessions

53. test_long_press_to_delete_public_chat
Device sessions

54. test_send_emoji
Device sessions

55. test_search_chat_on_home
Device sessions

56. test_logcat_recovering_account
Device sessions

57. test_mobile_data_usage_popup_stop_syncing
Device sessions

58. test_can_add_existing_ens
Device sessions

59. test_transaction_wrong_password_wallet
Device sessions

60. test_pair_devices_sync_name_photo_public_group_chats
Device sessions

61. test_install_pack_and_send_sticker
Device sessions

62. test_pair_devices_sync_one_to_one_contacts
Device sessions

63. test_delete_public_chat_via_delete_button
Device sessions

64. test_messaging_in_different_networks
Device sessions

65. test_add_new_group_chat_member
Device sessions

66. test_logcat_sign_message_from_daap
Device sessions

67. test_switch_users_and_add_new_account
Device sessions

68. test_mobile_data_usage_settings
Device sessions

69. test_make_admin_member_of_group_chat
Device sessions

70. test_long_press_delete_clear_all_dapps
Device sessions

71. test_send_stt_from_wallet
Device sessions

72. test_login_with_new_account
Device sessions

73. test_request_public_key_status_test_daap
Device sessions

74. test_start_chat_with_ens
Device sessions

75. test_add_contact_from_public_chat
Device sessions

76. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

77. test_send_two_transactions_one_after_another_in_dapp
Device sessions

78. test_send_message_to_newly_added_contact
Device sessions

79. test_password_in_logcat_creating_account
Device sessions

80. test_dapps_permissions
Device sessions

81. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

82. test_backup_recovery_phrase
Device sessions

83. test_public_chat_clear_history
Device sessions

84. test_open_google_com_via_open_dapp
Device sessions

85. test_unread_messages_counter_public_chat
Device sessions

86. test_sign_message_from_daap
Device sessions

87. test_user_can_remove_profile_picture
Device sessions

88. test_send_two_transactions_in_batch_in_dapp
Device sessions

89. test_share_contact_code_and_wallet_address
Device sessions

90. test_message_marked_as_sent_in_1_1_chat
Device sessions

91. test_need_help_section
Device sessions

92. test_refresh_button_browsing_app_webview
Device sessions

93. test_log_level_and_fleet
Device sessions

94. test_group_chat_system_messages
Device sessions

95. test_open_public_chat_using_deep_link
Device sessions

@churik
Copy link
Member

churik commented Oct 28, 2019

Failures:

  1. test_modify_transaction_fee_values - not related to your PR
    Device 1: 'BaseText' is not found on the screen; also Unexpected Alert is shown: 'request failed or timed out' - not related to PR, probably broken in develop by other PR or temporary fail due to Ropsten response, will take a look today.

  2. test_block_user_from_one_to_one_header - known failure, will be fixed after merging Test sent transaction appears in history #9279

  3. test_logcat_backup_recovery_phrase - known possible failure, when 2 words from passphrase are found in logcat

  4. test_insufficient_funds_wallet_positive_balance - failure due to Assets (tokens) are not loaded due to infura error #9280

  5. test_offline_status - seems to be false failure, will take a look

@yenda
Copy link
Contributor

yenda commented Nov 1, 2019

@churik can we merge this?

@Serhy Serhy self-assigned this Nov 1, 2019
@Serhy
Copy link
Contributor

Serhy commented Nov 1, 2019

No, there are some regressions appeared.

While it seem OK with iOS (iOS 12.4 tested on iPhoneX) on Androids along with the changing colour values it affected some elements

  1. On any Android (6.0.1, 8.1, 9.0 tested) below elements are white now:
    a) cursor in the any of input fields (should be kept blue one)
    b) spinners when sign in transaction or when login in (navigation from password -> Chats view)

Screenshot 2019-11-01 at 16 51 58

c) blue drop-icon when selecting text in input fields
d) selected text shadowing
Screenshot 2019-11-01 at 16 52 16

  1. On Android 6.0.1 only. Text in the actionable buttons in pop-up (Log Out, change network and similar pop-ups) are white and so not visible:

Screenshot 2019-11-01 at 16 52 08

@flexsurfer
Copy link
Member Author

thanks @Serhy , fixed

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 100
Failed tests: 0
Passed tests: 100

Passed tests (100)

Click to expand
1. test_user_can_switch_network
Device sessions

2. test_block_user_from_public_chat
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

7. test_connection_is_secure
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_redirect_to_public_chat_tapping_tag_message
Device sessions

10. test_remove_member_from_group_chat
Device sessions

11. test_delete_one_to_one_chat_via_delete_button
Device sessions

12. test_mobile_data_usage_popup_continue_syncing
Device sessions

13. test_clear_history_of_group_chat_via_group_view
Device sessions

14. test_decline_invitation_to_group_chat
Device sessions

15. test_open_transaction_on_etherscan
Device sessions

16. test_pass_phrase_validation
Device sessions

17. test_open_blocked_site
Device sessions

18. test_public_chat_messaging
Device sessions

19. test_open_chat_by_pasting_public_key
Device sessions

20. test_add_custom_token
Device sessions

21. test_long_press_to_delete_1_1_chat
Device sessions

22. test_password_in_logcat_sign_in
Device sessions

23. test_set_profile_picture
Device sessions

24. test_text_message_1_1_chat
Device sessions

25. test_add_to_contacts
Device sessions

26. test_sign_typed_message
Device sessions

27. test_home_view
Device sessions

28. test_send_and_open_links
Device sessions

29. test_unread_messages_counter_1_1_chat
Device sessions

30. test_can_use_purchased_stickers_on_recovered_account
Device sessions

31. test_logcat_send_transaction_from_daap
Device sessions

32. test_copy_contact_code_and_wallet_address
Device sessions

33. test_collectible_from_wallet_opens_in_browser_view
Device sessions

34. test_send_message_in_group_chat
Device sessions

35. test_always_allow_web3_permissions
Device sessions

36. test_can_open_dapp_from_dapp_store
Device sessions

37. test_recover_account_from_new_user_seedphrase
Device sessions

38. test_ens_username_recipient
Device sessions

39. test_logcat_send_transaction_from_wallet
Device sessions

40. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

41. test_send_token_with_7_decimals
Device sessions

42. test_offline_messaging_1_1_chat
Device sessions

43. test_fetch_more_history_in_empty_chat
Device sessions

44. test_modify_transaction_fee_values
Device sessions

45. test_delete_group_chat_via_delete_button
Device sessions

46. test_token_with_more_than_allowed_decimals
Device sessions

47. test_send_eth_from_wallet_to_address
Device sessions

48. test_contact_profile_view
Device sessions

49. test_add_account_to_multiaccount_instance
Device sessions

50. test_send_funds_between_accounts_in_multiaccount_instance
Device sessions

51. test_request_eth_in_status_test_dapp
Device sessions

52. test_manage_assets
Device sessions

53. test_create_new_group_chat
Device sessions

54. test_wallet_set_up
Device sessions

55. test_long_press_to_delete_public_chat
Device sessions

56. test_send_emoji
Device sessions

57. test_search_chat_on_home
Device sessions

58. test_block_user_from_one_to_one_header
Device sessions

59. test_logcat_recovering_account
Device sessions

60. test_mobile_data_usage_popup_stop_syncing
Device sessions

61. test_can_add_existing_ens
Device sessions

62. test_transaction_wrong_password_wallet
Device sessions

63. test_pair_devices_sync_name_photo_public_group_chats
Device sessions

64. test_install_pack_and_send_sticker
Device sessions

65. test_pair_devices_sync_one_to_one_contacts
Device sessions

66. test_delete_public_chat_via_delete_button
Device sessions

67. test_messaging_in_different_networks
Device sessions

68. test_logcat_backup_recovery_phrase
Device sessions

69. test_add_new_group_chat_member
Device sessions

70. test_logcat_sign_message_from_daap
Device sessions

71. test_switch_users_and_add_new_account
Device sessions

72. test_mobile_data_usage_settings
Device sessions

73. test_make_admin_member_of_group_chat
Device sessions

74. test_long_press_delete_clear_all_dapps
Device sessions

75. test_send_stt_from_wallet
Device sessions

76. test_login_with_new_account
Device sessions

77. test_insufficient_funds_wallet_positive_balance
Device sessions

78. test_request_public_key_status_test_daap
Device sessions

79. test_start_chat_with_ens
Device sessions

80. test_add_contact_from_public_chat
Device sessions

81. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

82. test_send_two_transactions_one_after_another_in_dapp
Device sessions

83. test_send_message_to_newly_added_contact
Device sessions

84. test_password_in_logcat_creating_account
Device sessions

85. test_dapps_permissions
Device sessions

86. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

87. test_public_chat_clear_history
Device sessions

88. test_offline_status
Device sessions

89. test_open_google_com_via_open_dapp
Device sessions

90. test_unread_messages_counter_public_chat
Device sessions

91. test_sign_message_from_daap
Device sessions

92. test_user_can_remove_profile_picture
Device sessions

93. test_send_two_transactions_in_batch_in_dapp
Device sessions

94. test_share_contact_code_and_wallet_address
Device sessions

95. test_message_marked_as_sent_in_1_1_chat
Device sessions

96. test_need_help_section
Device sessions

97. test_refresh_button_browsing_app_webview
Device sessions

98. test_log_level_and_fleet
Device sessions

99. test_group_chat_system_messages
Device sessions

100. test_open_public_chat_using_deep_link
Device sessions

@yenda
Copy link
Contributor

yenda commented Nov 6, 2019

Tested on OP7P lgtm, issues are gone

@Serhy
Copy link
Contributor

Serhy commented Nov 6, 2019

No issues with Android 8.1, Android 6.0.1, iOS12 which was before.

@flexsurfer
fix colors and launch screen
ac60ef6 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit ac60ef6 into develop Nov 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/fix-status-bar branch November 6, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@yenda yenda yenda approved these changes

@vitvly vitvly Awaiting requested review from vitvly

Assignees
No one assigned
Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@flexsurfer @status-im-auto @statustestbot @churik @yenda @Serhy @rasom