Remove firebase #9308

yenda · 2019-10-28T17:31:26Z

fix #9179
fix #9136 (no notification no problem)
fix #8742 (firebase removed)
fix #8555 notifications removed
fix #8554 no more notifications
fix #8550 fix #8217 fix #8216
fix #7438 ios doesn't deserve notifications anyway

Remove Firebase, Google Services and all the Google ads crap from the project.
Remove fcm-token and device infos
Remove push-notifications

Test protocol

install app on different devices (iPhone 6 plus, OP7pro)
create account, recover account, pair devices
receive 1-1 messages that would normally trigger notifications

What could go wrong:

UI element related to notifications still present (currently removed: enable notification screen and profile notification setting item)
leftover notification code could crash the app

dependency-lockfile-snitch · 2019-10-28T17:31:30Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

status-github-bot · 2019-10-28T17:31:32Z

Pull Request Checklist

Docs: Updated the documentation, if affected
Docs: Added or updated inline comments explaining intention of the code
Tests: Ensured that all new UI elements have been assigned accessibility IDs
Tests: Signaled need for E2E tests with label, if applicable
Tests: Briefly described what was tested and what platforms were used
UI: In case of UI changes, ensured that UI matches Figma
UI: In case of UI changes, requested review from a Core UI designer
UI: In case of UI changes, included screenshots of implementation

status-im-auto · 2019-10-28T17:34:10Z

Jenkins Builds

Click to see older builds (63)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`e486506`	#1	2019-10-28 17:34:09	~2 min	`windows`	📄`log`
❌	`e486506`	#1	2019-10-28 17:34:26	~2 min	`macos`	📄`log`
❌	`e486506`	#1	2019-10-28 17:34:37	~2 min	`linux`	📄`log`
❌	`e486506`	#1	2019-10-28 17:36:14	~4 min	`android`	📄`log`
❌	`e486506`	#1	2019-10-28 17:37:30	~5 min	`ios`	📄`log`
❌	`e486506`	#1	2019-10-28 17:53:13	~21 min	`android-e2e`	📄`log`

❌	`06695eb`	#2	2019-10-28 19:05:09	~3 min	`android`	📄`log`
❌	`06695eb`	#2	2019-10-28 19:05:15	~3 min	`ios`	📄`log`
❌	`06695eb`	#2	2019-10-28 19:05:19	~3 min	`android-e2e`	📄`log`
❌	`06695eb`	#2	2019-10-28 19:05:22	~3 min	`windows`	📄`log`
❌	`06695eb`	#2	2019-10-28 19:05:25	~3 min	`macos`	📄`log`
❌	`06695eb`	#2	2019-10-28 19:05:39	~3 min	`linux`	📄`log`

❌	`db1063c`	#3	2019-10-28 19:17:02	~3 min	`windows`	📄`log`
❌	`db1063c`	#3	2019-10-28 19:17:02	~3 min	`macos`	📄`log`
❌	`db1063c`	#3	2019-10-28 19:17:06	~3 min	`ios`	📄`log`
❌	`db1063c`	#3	2019-10-28 19:17:22	~3 min	`linux`	📄`log`
❌	`db1063c`	#3	2019-10-28 19:17:31	~3 min	`android`	📄`log`
❌	`db1063c`	#3	2019-10-28 19:17:39	~3 min	`android-e2e`	📄`log`

❌	`1d3bb54`	#4	2019-10-28 20:41:12	~5 min	`ios`	📄`log`
✔️	`1d3bb54`	#4	2019-10-28 20:47:04	~11 min	`android`	📦`apk` 📲
✔️	`1d3bb54`	#4	2019-10-28 20:48:29	~12 min	`macos`	📦`dmg`
✔️	`1d3bb54`	#4	2019-10-28 20:48:39	~12 min	`android-e2e`	📦`apk` 📲
✔️	`1d3bb54`	#4	2019-10-28 20:50:43	~14 min	`linux`	📦`App`
✔️	`1d3bb54`	#4	2019-10-28 20:50:56	~15 min	`windows`	📦`exe`

❌	`5b9a6cc`	#5	2019-10-28 21:06:46	~6 min	`ios`	📄`log`
✔️	`5b9a6cc`	#5	2019-10-28 21:11:16	~10 min	`android`	📦`apk` 📲
✔️	`5b9a6cc`	#5	2019-10-28 21:14:01	~13 min	`macos`	📦`dmg`

❌	`66253b2`	#6	2019-10-28 21:18:38	~5 min	`ios`	📄`log`
✔️	`66253b2`	#6	2019-10-28 21:23:21	~10 min	`android`	📦`apk` 📲
✔️	`66253b2`	#6	2019-10-28 21:24:55	~11 min	`android-e2e`	📦`apk` 📲
✔️	`66253b2`	#6	2019-10-28 21:26:26	~13 min	`macos`	📦`dmg`
✔️	`66253b2`	#6	2019-10-28 21:27:54	~14 min	`linux`	📦`App`
✔️	`66253b2`	#6	2019-10-28 21:28:13	~15 min	`windows`	📦`exe`

❌	`11450cf`	#8	2019-10-29 08:47:45	~6 min	`ios`	📄`log`
✔️	`11450cf`	#8	2019-10-29 08:52:00	~10 min	`android-e2e`	📦`apk` 📲
✔️	`11450cf`	#8	2019-10-29 08:54:39	~13 min	`macos`	📦`dmg`
✔️	`11450cf`	#8	2019-10-29 08:55:36	~14 min	`android`	📦`apk` 📲
✔️	`11450cf`	#8	2019-10-29 08:57:20	~16 min	`linux`	📦`App`
✔️	`11450cf`	#8	2019-10-29 08:58:36	~17 min	`windows`	📦`exe`

✔️	`4901f7b`	#9	2019-10-29 09:48:07	~8 min	`ios`	📦`ipa` 📲
✔️	`4901f7b`	#9	2019-10-29 09:50:48	~10 min	`android-e2e`	📦`apk` 📲
✔️	`4901f7b`	#9	2019-10-29 09:52:02	~12 min	`macos`	📦`dmg`
✔️	`4901f7b`	#9	2019-10-29 09:53:31	~13 min	`linux`	📦`App`
✔️	`4901f7b`	#9	2019-10-29 09:54:58	~15 min	`android`	📦`apk` 📲
✔️	`4901f7b`	#9	2019-10-29 09:56:24	~16 min	`windows`	📦`exe`

✔️	`fbc18ca`	#10	2019-10-29 11:07:36	~8 min	`ios`	📦`ipa` 📲
✔️	`fbc18ca`	#10	2019-10-29 11:10:08	~10 min	`android-e2e`	📦`apk` 📲
✔️	`fbc18ca`	#10	2019-10-29 11:12:21	~12 min	`macos`	📦`dmg`
✔️	`fbc18ca`	#10	2019-10-29 11:13:12	~13 min	`android`	📦`apk` 📲
✔️	`fbc18ca`	#10	2019-10-29 11:13:24	~13 min	`linux`	📦`App`
✔️	`fbc18ca`	#10	2019-10-29 11:14:15	~14 min	`windows`	📦`exe`

✔️	`374ffc7`	#11	2019-10-29 11:28:27	~7 min	`ios`	📦`ipa` 📲
✔️	`374ffc7`	#11	2019-10-29 11:31:06	~10 min	`android-e2e`	📦`apk` 📲
✔️	`374ffc7`	#11	2019-10-29 11:32:14	~11 min	`macos`	📦`dmg`
✔️	`374ffc7`	#11	2019-10-29 11:33:43	~13 min	`android`	📦`apk` 📲
✔️	`374ffc7`	#11	2019-10-29 11:34:11	~13 min	`linux`	📦`App`
✔️	`374ffc7`	#11	2019-10-29 11:35:03	~14 min	`windows`	📦`exe`

✔️	`76ebba3`	#12	2019-10-29 13:32:24	~9 min	`ios`	📦`ipa` 📲
✔️	`76ebba3`	#12	2019-10-29 13:35:17	~12 min	`android-e2e`	📦`apk` 📲
✔️	`76ebba3`	#12	2019-10-29 13:35:49	~12 min	`macos`	📦`dmg`
✔️	`76ebba3`	#12	2019-10-29 13:36:40	~13 min	`windows`	📦`exe`
✔️	`76ebba3`	#12	2019-10-29 13:36:46	~13 min	`android`	📦`apk` 📲
✔️	`76ebba3`	#12	2019-10-29 13:37:42	~14 min	`linux`	📦`App`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`1940ac5`	#14	2019-10-29 14:16:19	~12 min	`linux`	📦`App`
✔️	`1940ac5`	#14	2019-10-29 14:16:28	~12 min	`ios`	📦`ipa` 📲
✔️	`1940ac5`	#14	2019-10-29 14:17:10	~13 min	`macos`	📦`dmg`
✔️	`1940ac5`	#14	2019-10-29 14:18:59	~15 min	`android`	📦`apk` 📲
✔️	`1940ac5`	#14	2019-10-29 14:20:43	~16 min	`windows`	📦`exe`

✔️	`7bb45fd`	#15	2019-10-29 14:17:13	~12 min	`android-e2e`	📦`apk` 📲

yenda · 2019-10-29T08:35:49Z

src/status_im/pairing/core.cljs

        installation-name (get-in cofx [:db :pairing/installations installation-id :name])
        device-type     utils.platform/os]
-    (protocol/send (transport.pairing/PairInstallation. installation-id device-type installation-name fcm-token) nil cofx)))


@cammellos what needs to be done on go side to remove fcm tokens and device infos? I think there is also some firebase stuff on go side?

dependency-lockfile-snitch · 2019-10-29T10:03:19Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

yenda · 2019-10-29T10:04:01Z

@Serhy @churik can you check the issues I marked as resolved and tell me if you agree to close them with this PR? I will test the app myself today, you can also do additional testing if you want.

churik · 2019-10-29T10:52:08Z

@yenda ofc.
let's start from e2e then

yenda · 2019-10-29T10:54:05Z

@churik I tested all the steps described in the summary on both devices.

cammellos · 2019-10-29T10:55:47Z

src/status_im/contact/core.cljs

@@ -4,7 +4,7 @@
   [status-im.multiaccounts.model :as multiaccounts.model]
   [status-im.transport.filters.core :as transport.filters]
   [status-im.contact.db :as contact.db]
-   [status-im.contact.device-info :as device-info]
+


extra line?

I naively though that cljfmt would remove them

cammellos · 2019-10-29T10:57:01Z

src/status_im/pairing/core.cljs

@@ -4,7 +4,7 @@
            [status-im.chat.models :as models.chat]
            [status-im.contact.core :as contact]
            [status-im.contact.db :as contact.db]
-            [status-im.contact.device-info :as device-info]
+


extra line?

dependency-lockfile-snitch · 2019-10-29T10:59:16Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

statustestbot · 2019-10-29T11:06:22Z

27% of end-end tests have passed

Total executed tests: 49
Failed tests: 36
Passed tests: 13

Failed tests (36)

Click to expand

1. test_block_user_from_public_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_filters_from_daap
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_copy_and_paste_messages
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
4. test_send_transaction_from_daap
Device 1: Tap on SignButton Device 1: Wait for OkButton `Device 1: 'OkButton' is not found on the screen; also Unexpected Alert is shown: 'Consider it complete after 12 confirmations on the network.'` Device sessions Device 1: Steps, video, logs Failure screenshot
5. test_public_chat_messaging
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot
6. test_long_press_to_delete_1_1_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
7. test_password_in_logcat_sign_in
Device 1: Type 'unique1029105340' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
8. test_text_message_1_1_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_add_to_contacts
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
10. test_unread_messages_counter_1_1_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
11. test_send_message_in_group_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot
12. test_can_open_dapp_from_dapp_store
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
13. test_ens_username_recipient
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
14. test_offline_messaging_1_1_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 2: Steps, video, logs Failure screenshot Device 1: Steps, video, logs Failure screenshot
15. test_add_account_to_multiaccount_instance
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
16. test_manage_assets
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
17. test_long_press_to_delete_public_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
18. test_send_emoji
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
19. test_search_chat_on_home
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
20. test_install_pack_and_send_sticker
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
21. test_messaging_in_different_networks
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
22. test_logcat_backup_recovery_phrase
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
23. test_logcat_sign_message_from_daap
Device 1: Type 'unique1029105342' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
24. test_switch_users_and_add_new_account
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
25. test_login_with_new_account
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
26. test_start_chat_with_ens
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
27. test_add_contact_from_public_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
28. test_password_in_logcat_creating_account
Device 1: Type 'unique1029105337' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
29. test_backup_recovery_phrase
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
30. test_offline_status
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
31. test_open_google_com_via_open_dapp
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
32. test_unread_messages_counter_public_chat
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
33. test_sign_message_from_daap
Device 1: Type 'password_for_daap' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
34. test_user_can_remove_profile_picture
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
35. test_share_contact_code_and_wallet_address
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot
36. test_refresh_button_browsing_app_webview
Device 1: Type 'qwerty' to ConfirmYourPasswordInput Device 1: Tap on NextButton `Device 1: 'MaybeLaterButton' is not found on the screen` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (13)

Click to expand

1. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
2. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
3. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
4. test_can_use_purchased_stickers_on_recovered_account
Device sessions Device 1: Steps, video, logs
5. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
6. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
7. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
8. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
9. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
10. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
11. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
12. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
13. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs

dependency-lockfile-snitch · 2019-10-29T11:20:21Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

statustestbot · 2019-10-29T11:40:09Z

100% of end-end tests have passed

Total executed tests: 49
Failed tests: 0
Passed tests: 49

Passed tests (49)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
5. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
6. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
7. test_public_chat_messaging
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
9. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
10. test_text_message_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_add_to_contacts
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
13. test_unread_messages_counter_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
14. test_can_use_purchased_stickers_on_recovered_account
Device sessions Device 1: Steps, video, logs
15. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
16. test_send_message_in_group_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_can_open_dapp_from_dapp_store
Device sessions Device 1: Steps, video, logs
18. test_ens_username_recipient
Device sessions Device 1: Steps, video, logs
19. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
20. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
21. test_offline_messaging_1_1_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
23. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
24. test_add_account_to_multiaccount_instance
Device sessions Device 1: Steps, video, logs
25. test_manage_assets
Device sessions Device 1: Steps, video, logs
26. test_long_press_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
27. test_send_emoji
Device sessions Device 1: Steps, video, logs
28. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
29. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
30. test_can_add_existing_ens
Device sessions Device 1: Steps, video, logs
31. test_install_pack_and_send_sticker
Device sessions Device 1: Steps, video, logs
32. test_messaging_in_different_networks
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
33. test_logcat_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
34. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
35. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
36. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
37. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
38. test_start_chat_with_ens
Device sessions Device 1: Steps, video, logs
39. test_add_contact_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
40. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
41. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
42. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
43. test_offline_status
Device sessions Device 1: Steps, video, logs
44. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
45. test_unread_messages_counter_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
46. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
47. test_user_can_remove_profile_picture
Device sessions Device 1: Steps, video, logs
48. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
49. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs

yenda · 2019-10-29T13:05:49Z

@churik do you want to run some additional manual tests before this is merged?

churik · 2019-10-29T13:08:47Z

Tested on IOS 13.0 and Android 8.0:

no PNs - no issues mentioned in description;

Additionally checked:

save password
reopening app
fetching messages from offline
adding / removing from contacts
creating account with keycard.

Ready to go from my side.
Thx for your work @yenda!
cc @rachelhamlin - no more PNs for now.

dependency-lockfile-snitch · 2019-10-29T13:22:59Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

rachelhamlin · 2019-10-29T13:23:10Z

What happens if we decide to revive (suboptimal, centralized) PNs down the line at the request of iOS users? Is it prudent to remove Firebase entirely right now @yenda @pombeirp?

yenda · 2019-10-29T13:48:37Z

@rachelhamlin we can then in the worst case simply revert the commit. But reintroducing Firebase would be a bad decision.

dependency-lockfile-snitch · 2019-10-29T14:02:49Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

dependency-lockfile-snitch · 2019-10-29T14:03:34Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

Signed-off-by: yenda <eric@status.im>

dependency-lockfile-snitch · 2019-10-29T14:04:16Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

dependency-lockfile-snitch · 2020-04-29T20:09:32Z

mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

yenda requested review from jakubgs, pedropombeiro, vkjr and a team as code owners October 28, 2019 17:31

auto-assign bot removed the request for review from a team October 28, 2019 17:31

yenda requested review from cammellos and rasom October 28, 2019 21:14

yenda self-assigned this Oct 28, 2019

yenda commented Oct 29, 2019

View reviewed changes

status-im deleted a comment from dependency-lockfile-snitch bot Oct 29, 2019

cammellos approved these changes Oct 29, 2019

View reviewed changes

yenda requested review from antdanchenko and churik as code owners October 29, 2019 11:20

churik added the Tested - OK label Oct 29, 2019

yenda force-pushed the remove-firebase branch from 76ebba3 to 1edd3de Compare October 29, 2019 14:02

yenda force-pushed the remove-firebase branch from 1edd3de to 1940ac5 Compare October 29, 2019 14:03

remove firebase

7bb45fd

Signed-off-by: yenda <eric@status.im>

yenda force-pushed the remove-firebase branch from 1940ac5 to 7bb45fd Compare October 29, 2019 14:04

yenda merged commit 7bb45fd into develop Oct 29, 2019

delete-merged-branch bot deleted the remove-firebase branch October 29, 2019 14:04

jakubgs mentioned this pull request Oct 29, 2019

Research process of publishing to F-Droid #8512

Closed

StatusWrike unassigned yenda Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove firebase #9308

Remove firebase #9308

yenda commented Oct 28, 2019 •

edited by StatusWrike

Loading

dependency-lockfile-snitch bot commented Oct 28, 2019

status-github-bot bot commented Oct 28, 2019

status-im-auto commented Oct 28, 2019 •

edited

Loading

yenda Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

yenda commented Oct 29, 2019

churik commented Oct 29, 2019

yenda commented Oct 29, 2019

cammellos Oct 29, 2019

yenda Oct 29, 2019

cammellos Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

statustestbot commented Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

statustestbot commented Oct 29, 2019

yenda commented Oct 29, 2019

churik commented Oct 29, 2019 •

edited

Loading

dependency-lockfile-snitch bot commented Oct 29, 2019

rachelhamlin commented Oct 29, 2019

yenda commented Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

dependency-lockfile-snitch bot commented Apr 29, 2020

Remove firebase #9308

Remove firebase #9308

Conversation

yenda commented Oct 28, 2019 • edited by StatusWrike Loading

Test protocol

dependency-lockfile-snitch bot commented Oct 28, 2019

status-github-bot bot commented Oct 28, 2019

Pull Request Checklist

status-im-auto commented Oct 28, 2019 • edited Loading

Jenkins Builds

yenda Oct 29, 2019

Choose a reason for hiding this comment

dependency-lockfile-snitch bot commented Oct 29, 2019

yenda commented Oct 29, 2019

churik commented Oct 29, 2019

yenda commented Oct 29, 2019

cammellos Oct 29, 2019

Choose a reason for hiding this comment

yenda Oct 29, 2019

Choose a reason for hiding this comment

cammellos Oct 29, 2019

Choose a reason for hiding this comment

dependency-lockfile-snitch bot commented Oct 29, 2019

statustestbot commented Oct 29, 2019

27% of end-end tests have passed

Failed tests (36)

Passed tests (13)

dependency-lockfile-snitch bot commented Oct 29, 2019

statustestbot commented Oct 29, 2019

100% of end-end tests have passed

Passed tests (49)

yenda commented Oct 29, 2019

churik commented Oct 29, 2019 • edited Loading

dependency-lockfile-snitch bot commented Oct 29, 2019

rachelhamlin commented Oct 29, 2019

yenda commented Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

dependency-lockfile-snitch bot commented Oct 29, 2019

dependency-lockfile-snitch bot commented Apr 29, 2020

yenda commented Oct 28, 2019 •

edited by StatusWrike

Loading

status-im-auto commented Oct 28, 2019 •

edited

Loading

churik commented Oct 29, 2019 •

edited

Loading