-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9061] fix fetching balances for keycard acc #9338
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (28)
|
de786b6
to
8991bf9
Compare
@@ -128,6 +129,16 @@ | |||
current-network | |||
(types/deserialize networks)]) | |||
|
|||
(defn convert-multiaccounts-addresses | |||
[multiaccount] | |||
(-> multiaccount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking: maybe it's nicer to let-bind update-fn:
(let [update-fn #(update % :address eip55/address->checksum)]
(-> multiaccount
update-fn
(update :accounts #(mapv update-fn %))))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
15ea5f5
to
c684464
Compare
c684464
to
19ce494
Compare
98% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (98)Click to expand
|
98% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (98)Click to expand
|
Tested with Android 8.1 and Android 9. Account with keycard updates fiat currency on multiaccount as well as on 'status account' wallet view. |
100% of end-end tests have passed
Passed tests (1)Click to expand
|
19ce494
to
02ce078
Compare
fix #9061
status: ready