Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9061] Fix balances fetching of a new keycard account #9558

Merged
merged 1 commit into from
Nov 30, 2019
Merged

[#9061] Fix balances fetching of a new keycard account #9558

merged 1 commit into from
Nov 30, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Nov 30, 2019 •
edited by StatusWrike
Loading

fix #9061 again

This issue wasn't properly fixed for a newly created account, balance
was properly fetched only after re-login.

As @yenda mentioned in discord a few weeks ago, we need to normalise addresses on account creation.

@rasom
[#9061] Fix balances fetching of a new keycard account
5a408f1 
This issue wasn't properly fixed for a newly created account, balance
was properly fetched only after re-login.
@rasom rasom requested a review from a team as a code owner November 30, 2019 17:11
@auto-assign auto-assign bot removed the request for review from a team November 30, 2019 17:11
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@rasom rasom added the keycard label Nov 30, 2019
@rasom rasom self-assigned this Nov 30, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Nov 30, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5a408f1 #1 2019-11-30 17:21:09 ~9 min ios 📦ipa 📲
✔️ 5a408f1 #1 2019-11-30 17:27:47 ~16 min android-e2e 📦apk 📲
✔️ 5a408f1 #1 2019-11-30 17:27:54 ~16 min android 📦apk 📲

@rasom rasom merged commit 5a408f1 into develop Nov 30, 2019
@rasom rasom deleted the fix/fetch-keycard-acc-balance-on-creation#9061 branch December 2, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@vitvly vitvly Awaiting requested review from vitvly

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account balance is not fetched when multiaccount is created with keycard
3 participants
@rasom @status-im-auto @flexsurfer