Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9636] Remove chat menu item and toggle app switching privacy on by … #9638

Merged
merged 1 commit into from
Dec 13, 2019
Merged

[#9636] Remove chat menu item and toggle app switching privacy on by … #9638

merged 1 commit into from
Dec 13, 2019

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Dec 11, 2019 •
edited by StatusWrike
Loading

fixes #9636

@flexsurfer flexsurfer requested a review from a team as a code owner December 11, 2019 10:01
@auto-assign auto-assign bot removed the request for review from a team December 11, 2019 10:01
@flexsurfer flexsurfer self-assigned this Dec 11, 2019
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Dec 11, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c3ee6bb #1 2019-12-11 10:10:44 ~8 min ios 📦ipa 📲
✔️ c3ee6bb #1 2019-12-11 10:20:52 ~19 min android-e2e 📦apk 📲
✔️ c3ee6bb #1 2019-12-11 10:21:05 ~19 min android 📦apk 📲
✔️ 0a50601 #2 2019-12-11 15:05:39 ~8 min ios 📦ipa 📲
✔️ 0a50601 #2 2019-12-11 15:13:30 ~16 min android-e2e 📦apk 📲
✔️ 0a50601 #2 2019-12-11 15:14:51 ~17 min android 📦apk 📲
✔️ 083b5e9 #3 2019-12-12 13:06:45 ~8 min ios 📦ipa 📲
✔️ 083b5e9 #3 2019-12-12 13:18:51 ~20 min android-e2e 📦apk 📲
✔️ 083b5e9 #3 2019-12-12 13:19:00 ~20 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 80ecd04 #4 2019-12-12 13:37:49 ~11 min ios 📦ipa 📲
✔️ 80ecd04 #4 2019-12-12 13:50:53 ~24 min android 📦apk 📲
✔️ 80ecd04 #4 2019-12-12 13:51:24 ~25 min android-e2e 📦apk 📲
✔️ b69d2db #5 2019-12-13 11:28:57 ~8 min ios 📦ipa 📲
✔️ b69d2db #5 2019-12-13 11:37:45 ~17 min android 📦apk 📲
✔️ b69d2db #5 2019-12-13 11:38:00 ~17 min android-e2e 📦apk 📲

@statustestbot
Copy link

74% of end-end tests have passed

Total executed tests: 99
Failed tests: 26
Passed tests: 73

Failed tests (26)

Click to expand
1. test_install_pack_and_send_sticker

Device 1: =========================================================================
Device 1: install free sticker pack and use it in public chat

Device 1: 'ShowStickersButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

2. test_login_with_new_account

Device 1: Tap 'Confirm' on native keyboard
Device 1: Wait for HomeButton

Device 1: User is not logged in; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

3. test_clear_history_of_group_chat_via_group_view

Device 1: Tap 'Confirm' on native keyboard
Device 1: Looking for an element by text: 'bhdusjd'

Device 1: 'BaseButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

4. test_public_chat_clear_history

Device 1: Tap 'Confirm' on native keyboard
Device 1: Looking for an element by text: '#jnhpimj'

Device 1: 'BaseButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

5. test_user_can_switch_network

Device 1: Wait for DefaultUserNameText
Device 1: Scrolling down to AdvancedButton

Device 1: 'AdvancedButton' is not found on the screen

During handling of the above exception, another exception occurred:
E selenium.common.exceptions.WebDriverException: Message: An unknown server-side error occurred while processing the command. Ori

Device sessions

6. test_set_profile_picture

Device 1: Tap on ProfileButton
Device 1: Wait for DefaultUserNameText

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set?
at io.appium.uiautoma

Device sessions

7. test_home_view

Device 1: Looking for an element by text: 'Chat and transact privately with your friends.'
Device 1: Looking for an element by text: 'Your chats will appear here. To start new chats press the ⊕ button'

'Your chats will appear here. To start new chats press the ⊕ button' text is not shown after welcome view was closed; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValu

Device sessions

8. test_send_message_to_newly_added_contact

Device 2: Tap on ChatMenuButton
Device 2: Tap on ViewProfileButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set?
at io.appium.uiautoma

Device sessions

9. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set?
at io.appium.uiautoma

Device sessions

10. test_add_account_to_multiaccount_instance

Device 1: Tap on FinishButton
Device 1: Wait for AccountElementButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set?
at io.appium.uiautoma

Device sessions

11. test_user_can_remove_profile_picture

Device 1: Tap on AllowButton
Device 1: Looking for an element by text: 'sauce_logo.png'

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set?
at io.appium.uiautoma

Device sessions

12. test_can_add_existing_ens

Device 1: Wait for DefaultUserNameText
Device 1: Scrolling down to ENSusernames

Device 1: 'ENSusernames' is not found on the screen

During handling of the above exception, another exception occurred:
E selenium.common.exceptions.WebDriverException: Message: An unknown server-side error occurred while processing the command. Origi

Device sessions

13. test_always_allow_web3_permissions

Device 1: Tap on DappTabButton
Device 1: Wait for EnterUrlEditbox

Device 1: 'EnterUrlEditbox' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

14. test_long_press_to_delete_public_chat

Device 1: Tap on PlusButton
Device 1: Wait for JoinPublicChatButton

Device 1: 'JoinPublicChatButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

15. test_can_use_purchased_stickers_on_recovered_account

Device 1: Tap on PlusButton
Device 1: Wait for JoinPublicChatButton

Device 1: 'JoinPublicChatButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

16. test_start_chat_with_ens

Device 1: Tap on PlusButton
Device 1: Wait for StartNewChatButton

Device 1: 'StartNewChatButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

17. test_ens_username_recipient

Device 1: =========================================================================
Device 1: checking that "stateofus.eth" name will be resolved as recipient

Device 1: 'SignInPhraseText' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

18. test_open_public_chat_using_deep_link

Device 1: Type 'qwerty' to PasswordInput
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'UserNameText' is not found on the screen

During handling of the above exception, another exception occurred:
E Failed: Device 1: Public chat 'abyinme' is not opened; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt t

Device sessions

19. test_send_transaction_from_daap

Device 1: Type 'status-im.github.io/dapp' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AllowButton' is not found on the screen

Device sessions

20. test_long_press_delete_clear_all_dapps

Device 1: Wait for EnterUrlEditbox
Device 1: Wait for BrowserEntry

Device 1: 'EnterUrlEditbox' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

21. test_pair_devices_sync_name_photo_public_group_chats

Device 2: Tap on ProfileButton
Device 2: Wait for DefaultUserNameText

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set?
at io.appium.uiautoma

Device sessions

22. test_ens_in_public_and_1_1_chats

Device 1: Wait for DefaultUserNameText
Device 1: Scrolling down to ENSusernames

Device 1: 'ENSusernames' is not found on the screen

During handling of the above exception, another exception occurred:
E selenium.common.exceptions.WebDriverException: Message: An unknown server-side error occurred while processing the command. Origi

Device sessions

23. test_block_user_from_public_chat

Device 1: Tap on PlusButton
Device 1: Wait for JoinPublicChatButton

Device 1: 'JoinPublicChatButton' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

24. test_user_can_see_all_own_assets_after_account_recovering

Device 1: Tap on WalletButton
Device 1: Wait for MultiaccountMoreOptions

Device 1: 'SignInPhraseText' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

25. test_messaging_in_different_networks

Device 2: Wait for ChatMessageInput
Device 2: Looking for a message by text: 'test message'

Device 2: 'ChatElementByText' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

26. test_collectible_from_wallet_opens_in_browser_view

Device 1: Tap on WalletButton
Device 1: Wait for MultiaccountMoreOptions

Device 1: 'SignInPhraseText' is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference'

Device sessions

Passed tests (73)

Click to expand
1. test_search_chat_on_home
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_send_message_in_group_chat
Device sessions

4. test_password_in_logcat_sign_in
Device sessions

5. test_logcat_recovering_account
Device sessions

6. test_modify_transaction_fee_values
Device sessions

7. test_need_help_section
Device sessions

8. test_send_and_open_links
Device sessions

9. test_mobile_data_usage_popup_stop_syncing
Device sessions

10. test_mobile_data_usage_settings
Device sessions

11. test_create_new_group_chat
Device sessions

12. test_sign_typed_message
Device sessions

13. test_mobile_data_usage_popup_continue_syncing
Device sessions

14. test_open_google_com_via_open_dapp
Device sessions

15. test_share_contact_code_and_wallet_address
Device sessions

16. test_make_admin_member_of_group_chat
Device sessions

17. test_connection_is_secure
Device sessions

18. test_can_open_dapp_from_dapp_store
Device sessions

19. test_refresh_button_browsing_app_webview
Device sessions

20. test_long_press_to_delete_1_1_chat
Device sessions

21. test_transaction_wrong_password_wallet
Device sessions

22. test_public_chat_messaging
Device sessions

23. test_unread_messages_counter_public_chat
Device sessions

24. test_delete_one_to_one_chat_via_delete_button
Device sessions

25. test_text_message_1_1_chat
Device sessions

26. test_delete_public_chat_via_delete_button
Device sessions

27. test_open_transaction_on_etherscan
Device sessions

28. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

29. test_unread_messages_counter_1_1_chat
Device sessions

30. test_contact_profile_view
Device sessions

31. test_logcat_backup_recovery_phrase
Device sessions

32. test_delete_group_chat_via_delete_button
Device sessions

33. test_open_blocked_site
Device sessions

34. test_open_chat_by_pasting_public_key
Device sessions

35. test_fetch_more_history_in_empty_chat
Device sessions

36. test_switch_users_and_add_new_account
Device sessions

37. test_copy_contact_code_and_wallet_address
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_message_marked_as_sent_in_1_1_chat
Device sessions

40. test_copy_and_paste_messages
Device sessions

41. test_deploy_contract_from_daap
Device sessions

42. test_password_in_logcat_creating_account
Device sessions

43. test_add_custom_token
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_group_chat_system_messages
Device sessions

46. test_dapps_permissions
Device sessions

47. test_request_public_key_status_test_daap
Device sessions

48. test_logcat_send_transaction_from_wallet
Device sessions

49. test_log_level_and_fleet
Device sessions

50. test_recover_account_from_new_user_seedphrase
Device sessions

51. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

52. test_send_two_transactions_in_batch_in_dapp
Device sessions

53. test_fetching_balance_after_offline
Device sessions

54. test_logcat_sign_message_from_daap
Device sessions

55. test_offline_status
Device sessions

56. test_wallet_set_up
Device sessions

57. test_manage_assets
Device sessions

58. test_add_new_group_chat_member
Device sessions

59. test_offline_messaging_1_1_chat
Device sessions

60. test_decline_invitation_to_group_chat
Device sessions

61. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

62. test_send_token_with_7_decimals
Device sessions

63. test_pass_phrase_validation
Device sessions

64. test_send_emoji
Device sessions

65. test_filters_from_daap
Device sessions

66. test_redirect_to_public_chat_tapping_tag_message
Device sessions

67. test_pair_devices_sync_one_to_one_contacts
Device sessions

68. test_logcat_send_transaction_from_daap
Device sessions

69. test_send_funds_between_accounts_in_multiaccount_instance
Device sessions

70. test_add_contact_from_public_chat
Device sessions

71. test_remove_member_from_group_chat
Device sessions

72. test_send_eth_from_wallet_to_address
Device sessions

73. test_send_stt_from_wallet
Device sessions

@churik
Copy link
Member

churik commented Dec 11, 2019

@flexsurfer issue in PR: can't login after logout.
See results of test_install_pack_and_send_sticker

Steps + logs: https://saucelabs.com/jobs/9bd3dde84bc74c3098710114b81f11c1?auth=c3021d252828d09cb2e333ff685295b5

@flexsurfer
Copy link
Member Author

@churik can't reproduce, could you help?

@flexsurfer flexsurfer force-pushed the feature/remove-qr-and-screen-provacy branch from c3ee6bb to 0a50601 Compare December 11, 2019 14:56
@flexsurfer
Copy link
Member Author

@churik thanks, fixed

@flexsurfer flexsurfer force-pushed the feature/remove-qr-and-screen-provacy branch from 0a50601 to 083b5e9 Compare December 12, 2019 12:58
@flexsurfer flexsurfer force-pushed the feature/remove-qr-and-screen-provacy branch from 083b5e9 to 80ecd04 Compare December 12, 2019 13:25
@statustestbot
Copy link

89% of end-end tests have passed

Total executed tests: 98
Failed tests: 11
Passed tests: 87

Failed tests (11)

Click to expand
1. test_user_can_switch_network

Device 1: Wait for OkButton
Device 1: Wait for ContinueButton

Device 1: 'PasswordInput' is not found on the screen

Device sessions

2. test_set_profile_picture

Device 1: Tap on ProfileButton
Device 1: Wait for DefaultUserNameText

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

3. test_send_message_to_newly_added_contact

Device 2: Tap on ChatMenuButton
Device 2: Tap on ViewProfileButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

4. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

5. test_add_account_to_multiaccount_instance

Device 1: Tap on FinishButton
Device 1: Wait for AccountElementButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

6. test_user_can_remove_profile_picture

Device 1: Tap on AllowButton
Device 1: Looking for an element by text: 'sauce_logo.png'

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

7. test_onboarding_screen_when_requesting_tokens_for_recovered_account

Device 1: Wait for ContinueButton
Device 1: Wait for OtherMultiAccountsButton

Device 1: 'AccessKeyButton' is not found on the screen

Device sessions

8. test_switch_users_and_add_new_account

Device 1: Wait for ContinueButton
Device 1: Wait for OkButton

Device 1: 'BackButton' is not found on the screen

Device sessions

9. test_request_public_key_status_test_daap

Device 1: Type 'status-im.github.io/dapp' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AllowButton' is not found on the screen

Device sessions

10. test_pair_devices_sync_name_photo_public_group_chats

Device 2: Tap on ProfileButton
Device 2: Wait for DefaultUserNameText

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

11. test_fetching_balance_after_offline

Device 1: Wait for AssetTextElement
Device 1: Waiting 300 seconds for STT to display asset

Device 1: Balance is not changed during 300 seconds!

Device sessions

Passed tests (87)

Click to expand
1. test_search_chat_on_home
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_install_pack_and_send_sticker
Device sessions

4. test_send_message_in_group_chat
Device sessions

5. test_login_with_new_account
Device sessions

6. test_clear_history_of_group_chat_via_group_view
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_sign_typed_message
Device sessions

17. test_mobile_data_usage_popup_continue_syncing
Device sessions

18. test_home_view
Device sessions

19. test_open_google_com_via_open_dapp
Device sessions

20. test_share_contact_code_and_wallet_address
Device sessions

21. test_make_admin_member_of_group_chat
Device sessions

22. test_connection_is_secure
Device sessions

23. test_can_open_dapp_from_dapp_store
Device sessions

24. test_refresh_button_browsing_app_webview
Device sessions

25. test_long_press_to_delete_1_1_chat
Device sessions

26. test_can_add_existing_ens
Device sessions

27. test_transaction_wrong_password_wallet
Device sessions

28. test_public_chat_messaging
Device sessions

29. test_unread_messages_counter_public_chat
Device sessions

30. test_delete_one_to_one_chat_via_delete_button
Device sessions

31. test_long_press_to_delete_public_chat
Device sessions

32. test_text_message_1_1_chat
Device sessions

33. test_delete_public_chat_via_delete_button
Device sessions

34. test_can_use_purchased_stickers_on_recovered_account
Device sessions

35. test_open_transaction_on_etherscan
Device sessions

36. test_unread_messages_counter_1_1_chat
Device sessions

37. test_contact_profile_view
Device sessions

38. test_logcat_backup_recovery_phrase
Device sessions

39. test_delete_group_chat_via_delete_button
Device sessions

40. test_start_chat_with_ens
Device sessions

41. test_open_blocked_site
Device sessions

42. test_open_chat_by_pasting_public_key
Device sessions

43. test_ens_username_recipient
Device sessions

44. test_fetch_more_history_in_empty_chat
Device sessions

45. test_open_public_chat_using_deep_link
Device sessions

46. test_copy_contact_code_and_wallet_address
Device sessions

47. test_send_transaction_from_daap
Device sessions

48. test_send_two_transactions_one_after_another_in_dapp
Device sessions

49. test_message_marked_as_sent_in_1_1_chat
Device sessions

50. test_long_press_delete_clear_all_dapps
Device sessions

51. test_copy_and_paste_messages
Device sessions

52. test_deploy_contract_from_daap
Device sessions

53. test_password_in_logcat_creating_account
Device sessions

54. test_add_custom_token
Device sessions

55. test_sign_message_from_daap
Device sessions

56. test_group_chat_system_messages
Device sessions

57. test_dapps_permissions
Device sessions

58. test_logcat_send_transaction_from_wallet
Device sessions

59. test_log_level_and_fleet
Device sessions

60. test_recover_account_from_new_user_seedphrase
Device sessions

61. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

62. test_send_two_transactions_in_batch_in_dapp
Device sessions

63. test_ens_in_public_and_1_1_chats
Device sessions

64. test_block_user_from_public_chat
Device sessions

65. test_logcat_sign_message_from_daap
Device sessions

66. test_offline_status
Device sessions

67. test_wallet_set_up
Device sessions

68. test_manage_assets
Device sessions

69. test_add_new_group_chat_member
Device sessions

70. test_offline_messaging_1_1_chat
Device sessions

71. test_decline_invitation_to_group_chat
Device sessions

72. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

73. test_send_token_with_7_decimals
Device sessions

74. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

75. test_pass_phrase_validation
Device sessions

76. test_send_emoji
Device sessions

77. test_filters_from_daap
Device sessions

78. test_redirect_to_public_chat_tapping_tag_message
Device sessions

79. test_pair_devices_sync_one_to_one_contacts
Device sessions

80. test_logcat_send_transaction_from_daap
Device sessions

81. test_send_funds_between_accounts_in_multiaccount_instance
Device sessions

82. test_add_contact_from_public_chat
Device sessions

83. test_remove_member_from_group_chat
Device sessions

84. test_send_eth_from_wallet_to_address
Device sessions

85. test_send_stt_from_wallet
Device sessions

86. test_messaging_in_different_networks
Device sessions

87. test_collectible_from_wallet_opens_in_browser_view
Device sessions

@statustestbot
Copy link

93% of end-end tests have passed

Total executed tests: 98
Failed tests: 7
Passed tests: 91

Failed tests (7)

Click to expand
1. test_set_profile_picture

Device 1: Tap on ProfileButton
Device 1: Wait for DefaultUserNameText

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

2. test_send_message_to_newly_added_contact

Device 2: Tap on ChatMenuButton
Device 2: Tap on ViewProfileButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

3. test_add_to_contacts

Device 1: Tap on ChatMenuButton
Device 1: Tap on ViewProfileButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

4. test_add_account_to_multiaccount_instance

Device 1: Tap on FinishButton
Device 1: Wait for AccountElementButton

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

5. test_user_can_remove_profile_picture

Device 1: Tap on AllowButton
Device 1: Looking for an element by text: 'sauce_logo.png'

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

6. test_fetch_more_history_in_empty_chat

Device 1: Wait for ChatMessageInput
Device 1: Looking for an element by text part: 'Dec 11, 2019'

Device 1: "Dec 11, 2019" is not shown

Device sessions

7. test_pair_devices_sync_name_photo_public_group_chats

Device 2: Tap on ProfileButton
Device 2: Wait for DefaultUserNameText

An unknown server-side error occurred while processing the command. Original error: io.appium.uiautomator2.common.exceptions.TakeScreenshotException: Failed to capture a screenshot. Does the current view have 'secure' flag set? at io.appium.uiautoma

Device sessions

Passed tests (91)

Click to expand
1. test_search_chat_on_home
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_install_pack_and_send_sticker
Device sessions

4. test_send_message_in_group_chat
Device sessions

5. test_login_with_new_account
Device sessions

6. test_clear_history_of_group_chat_via_group_view
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_sign_typed_message
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_share_contact_code_and_wallet_address
Device sessions

22. test_make_admin_member_of_group_chat
Device sessions

23. test_connection_is_secure
Device sessions

24. test_can_open_dapp_from_dapp_store
Device sessions

25. test_refresh_button_browsing_app_webview
Device sessions

26. test_long_press_to_delete_1_1_chat
Device sessions

27. test_can_add_existing_ens
Device sessions

28. test_transaction_wrong_password_wallet
Device sessions

29. test_public_chat_messaging
Device sessions

30. test_unread_messages_counter_public_chat
Device sessions

31. test_delete_one_to_one_chat_via_delete_button
Device sessions

32. test_long_press_to_delete_public_chat
Device sessions

33. test_text_message_1_1_chat
Device sessions

34. test_delete_public_chat_via_delete_button
Device sessions

35. test_can_use_purchased_stickers_on_recovered_account
Device sessions

36. test_open_transaction_on_etherscan
Device sessions

37. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

38. test_unread_messages_counter_1_1_chat
Device sessions

39. test_contact_profile_view
Device sessions

40. test_logcat_backup_recovery_phrase
Device sessions

41. test_delete_group_chat_via_delete_button
Device sessions

42. test_start_chat_with_ens
Device sessions

43. test_open_blocked_site
Device sessions

44. test_open_chat_by_pasting_public_key
Device sessions

45. test_ens_username_recipient
Device sessions

46. test_open_public_chat_using_deep_link
Device sessions

47. test_switch_users_and_add_new_account
Device sessions

48. test_copy_contact_code_and_wallet_address
Device sessions

49. test_send_transaction_from_daap
Device sessions

50. test_send_two_transactions_one_after_another_in_dapp
Device sessions

51. test_message_marked_as_sent_in_1_1_chat
Device sessions

52. test_long_press_delete_clear_all_dapps
Device sessions

53. test_copy_and_paste_messages
Device sessions

54. test_deploy_contract_from_daap
Device sessions

55. test_password_in_logcat_creating_account
Device sessions

56. test_add_custom_token
Device sessions

57. test_sign_message_from_daap
Device sessions

58. test_group_chat_system_messages
Device sessions

59. test_dapps_permissions
Device sessions

60. test_request_public_key_status_test_daap
Device sessions

61. test_logcat_send_transaction_from_wallet
Device sessions

62. test_log_level_and_fleet
Device sessions

63. test_recover_account_from_new_user_seedphrase
Device sessions

64. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

65. test_send_two_transactions_in_batch_in_dapp
Device sessions

66. test_ens_in_public_and_1_1_chats
Device sessions

67. test_block_user_from_public_chat
Device sessions

68. test_fetching_balance_after_offline
Device sessions

69. test_logcat_sign_message_from_daap
Device sessions

70. test_offline_status
Device sessions

71. test_wallet_set_up
Device sessions

72. test_manage_assets
Device sessions

73. test_add_new_group_chat_member
Device sessions

74. test_offline_messaging_1_1_chat
Device sessions

75. test_decline_invitation_to_group_chat
Device sessions

76. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

77. test_send_token_with_7_decimals
Device sessions

78. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

79. test_pass_phrase_validation
Device sessions

80. test_send_emoji
Device sessions

81. test_filters_from_daap
Device sessions

82. test_redirect_to_public_chat_tapping_tag_message
Device sessions

83. test_pair_devices_sync_one_to_one_contacts
Device sessions

84. test_logcat_send_transaction_from_daap
Device sessions

85. test_send_funds_between_accounts_in_multiaccount_instance
Device sessions

86. test_add_contact_from_public_chat
Device sessions

87. test_remove_member_from_group_chat
Device sessions

88. test_send_eth_from_wallet_to_address
Device sessions

89. test_send_stt_from_wallet
Device sessions

90. test_messaging_in_different_networks
Device sessions

91. test_collectible_from_wallet_opens_in_browser_view
Device sessions

@churik
Copy link
Member

churik commented Dec 13, 2019

@rachelhamlin
I'm against merging this PR as it is.
The reason is that when "Hide content" is ON by default it is not possible to make a screenshots of application. Hence

  1. 7 tests in PR (based on screenshots comparing) will always fail
  2. making screenshots in case of test failure will be useless

Suggested solution:

cc @corpetty

@flexsurfer flexsurfer force-pushed the feature/remove-qr-and-screen-provacy branch from 80ecd04 to b69d2db Compare December 13, 2019 11:20
@flexsurfer
Copy link
Member Author

@churik disabled for e2e builds

@statustestbot
Copy link

96% of end-end tests have passed

Total executed tests: 98
Failed tests: 4
Passed tests: 94

Failed tests (4)

Click to expand
1. test_share_contact_code_and_wallet_address

Device 1: Wait for OkButton
Device 1: Wait for ContinueButton

Device 1: 'GetStartedButton' is not found on the screen

Device sessions

2. test_dapps_permissions

Device 1: Type 'status-im.github.io/dapp' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AllowButton' is not found on the screen

Device sessions

3. test_fetching_balance_after_offline

Device 1: Wait for AssetTextElement
Device 1: Waiting 300 seconds for STT to display asset

Device 1: Balance is not changed during 300 seconds!

Device sessions

4. test_collectible_from_wallet_opens_in_browser_view

Device 1: Wait for MultiaccountMoreOptions
Device 1: Wait for MultiaccountMoreOptions

Device 1: 'SignInPhraseText' is not found on the screen

Device sessions

Passed tests (94)

Click to expand
1. test_search_chat_on_home
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_install_pack_and_send_sticker
Device sessions

4. test_send_message_in_group_chat
Device sessions

5. test_login_with_new_account
Device sessions

6. test_clear_history_of_group_chat_via_group_view
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_sign_typed_message
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_set_profile_picture
Device sessions

20. test_home_view
Device sessions

21. test_open_google_com_via_open_dapp
Device sessions

22. test_send_message_to_newly_added_contact
Device sessions

23. test_make_admin_member_of_group_chat
Device sessions

24. test_connection_is_secure
Device sessions

25. test_add_to_contacts
Device sessions

26. test_add_account_to_multiaccount_instance
Device sessions

27. test_can_open_dapp_from_dapp_store
Device sessions

28. test_user_can_remove_profile_picture
Device sessions

29. test_refresh_button_browsing_app_webview
Device sessions

30. test_long_press_to_delete_1_1_chat
Device sessions

31. test_can_add_existing_ens
Device sessions

32. test_transaction_wrong_password_wallet
Device sessions

33. test_public_chat_messaging
Device sessions

34. test_unread_messages_counter_public_chat
Device sessions

35. test_delete_one_to_one_chat_via_delete_button
Device sessions

36. test_long_press_to_delete_public_chat
Device sessions

37. test_text_message_1_1_chat
Device sessions

38. test_delete_public_chat_via_delete_button
Device sessions

39. test_can_use_purchased_stickers_on_recovered_account
Device sessions

40. test_open_transaction_on_etherscan
Device sessions

41. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

42. test_unread_messages_counter_1_1_chat
Device sessions

43. test_contact_profile_view
Device sessions

44. test_logcat_backup_recovery_phrase
Device sessions

45. test_delete_group_chat_via_delete_button
Device sessions

46. test_start_chat_with_ens
Device sessions

47. test_open_blocked_site
Device sessions

48. test_open_chat_by_pasting_public_key
Device sessions

49. test_ens_username_recipient
Device sessions

50. test_fetch_more_history_in_empty_chat
Device sessions

51. test_open_public_chat_using_deep_link
Device sessions

52. test_switch_users_and_add_new_account
Device sessions

53. test_copy_contact_code_and_wallet_address
Device sessions

54. test_send_transaction_from_daap
Device sessions

55. test_send_two_transactions_one_after_another_in_dapp
Device sessions

56. test_message_marked_as_sent_in_1_1_chat
Device sessions

57. test_long_press_delete_clear_all_dapps
Device sessions

58. test_copy_and_paste_messages
Device sessions

59. test_deploy_contract_from_daap
Device sessions

60. test_password_in_logcat_creating_account
Device sessions

61. test_add_custom_token
Device sessions

62. test_sign_message_from_daap
Device sessions

63. test_group_chat_system_messages
Device sessions

64. test_request_public_key_status_test_daap
Device sessions

65. test_logcat_send_transaction_from_wallet
Device sessions

66. test_pair_devices_sync_name_photo_public_group_chats
Device sessions

67. test_log_level_and_fleet
Device sessions

68. test_recover_account_from_new_user_seedphrase
Device sessions

69. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

70. test_send_two_transactions_in_batch_in_dapp
Device sessions

71. test_ens_in_public_and_1_1_chats
Device sessions

72. test_block_user_from_public_chat
Device sessions

73. test_logcat_sign_message_from_daap
Device sessions

74. test_offline_status
Device sessions

75. test_wallet_set_up
Device sessions

76. test_manage_assets
Device sessions

77. test_add_new_group_chat_member
Device sessions

78. test_offline_messaging_1_1_chat
Device sessions

79. test_decline_invitation_to_group_chat
Device sessions

80. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

81. test_send_token_with_7_decimals
Device sessions

82. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

83. test_pass_phrase_validation
Device sessions

84. test_send_emoji
Device sessions

85. test_filters_from_daap
Device sessions

86. test_redirect_to_public_chat_tapping_tag_message
Device sessions

87. test_pair_devices_sync_one_to_one_contacts
Device sessions

88. test_logcat_send_transaction_from_daap
Device sessions

89. test_send_funds_between_accounts_in_multiaccount_instance
Device sessions

90. test_add_contact_from_public_chat
Device sessions

91. test_remove_member_from_group_chat
Device sessions

92. test_send_eth_from_wallet_to_address
Device sessions

93. test_send_stt_from_wallet
Device sessions

94. test_messaging_in_different_networks
Device sessions

@churik
Copy link
Member

churik commented Dec 13, 2019

Tested on IOS and Android 9, looks good to me.
e2e build doesn't have this option enabled.
Failed tests are not related to this PR.
Thanks for fix @flexsurfer and ready to go

@flexsurfer
[#9636] Remove chat menu item and toggle app switching privacy on by …
c84c44f 
…default

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer force-pushed the feature/remove-qr-and-screen-provacy branch from b69d2db to c84c44f Compare December 13, 2019 13:47
@flexsurfer flexsurfer merged commit c84c44f into develop Dec 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/remove-qr-and-screen-provacy branch December 13, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@vitvly vitvly Awaiting requested review from vitvly

@yenda yenda Awaiting requested review from yenda

@jakubgs jakubgs Awaiting requested review from jakubgs jakubgs is a code owner

Assignees
No one assigned
Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove chat menu item and toggle app switching privacy on by default
5 participants
@flexsurfer @status-im-auto @statustestbot @churik @rasom