-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9789] Add a loading indicator and button to username input of start… #9993
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (7)
|
63d6033
to
b98f8de
Compare
(when @timeout (js/clearTimeout @timeout))) | ||
|
||
(def chill? (atom false)) | ||
(def chill (atom {})) | ||
|
||
(defn dispatch-and-chill | ||
"Dispateches event and ignores next calls in period of *time* ms" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this PR, but noticed it here: dispateches
typo.
(cond (= state :error) | ||
(i18n/label :t/user-not-found) | ||
(= state :valid) | ||
(str (when ens-name (str ens-name " • ")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably would make sense to move the dot separator to a constant.
Tested on Android 8.1 and iOS 13.3(iPhoneX) latest builds: Issue1 b) app crashes when I scan invalid public key (like a wallet address QR code) Issue2 Issue3 |
thanks @Serhy can confirm that issue1 only in my PR and not in develop? because i didn't change anything related to QR, for issue3 @errorists wdyt ? |
re: issue 2. this empty space between the input and list where the subtitle appears should have a constant height to avoid any jumps if the text is present / not. issue 3. absolutely right. tho i remember we wanted to add the ability to start a chat with yourself a long time ago, that's a totally separate discussion. for now thanks guys, you're awesome! |
b98f8de
to
bbbe0bc
Compare
thanks @Serhy all issues should be fixed now |
100% of end-end tests have passed
Passed tests (95)Click to expand
|
@flexsurfer, everything works great now but I can still reproduce Issue2 on Android 8.1 / Android9. It's fixed on iOS side, but on Android list of user jumps whenever informing subtitle appears (latest build tested https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-200225-120611-bbbe0b-pr-universal.apk) |
bbbe0bc
to
648264f
Compare
@Serhy fixed |
@Serhy fixed |
Works greatly for me with iOS and Android now! |
… new chat Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
648264f
to
d64ba1b
Compare
fixes #9789