Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Add new contact' flow to Contact screen #10892

Closed
hesterbruikman opened this issue Jun 30, 2020 · 0 comments · Fixed by #10896
Closed

Add 'Add new contact' flow to Contact screen #10892

hesterbruikman opened this issue Jun 30, 2020 · 0 comments · Fixed by #10896

Comments

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Jun 30, 2020

Issue within epic #7234

Problem

Currently there are two ways to add a new contact to Contacts:

  • Inside a 1:1 chat, tap the Add to contacts bar at the top of the chat screen
  • Tap on a username to view their Profile and tap Add to contacts

This does not accommodate the workflow of adding contacts to a phonebook without starting a chat.

Implementation

  • Add a Add new contact button to the contact screen
  • Allow search by ENS username
    Input here is a direct replica of the one we currently have in New Private Chat, but it does tell you if a name exists as you type and to which public key it maps to, so in a way it's doing a search after each letter you type

Designs on Figma

Frame 165

Acceptance Criteria

Follows designs on Figma

Notes

Adding contacts is not center stage in the UI as starting a chat does not require 'friending' or 'being contacts'. Contacts rather serves as a phonebook. Adding an explicit Add new contact button to the Contacts view, makes starting a chat easier for those under the impression that it is required.

Future Steps

Add remaining features to contact management as found in the design and epic #7234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant