Use interactive components from Quo #10686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (164)
|
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
7c7bfab
to
4ae0e36
Compare
Ferossgp
changed the title
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
4ae0e36
to
4ea9f46
Compare
1% of end-end tests have passedFailed tests (94)Click to expand
Passed tests (1) |
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
864f70d
to
c95d81a
Compare
1 similar comment
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
ef84701
to
b05784e
Compare
16% of end-end tests have passedFailed tests (80)Click to expand
Passed tests (15)Click to expand
|
16% of end-end tests have passedFailed tests (80)Click to expand
Passed tests (15)Click to expand
|
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
cb34dfa
to
8bf78b9
Compare
53% of end-end tests have passedFailed tests (45)Click to expand
Passed tests (50)Click to expand |
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
3 times, most recently
from
af339db
to
c793027
Compare
43% of end-end tests have passedFailed tests (54)Click to expand
Passed tests (41)Click to expand |
95% of end-end tests have passedFailed tests (5)Click to expand
Passed tests (89)Click to expand |
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
1bb455b
to
31cd596
Compare
97% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (90)Click to expand |
|
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more |
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
3e839c5
to
1262204
Compare
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
1262204
to
7d5de29
Compare
96% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (92)Click to expand
|
0% of end-end tests have passedFailed tests (2)Click to expand
|
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
7d5de29
to
857c7e5
Compare
100% of end-end tests have passedPassed tests (2)Click to expand
|
|
@Ferossgp thanks a lot for huge work done here and for fixing regressions |
Ferossgp
changed the title
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
4def364
to
6df9a2e
Compare
Replace all the usage of the button without component Use quo Fix tests List item in multiaccounts Use list items in contacts Fix welcome screen button Experiment long press Big list item Remove old bottom sheet Use bottom sheet Keycard Add error to list item Stickers panel button Images panel Fix z-index in profile Fix android crash Fix signing list item Try fixing test iOs gas sheet keyboard Disable root alert in e2e keycard signing sheet height Clean up bottom sheet events Replace flat list in profile Memorise the manual-close value for bottom sheet Mailserver QR scanner Fix e2e tests E2e fix 2 Fix e2e 3 Remove extra fn Reduce bridging time for animation Trick android layout Try hooks Fix profile missing ens-name Disable press on control in list-view allow disabling animations in list item Use simple list in wallet assets settings TBD - this screen should be rewritten from scratch. Now on every interaction the full list is re-rendered, also it makes the wallet main screen to re-render. Fix send sheet Handle long press in main thread UI fixes perf Update e2e fix missing user name in image long press Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
replace-toolbar-and-button
branch
from
6df9a2e
to
497af38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Quo components to the Status App. All components are introduced in one PR to enable animations to all components at once because the Gesture Handler was changed. Code that was not using components was refactored, thus UI regressions may be introduced.
Components updated and refactored: