-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#10195] Separate keystore dir per multiacc #10847
Conversation
Jenkins BuildsClick to see older builds (56)
|
fyi @johnlea-quiup as this relates to key management, specifically removing a 'multiaccount' (master keypair) |
5eb0811
to
a29bfa0
Compare
8dbc55b
to
e807a44
Compare
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more |
1f8f8d3
to
a2dfae2
Compare
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (93)Click to expand |
Can't send transaction from account if it is added as separate multiaccount with keycardSteps:
Expected result: can send Transaction |
a2dfae2
to
00e2380
Compare
@churik is this even possible? |
Previous issue is not reproducible with the same steps, but I've got another error: Steps:
Expected result: can send Transaction Logs: Status-debug-logs.zip |
24bc63e
to
e9de818
Compare
'Cannot retrieve a valid key for a given multiaccount error' after upgrade with 2 multiaccountsSteps:
Expected result: Actual result: error |
e9de818
to
eda3b12
Compare
eda3b12
to
e2d1186
Compare
Tested on Android 10:
Tested on IOS 13:
Looks good to me, thank you for patience @rasom |
e2d1186
to
c105bac
Compare
Having all keys related to specific multiacc in a separate dir will simplify removing of the multiacc. Also it will allow adding of the same account to different multiaccs.
c105bac
to
920bc7d
Compare
#10195
Having all keys related to specific multiacc in a separate dir will simplify removing of the multiacc.
Also it will allow adding of the same account to different multiaccs.
depends on status-im/status-go#1993
status: ready