-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8945] "null is not an object" error when tap on sticker sent in chat #9073
Conversation
Pull Request Checklist
|
Jenkins Builds
|
85% of end-end tests have passed
Failed tests (7)Click to expand
Passed tests (40)Click to expand |
@churik what happened with e2e tests here? The failures don't seem to be related to the changes |
I reviewed above tests: test_modify_transaction_fee_values - failed because signing of the respective tx were last > 10 sec. I'd say this is more app failure (common fail not this PR fail) rather than test fail. So this test clicks 'Sign' transaction button and what happened is that the process of signing tx (with the spinning spinner) lasts > 10 sec. test_logcat_backup_recovery_phrase test: false failure (rare case here) where two words from sign in phrase are in logcat but they were used as part of valid logs (currently it was 'expand' and 'index' words). I'll update this test too separately. |
was this PR tested? does it fix the bug? |
Tested with iOS 12.3, Android 8.1, Android 6.0.1 - can't reproduce the bug. |
Signed-off-by: yenda <eric@status.im>
902f83b
to
f52b87e
Compare
89% of end-end tests have passed
Failed tests (5)Click to expand
Passed tests (42)Click to expand |
fixes #8945
tested on ios simulator