Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress back-up-seed prompt when already done (fixes #8938) #9105

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Suppress back-up-seed prompt when already done (fixes #8938) #9105

merged 1 commit into from
Oct 7, 2019

Conversation

acolytec3
Copy link
Contributor

fixes #8938

Summary

Suppresses backup-seed-phrase option on Pirvacy & Security screen when already backed up

Platforms

  • Android
  • iOS

Areas that maybe impacted

Privacy & Security Settings

Functional
  • Privacy & Security Settings

Steps to test

  1. Open Status
  2. Open Profile
  3. Open Privacy & Security Settings
  4. Back up seed phrase
  5. Navigate back to Privacy & Security Settings
  6. Security section will be suppressed

status: ready

Visual representation on Android
Back-up-seed-suppresed

@acolytec3 acolytec3 requested a review from a team as a code owner October 3, 2019 20:54
@auto-assign auto-assign bot removed the request for review from a team October 3, 2019 20:54
@ghost
Copy link

ghost commented Oct 3, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@acolytec3
Copy link
Contributor Author

To reviewers, is the preference to suppress the whole security section when the backup seed has been saved, just the backup-seed menu option, or else to present the backup-seed option disabled?

As currently coded, it suppresses the whole section since this is what the original issue states as the preferred outcome.

@status-im-auto
Copy link
Member

status-im-auto commented Oct 3, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (25)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 40e4722 #1 2019-10-03 21:04:42 ~10 min ios 📦ipa 📲
✔️ 40e4722 #1 2019-10-03 21:06:25 ~12 min macos 📦dmg
✔️ 40e4722 #1 2019-10-03 21:07:11 ~12 min linux 📦App
✔️ 40e4722 #1 2019-10-03 21:07:46 ~13 min windows 📦exe
✔️ 40e4722 #1 2019-10-03 21:09:48 ~15 min android-e2e 📦apk 📲
✔️ 40e4722 #1 2019-10-03 21:09:48 ~15 min android 📦apk 📲
❌ b5e9c84 #2 2019-10-04 11:03:24 ~1 min ios 📄log
❌ b5e9c84 #2 2019-10-04 11:03:42 ~1 min macos 📄log
❌ b5e9c84 #2 2019-10-04 11:09:46 ~8 min android 📄log
❌ b5e9c84 #2 2019-10-04 11:10:08 ~8 min linux 📄log
❌ b5e9c84 #2 2019-10-04 11:10:21 ~8 min windows 📄log
✔️ b5e9c84 #2 2019-10-04 11:20:49 ~19 min android-e2e 📦apk 📲
❌ e2b5b7d #3 2019-10-04 11:51:43 ~8 min ios 📄log
❌ e2b5b7d #3 2019-10-04 11:55:58 ~12 min macos 📄log
❌ e2b5b7d #3 2019-10-04 11:56:44 ~13 min linux 📄log
❌ e2b5b7d #3 2019-10-04 11:56:59 ~13 min windows 📄log
❌ e2b5b7d #3 2019-10-04 11:57:27 ~14 min android-e2e 📄log
❌ e2b5b7d #3 2019-10-04 11:57:44 ~14 min android 📄log
❌ e2b5b7d #4 2019-10-04 15:56:08 ~10 min ios 📄log
✔️ 6761df7 #5 2019-10-04 16:54:50 ~10 min ios 📦ipa 📲
✔️ 6761df7 #4 2019-10-04 16:56:32 ~12 min macos 📦dmg
✔️ 6761df7 #4 2019-10-04 16:57:02 ~12 min windows 📦exe
✔️ 6761df7 #4 2019-10-04 16:57:36 ~13 min linux 📦App
✔️ 6761df7 #4 2019-10-04 16:59:31 ~15 min android-e2e 📦apk 📲
✔️ 6761df7 #4 2019-10-04 16:59:36 ~15 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c662fe8 #6 2019-10-04 17:19:13 ~8 min ios 📦ipa 📲
✔️ c662fe8 #5 2019-10-04 17:22:20 ~11 min macos 📦dmg
✔️ c662fe8 #5 2019-10-04 17:23:54 ~13 min windows 📦exe
✔️ c662fe8 #5 2019-10-04 17:24:46 ~14 min linux 📦App
✔️ c662fe8 #5 2019-10-04 17:27:44 ~17 min android 📦apk 📲
✔️ c662fe8 #5 2019-10-04 17:28:11 ~17 min android-e2e 📦apk 📲
✔️ 3596899 #8 2019-10-04 18:22:03 ~8 min ios 📦ipa 📲
✔️ 3596899 #7 2019-10-04 18:25:13 ~11 min android-e2e 📦apk 📲
✔️ 3596899 #7 2019-10-04 18:25:15 ~11 min macos 📦dmg
✔️ 3596899 #7 2019-10-04 18:25:27 ~11 min linux 📦App
✔️ 3596899 #7 2019-10-04 18:25:33 ~12 min android 📦apk 📲
✔️ 3596899 #7 2019-10-04 18:28:13 ~14 min windows 📦exe

@flexsurfer flexsurfer requested a review from andmironov October 4, 2019 07:16
@acolytec3
Copy link
Contributor Author

@flexsurfer I fixed the merge conflict and it looks another security option around biometric auth got added so I moved the parens to just be around the backup seed phrase option. Unfortunately,my local environment has gotten hosed somehow so I'm not able to run the app locally so can't produce a new visual. Once I get it rebuilt, I'll post one but it may be a while.

@andmironov
Copy link

Hey! Thanks for bringing this up!

What if we do something like this? But I have not considered all the possible security implications of this? Is this some sort of vulnerability, to show that the seed phrase has been already backed up?

Screen Shot 2019-10-04 at 14 01 12

@acolytec3
Copy link
Contributor Author

@andmironov That should be pretty straight-forward. Let me get my dev environment rebuilt and I can code that. @flexsurfer What do you think of that approach?

@andmironov
Copy link

UPD let's just grey it out with no "Done" not to confuse anyone

Screen Shot 2019-10-04 at 15 08 31

~figma https://www.figma.com/file/bPS9GrvMr7LnH7vnkmuveQfd/Settings?node-id=576%3A0

@acolytec3
Copy link
Contributor Author

@flexsurfer @andmironov Is there an obvious way to override the default styling on the :title element in in the list-items section? I tried applying a conditional {:style {:color colors/gray}} to it and it threw an error. I guess I can always just show an alternate view using a nested-text element in that row but was curious if I'm missing something obvious.

@flexsurfer
Copy link
Member

@acolytec3 you can use :disabled? prop

@churik
Copy link
Member

churik commented Oct 4, 2019

@acolytec3
all builds are failed.
Can you take a look?

@acolytec3
Copy link
Contributor Author

acolytec3 commented Oct 4, 2019 •
edited
Loading

@andmironov @flexsurfer Here's a screengrab from the Android Emulator with the disabled prop and the chevron suppressed. Does this look about right?

Disabled seed phrase

Here's the full screen.

Full screen

@churik I'm not sure what was happening before but it seems like the builds are working again with my latest push? I don't have access to the jenkins logs so can't tell you specifically what's wrong if anything.

@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@churik churik self-assigned this Oct 7, 2019
@statustestbot
Copy link

96% of end-end tests have passed

Total executed tests: 47
Failed tests: 2
Passed tests: 45

Failed tests (2)

Click to expand
1. test_unread_messages_counter_1_1_chat

Device 2: Tap on NextButton
Device 2: Tap on MaybeLaterButton

Device 2: 'MaybeLaterButton' is not found on the screen

Device sessions

2. test_offline_messaging_1_1_chat

Device 2: Tap on AirplaneModeButton
Device 1: Tap on AirplaneModeButton

Device 1: 'ConnectionStatusText' is still visible on the screen after 30 seconds

Device sessions

Passed tests (45)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message
Device sessions

13. test_ens_in_public_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_add_account_to_multiaccount_instance
Device sessions

21. test_manage_assets
Device sessions

22. test_long_press_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_can_add_existing_ens
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_logcat_backup_recovery_phrase
Device sessions

29. test_logcat_sign_message_from_daap
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_login_with_new_account
Device sessions

33. test_start_chat_with_ens
Device sessions

34. test_add_contact_from_public_chat
Device sessions

35. test_send_two_transactions_one_after_another_in_dapp
Device sessions

36. test_password_in_logcat_creating_account
Device sessions

37. test_backup_recovery_phrase
Device sessions

38. test_offline_status
Device sessions

39. test_open_google_com_via_open_dapp
Device sessions

40. test_unread_messages_counter_public_chat
Device sessions

41. test_sign_message_from_daap
Device sessions

42. test_user_can_remove_profile_picture (TestRail link is not found)
Device sessions

43. test_share_contact_code_and_wallet_address
Device sessions

44. test_refresh_button_browsing_app_webview
Device sessions

45. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@statustestbot
Copy link

50% of end-end tests have passed

Total executed tests: 2
Failed tests: 1
Passed tests: 1

Failed tests (1)

Click to expand
1. test_offline_messaging_1_1_chat

Device 2: Tap on AirplaneModeButton
Device 1: Tap on AirplaneModeButton

Device 1: 'ConnectionStatusText' is still visible on the screen after 30 seconds

Device sessions

Passed tests (1)

Click to expand
1. test_unread_messages_counter_1_1_chat
Device sessions

@churik
Copy link
Member

churik commented Oct 7, 2019

Tested (IOS 11.4.1, Android 8):

  • interruption of the process of "Back up seed phrase" on different stages;
  • creating account - back up seed phrase
  • restoring account
  • creating account with keycard
  • restoring account with keycard

Failed e2e is not related to this PR.

Thank you for excellent job @acolytec3 !

@acolytec3 @flexsurfer
Suppress back-up-seed prompt when already done
5ce678e 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit 5ce678e into status-im:develop Oct 7, 2019
@gitcoinbot gitcoinbot mentioned this pull request Oct 7, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
@hesterbruikman hesterbruikman mentioned this pull request Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@andmironov andmironov Awaiting requested review from andmironov

Assignees

@churik churik

Labels
bounty request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Back up seed phrase' in Profile is present for recovered accounts
6 participants
@acolytec3 @status-im-auto @andmironov @flexsurfer @churik @statustestbot