Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9748] eip681 parsing uri with whitespaces #9788

Closed
wants to merge 2 commits into from
Closed

[#9748] eip681 parsing uri with whitespaces #9788

wants to merge 2 commits into from

Conversation

ghmulti
Copy link
Contributor

@ghmulti ghmulti commented Jan 10, 2020 •
edited
Loading

Fixes #9748

Would like to hear feedback from core developers - should the fix(whitespace trimming) be done rather on the view part?

@ghmulti ghmulti requested a review from a team as a code owner January 10, 2020 08:13
@auto-assign auto-assign bot removed the request for review from a team January 10, 2020 08:13
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Jan 10, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1c8aeaa #1 2020-01-10 08:23:03 ~9 min ios 📦ipa 📲
✔️ 1c8aeaa #1 2020-01-10 08:28:26 ~14 min android-e2e 📦apk 📲
✔️ 1c8aeaa #1 2020-01-10 08:28:29 ~14 min android 📦apk 📲
✔️ f51171a #2 2020-01-16 19:35:52 ~10 min ios 📦ipa 📲
✔️ f51171a #2 2020-01-16 19:39:35 ~14 min android-e2e 📦apk 📲
✔️ f51171a #2 2020-01-16 19:39:43 ~14 min android 📦apk 📲
✔️ ca50a77 #5 2020-01-16 19:58:18 ~8 min ios 📦ipa 📲
✔️ ca50a77 #5 2020-01-16 20:01:34 ~11 min android-e2e 📦apk 📲
✔️ ca50a77 #5 2020-01-16 20:01:54 ~12 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 744959c #6 2020-01-23 21:40:20 ~3 min android 📄log
❌ 744959c #6 2020-01-23 21:40:24 ~3 min android-e2e 📄log
✔️ 744959c #6 2020-01-23 21:45:13 ~8 min ios 📦ipa 📲
❌ 123968b #7 2020-01-23 21:52:59 ~3 min android-e2e 📄log
❌ 123968b #7 2020-01-23 21:53:14 ~3 min android 📄log
✔️ 123968b #7 2020-01-23 21:57:49 ~8 min ios 📦ipa 📲

@3esmit
Copy link
Member

3esmit commented Jan 14, 2020 •
edited
Loading

What exactly changes here? Just some spaces at beginning or end?

@ghmulti
Copy link
Contributor Author

ghmulti commented Jan 15, 2020

@3esmit correct, spaces at the beginning or end will not affect on address validity

@ghmulti
Copy link
Contributor Author

ghmulti commented Jan 16, 2020 •
edited
Loading

ok, it took just 4 times to sign commit properly 🤦‍♂️ 🤦‍♂️

@statustestbot
Copy link

99% of end-end tests have passed

Total executed tests: 102
Failed tests: 1
Passed tests: 101

Failed tests (1)

Click to expand
1. test_fetching_balance_after_offline

Device 1: Wait for AssetTextElement
Device 1: Waiting 300 seconds for STT to display asset

Device 1: Balance is not changed during 300 seconds!

Device sessions

Passed tests (101)

Click to expand
1. test_search_chat_on_home
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_install_pack_and_send_sticker
Device sessions

4. test_send_message_in_group_chat
Device sessions

5. test_login_with_new_account
Device sessions

6. test_clear_history_of_group_chat_via_group_view
Device sessions

7. test_timestamp_in_chats
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_logcat_recovering_account
Device sessions

10. test_modify_transaction_fee_values
Device sessions

11. test_public_chat_clear_history
Device sessions

12. test_need_help_section
Device sessions

13. test_send_and_open_links
Device sessions

14. test_mobile_data_usage_popup_stop_syncing
Device sessions

15. test_mobile_data_usage_settings
Device sessions

16. test_create_new_group_chat
Device sessions

17. test_sign_typed_message
Device sessions

18. test_user_can_switch_network
Device sessions

19. test_mobile_data_usage_popup_continue_syncing
Device sessions

20. test_set_profile_picture
Device sessions

21. test_home_view
Device sessions

22. test_open_google_com_via_open_dapp
Device sessions

23. test_send_message_to_newly_added_contact
Device sessions

24. test_share_contact_code_and_wallet_address
Device sessions

25. test_make_admin_member_of_group_chat
Device sessions

26. test_connection_is_secure
Device sessions

27. test_add_to_contacts
Device sessions

28. test_add_account_to_multiaccount_instance
Device sessions

29. test_can_open_dapp_from_dapp_store
Device sessions

30. test_user_can_remove_profile_picture
Device sessions

31. test_refresh_button_browsing_app_webview
Device sessions

32. test_long_press_to_delete_1_1_chat
Device sessions

33. test_can_add_existing_ens
Device sessions

34. test_transaction_wrong_password_wallet
Device sessions

35. test_public_chat_messaging
Device sessions

36. test_unread_messages_counter_public_chat
Device sessions

37. test_delete_one_to_one_chat_via_delete_button
Device sessions

38. test_long_press_to_delete_public_chat
Device sessions

39. test_text_message_1_1_chat
Device sessions

40. test_delete_public_chat_via_delete_button
Device sessions

41. test_can_use_purchased_stickers_on_recovered_account
Device sessions

42. test_open_transaction_on_etherscan
Device sessions

43. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

44. test_unread_messages_counter_1_1_chat
Device sessions

45. test_contact_profile_view
Device sessions

46. test_logcat_backup_recovery_phrase
Device sessions

47. test_delete_group_chat_via_delete_button
Device sessions

48. test_start_chat_with_ens
Device sessions

49. test_add_and_remove_contact_from_public_chat
Device sessions

50. test_open_blocked_site
Device sessions

51. test_open_chat_by_pasting_public_key
Device sessions

52. test_ens_username_recipient
Device sessions

53. test_token_with_more_than_allowed_decimals
Device sessions

54. test_fetch_more_history_in_empty_chat
Device sessions

55. test_open_public_chat_using_deep_link
Device sessions

56. test_switch_users_and_add_new_account
Device sessions

57. test_copy_contact_code_and_wallet_address
Device sessions

58. test_send_transaction_from_daap
Device sessions

59. test_send_two_transactions_one_after_another_in_dapp
Device sessions

60. test_message_marked_as_sent_in_1_1_chat
Device sessions

61. test_long_press_delete_clear_all_dapps
Device sessions

62. test_copy_and_paste_messages
Device sessions

63. test_deploy_contract_from_daap
Device sessions

64. test_back_forward_buttons_browsing_website
Device sessions

65. test_password_in_logcat_creating_account
Device sessions

66. test_add_custom_token
Device sessions

67. test_sign_message_from_daap
Device sessions

68. test_group_chat_system_messages
Device sessions

69. test_dapps_permissions
Device sessions

70. test_request_public_key_status_test_daap
Device sessions

71. test_logcat_send_transaction_from_wallet
Device sessions

72. test_pair_devices_sync_name_photo_public_group_chats
Device sessions

73. test_log_level_and_fleet
Device sessions

74. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

75. test_recover_account_from_new_user_seedphrase
Device sessions

76. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

77. test_send_two_transactions_in_batch_in_dapp
Device sessions

78. test_ens_in_public_and_1_1_chats
Device sessions

79. test_block_user_from_public_chat
Device sessions

80. test_logcat_sign_message_from_daap
Device sessions

81. test_offline_status
Device sessions

82. test_wallet_set_up
Device sessions

83. test_manage_assets
Device sessions

84. test_add_new_group_chat_member
Device sessions

85. test_offline_messaging_1_1_chat
Device sessions

86. test_decline_invitation_to_group_chat
Device sessions

87. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

88. test_send_token_with_7_decimals
Device sessions

89. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

90. test_pass_phrase_validation
Device sessions

91. test_send_emoji
Device sessions

92. test_filters_from_daap
Device sessions

93. test_redirect_to_public_chat_tapping_tag_message
Device sessions

94. test_pair_devices_sync_one_to_one_contacts
Device sessions

95. test_logcat_send_transaction_from_daap
Device sessions

96. test_remove_member_from_group_chat
Device sessions

97. test_send_eth_from_wallet_to_address
Device sessions

98. test_send_stt_from_wallet
Device sessions

99. test_messaging_in_different_networks
Device sessions

100. test_collectible_from_wallet_opens_in_browser_view
Device sessions

101. test_insufficient_funds_wallet_positive_balance
Device sessions

@churik
Copy link
Member

churik commented Jan 23, 2020 •
edited
Loading

@ghmulti thank you for the contribution and sorry for delay in testing!
Checked build with ca50a77 commit.
At attempt tp scan QR with spaces:
image
And still, I see the "Invalid address" error.
Tried scanning from Choose recipient > Scan QR or from "Scan QR" icon on the top bar - same result.

@ghmulti
Copy link
Contributor Author

ghmulti commented Jan 23, 2020

@churik thanks for feedback - after reading your comment I realized that #9748 issue had actually nothing to do with whitespaces (the way error in the dialog is displayed probably makes this confusion).
I thought initially that qr code had to be formatted according to EIP 681 (with "ethereum:" scheme in front) which kind of makes sense in general except the case when you go to "Choose recipient" menu > Scan QR button (so it is explicitly said that you are scanning the arbitrary valid ethereum address[eip 55] or ens address).

@ghmulti ghmulti requested a review from yenda January 30, 2020 17:33
@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
@flexsurfer flexsurfer requested review from yenda and removed request for yenda February 5, 2020 07:29
@flexsurfer
Copy link
Member

@ghmulti is this still relevant? @yenda could you take a look?

@ghmulti
Copy link
Contributor Author

ghmulti commented Feb 5, 2020

@flexsurfer yes

@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@churik
Copy link
Member

churik commented Feb 17, 2020

thanks for feedback - after reading your comment I realized that #9748 issue had actually nothing to do with whitespaces (the way error in the dialog is displayed probably makes this confusion).
I thought initially that qr code had to be formatted according to EIP 681 (with "ethereum:" scheme in front) which kind of makes sense in general except the case when you go to "Choose recipient" menu > Scan QR button (so it is explicitly said that you are scanning the arbitrary valid ethereum address[eip 55] or ens address).

So what's next here?
IMO it would be nice to scan addresses with the content value (ethereum:0xDdc867bAB69c9488E65f610E071752f621C7F504@3), normalised one (i.e. 0xDdc867bAB69c9488E65f610E071752f621C7F504) or same but non-normalised and put value to Recipient
Currently at attempt to scan 0xDdc867bAB69c9488E65f610E071752f621C7F504 I see error invalid address

WDYT @flexsurfer ?

@churik churik self-assigned this Feb 17, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 23, 2020
Closed
@flexsurfer
Copy link
Member

@churik does this PR fix anything ?

@churik
Copy link
Member

churik commented Mar 11, 2020

@flexsurfer no, I don't think so

@flexsurfer flexsurfer closed this Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3esmit 3esmit 3esmit approved these changes

@yenda yenda Awaiting requested review from yenda

Assignees

@churik churik

Labels
request-manual-qa
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QR code reader inserts a space before the read address, throws error
7 participants
@ghmulti @status-im-auto @3esmit @statustestbot @churik @flexsurfer @yenda