Weekly Digest (26 January, 2020 - 2 February, 2020)

[weekly-digest]

Here's the Weekly Digest for status-im/status-react:

---

ISSUES

Last week 44 issues were created.
Of these, 16 issues have been closed and 28 issues are still open.

OPEN ISSUES

💚 #9961 Update glossary view, by hesterbruikman
💚 #9960 Resolve ENS names in the background, by cammellos
💚 #9958 [#9954] Add 'view profile' to message long tap, by flexsurfer
💚 #9957 [DONT MERGE]Temporary hide spinners for v1, by flexsurfer
💚 #9956 Sometimes spinner is shown for every sent message, by flexsurfer
💚 #9955 Slight change of the "generate a new account" flow, by andmironov
💚 #9954 Add 'view profile' to message long tap, by rachelhamlin
💚 #9953 Offload out-of-view messages to protect UI performance, by rachelhamlin
💚 #9952 fixes ENS to new registry, by decanus
💚 #9950 attempt to fix #9942, by rasom
💚 #9949 [WIP] Enable waku, by cammellos
💚 #9948 Allow dismissing chat's input by dragging it downward, by errorists
💚 #9947 Failed to create database after upgrading ios app, by flexsurfer
💚 #9945 WIP Rework and update react-navigation, by Ferossgp
💚 #9943 App is trying to reconnect spontaneously to 3 mailservers in the cycle it might take up to 30 sec, by flexsurfer
💚 #9941 improvement on snackbar by considering login time, by tbenr
💚 #9940 Pass extra argument to handle multiaccounts on logout, by Ferossgp
💚 #9939 Fixes cryptokitties loading/ordering, by krzyzowiec
💚 #9938 Change iOS modal presentation to Stacks, by errorists
💚 #9937 Introduce custom touchable animation with haptic feedback, by errorists
💚 #9933 Update your keys screen, by Ferossgp
💚 #9932 [WIP] Remove unused translatins, by Serhy
💚 #9931 Allow 2 lines for user name on intro screen, by Ferossgp
💚 #9929 Messages don't appear in 1-1 chat, by flexsurfer
💚 #9928 Endless spinner for messages status, by flexsurfer
💚 #9924 Clarify wallet 'send' button, by rachelhamlin
💚 #9922 Fix ens names in chat, by cammellos
💚 #9918 WIP: added the loading spinner animation, but haven't implemented the…, by alexjg

CLOSED ISSUES

❤️ #9959 Git ignore trace.edn and config.cljs, by Ferossgp
❤️ #9951 fix hardcoded value in spanish translation, by yenda
❤️ #9946 Explicitly start messenger, by cammellos
❤️ #9944 Remove contact indicator from userpic, by Ferossgp
❤️ #9942 [#9927] Fast blocks sync after being offline, by rasom
❤️ #9936 [#9280] Make sure number-of-retries is not negative, by rasom
❤️ #9935 Correctly dispatch on updates & disable them, by cammellos
❤️ #9934 fastlane: disable oldest_build_allowed for TestFlight clean, by jakubgs
❤️ #9930 Its not possible to send messages when you have endless blue line loading indicator at the top, by flexsurfer
❤️ #9927 Transaction history is delayed in status, by flexsurfer
❤️ #9926 Disable editprofile tests, by Serhy
❤️ #9925 fix #9903 hide buttons of actions that are not yet implemented, by yenda
❤️ #9923 add Augur token (REP) images, by yenda
❤️ #9921 Fix e2e after removed custom pic, by Serhy
❤️ #9920 Add REP logo for wallet asset, by rachelhamlin
❤️ #9919 [Fixes: #9900] Use component-did-update, by cammellos

LIKED ISSUE

👍 #9942 [#9927] Fast blocks sync after being offline, by rasom
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x1.

NOISY ISSUE

🔈 #9942 [#9927] Fast blocks sync after being offline, by rasom
It received 12 comments.

---

PULL REQUESTS

Last week, 44 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 25 pull requests were updated.
💛 #9960 Resolve ENS names in the background, by cammellos
💛 #9958 [#9954] Add 'view profile' to message long tap, by flexsurfer
💛 #9957 [DONT MERGE]Temporary hide spinners for v1, by flexsurfer
💛 #9952 fixes ENS to new registry, by decanus
💛 #9950 attempt to fix #9942, by rasom
💛 #9949 [WIP] Enable waku, by cammellos
💛 #9945 WIP Rework and update react-navigation, by Ferossgp
💛 #9941 improvement on snackbar by considering login time, by tbenr
💛 #9940 Pass extra argument to handle multiaccounts on logout, by Ferossgp
💛 #9939 Fixes cryptokitties loading/ordering, by krzyzowiec
💛 #9933 Update your keys screen, by Ferossgp
💛 #9932 [WIP] Remove unused translatins, by Serhy
💛 #9931 Allow 2 lines for user name on intro screen, by Ferossgp
💛 #9924 Clarify wallet 'send' button, by rachelhamlin
💛 #9922 Fix ens names in chat, by cammellos
💛 #9918 WIP: added the loading spinner animation, but haven't implemented the…, by alexjg
💛 #9917 componentizied input-search and search in set currency and token management, by tbenr
💛 #9915 WIP Make bottom sheet dynamical, by Ferossgp
💛 #9898 add watch only address using qrcode, by tbenr
💛 #9890 [DEBUG]add db debug in dev/e2e, by cammellos
💛 #9882 Fix failed faceid clears auth settings, by Ferossgp
💛 #9868 Move chat dialogs to bottom sheet, by Ferossgp
💛 #9800 [#9657] system messages ui changes in group chat, by ghmulti
💛 #9788 [#9748] eip681 parsing uri with whitespaces, by ghmulti
💛 #9390 Add web3.keycard.signTypedData, by siphiuel

MERGED PULL REQUEST

Last week, 19 pull requests were merged.
💜 #9959 Git ignore trace.edn and config.cljs, by Ferossgp
💜 #9951 fix hardcoded value in spanish translation, by yenda
💜 #9946 Explicitly start messenger, by cammellos
💜 #9944 Remove contact indicator from userpic, by Ferossgp
💜 #9942 [#9927] Fast blocks sync after being offline, by rasom
💜 #9936 [#9280] Make sure number-of-retries is not negative, by rasom
💜 #9935 Correctly dispatch on updates & disable them, by cammellos
💜 #9934 fastlane: disable oldest_build_allowed for TestFlight clean, by jakubgs
💜 #9926 Disable editprofile tests, by Serhy
💜 #9925 fix #9903 hide buttons of actions that are not yet implemented, by yenda
💜 #9923 add Augur token (REP) images, by yenda
💜 #9921 Fix e2e after removed custom pic, by Serhy
💜 #9919 [Fixes: #9900] Use component-did-update, by cammellos
💜 #9916 [9853] add missing translatable labels, by yenda
💜 #9913 Fire request once network status changes & periodically check connection, by cammellos
💜 #9899 update Itanlian, Arabic, Spanish, Chinese and Korean, by jinhojang6
💜 #9894 disable custom picture, by yenda
💜 #9812 Use default keyboard for username input, by Ferossgp
💜 #9811 Open app by ens name, by Ferossgp

---

COMMITS

Last week there were 19 commits.
🛠️ Git ignore trace.edn and config.cljs They are auto generated and should not be present in git Signed-off-by: Gheorghe Pinzaru feross95@gmail.com by Ferossgp
🛠️ Remove contact indicator from userpic Add contact indicator in 1:1 as a text. Fixes #9826 Fix e2e explicitly define line height On android and iOs line height is different, explicitly define so it will be the same in both platforms. Signed-off-by: Gheorghe Pinzaru feross95@gmail.com by Ferossgp
🛠️ fix hardcoded value in spanish translation Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by yenda
🛠️ fix #9903 hide buttons of actions that are not yet implemented fix ens release button which showed a hardcoded date link to release instructions on hackmd Signed-off-by: yenda eric@status.im by yenda
🛠️ [#9927] Fast blocks sync after being offline Front end changes: As there is no guarantee that newblock event will be dispatched consequently (e.g. if there was a delay after block#1 the next event might be dispatched for a block#2000, no guarantee that block#2 will be the next one), newTransactions field was added with a map of accounts to the number of new transactions received to this block. In result if there are new transactions we request them all of db instead of fetching them on for the block specified in newblock event, as it was done previously. Back end changes: - In order to avoid handling of the reorganized blocks we use an offset from the latest known block when start listening to new blocks. Before this commit the offset was 15 blocks for all networks. This offset is too big for mainnet and causes noticeable delay of marking a transfer as confirmed in Status (comparing to etherscan). So it was changed to be 5 blocks on mainnet and is still 15 blocks on other networks. - Also before this commit all new blocks were handled one by one with network specific interval (10s for mainnet), which means that in case of lost internet connection or application suspension (happens on iOS) receiving of new blocks would be paused and then resumed with the same "speed" - 1 blocks per 10s. In case if that pause is big enough the application would never catch up with the latest block in the network, and this also causes the state of transfers to be delayed in the application. In this commit in case if there was more than 40s delay after receiving of the previous block the whole history in range between the previous received block and ("latest"-reorgeSafetyDepth) block is checked at once and app catches up with a recent state of the chain. by rasom
🛠️ update Italian, Arabic, Spanish(LatAm), Chinese and Korean Signed-off-by: Andrey Shovkoplyas motor4ik@gmail.com by jinhojang6
🛠️ Explicitly start messenger We should only start receiving messages/processing topics once all the initializiation is completed, so an endpoint that start the messenger has been added. Before we would initialize the topics/receiving messages at the same time, which resulted in a race condition where a topic was signaled from status-go and was considered new just because was not loaded yet. Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ fastlane: disable oldest_build_allowed for TestFlight clean Signed-off-by: Jakub Sokołowski jakub@status.im by jakubgs
🛠️ Disable editprofile tests Signed-off-by: Serhy sergii@status.im by Serhy
🛠️ Correctly dispatch on updates & disable them Signed-off-by: Andrea Maria Piana andrea.maria.piana@gmail.com by cammellos
🛠️ [#9280] Make sure number-of-retries is not negative by rasom
🛠️ Support universal link for ens name Handle ens-name in qr reader If user has an username generate link with it Ensure no infinite recursion happens on qr scan event Fix test for custom profile ens-name Fix QR code read for ens-name Extra check for ens name in QR code Do not open unknown profile for bad ens name Signed-off-by: Gheorghe Pinzaru feross95@gmail.com by Ferossgp
🛠️ add Augur token (REP) images Signed-off-by: yenda eric@status.im by yenda
🛠️ Fix e2e after removed custom pic Signed-off-by: Serhy sergii@status.im by Serhy
🛠️ [Fixes: #9900] Use component-did-update When moving from chat to chat, component-did-mount is not fired as the component is never unmounted, therefore messages were not loaded. This changes the behavior to use the component-did-update lifecycle method. Signed-off-by: yenda eric@status.im by cammellos
🛠️ disable custom picture Signed-off-by: yenda eric@status.im by yenda
🛠️ Use default keyboard for username input Signed-off-by: yenda eric@status.im by Ferossgp
🛠️ [9853] add missing translatable labels Signed-off-by: yenda eric@status.im by yenda
🛠️ Fire request once network status changes & periodically check connection This commit fixes a couple of issues. The first one is that when we go from offline->cellular-network->wifi historical requests were not triggered (only when going from offline->online, but if they are disabled in cellular network they won't fire). The second is due to the fact that it is possible that the connection status gets into a bad state, (this happens for example if get-latency returns all errors, but we are online, and it won't be retried), and no connection attempt is made anymore. I have changed the logic to periodically check the connection state, and try to connect if too much time has passed since last error (10s), similarly to what we did before, but in a tick, so we are less reliant on having the right state in the db. Signed-off-by: yenda eric@status.im by cammellos

---

CONTRIBUTORS

Last week there were 7 contributors.
👤 Ferossgp
👤 yenda
👤 rasom
👤 jinhojang6
👤 cammellos
👤 jakubgs
👤 Serhy

---

STARGAZERS

Last week there were 7 stagazers.
⭐ a1300
⭐ Alan-love
⭐ DevenLu
⭐ louisl98
⭐ jpcloureiro
⭐ ghmulti
⭐ grdnrt
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository status-im/status-react to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆