Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9280] Make sure number-of-retries is not negative #9936

Merged
merged 1 commit into from
Jan 28, 2020
Merged

[#9280] Make sure number-of-retries is not negative #9936

merged 1 commit into from
Jan 28, 2020

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Jan 28, 2020 •
edited
Loading

This pr should fix @Ferossgp's "ddos" problem.

status: ready

@rasom rasom requested a review from a team as a code owner January 28, 2020 14:24
@auto-assign auto-assign bot removed the request for review from a team January 28, 2020 14:24
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@rasom rasom merged commit 9dfb908 into develop Jan 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/negative-number-of-retries branch January 28, 2020 14:33
@status-im-auto
Copy link
Member

status-im-auto commented Jan 28, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9dfb908 #1 2020-01-28 14:35:17 ~10 min ios 📦ipa 📲
✔️ 9dfb908 #1 2020-01-28 14:35:54 ~10 min android-e2e 📦apk 📲
✔️ 9dfb908 #1 2020-01-28 14:38:19 ~13 min android 📦apk 📲

@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda approved these changes

@Ferossgp Ferossgp Awaiting requested review from Ferossgp

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasom @status-im-auto @yenda