Rework and update react-navigation #9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (72)
|
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
67ff9d6
to
dd28d1b
Compare
|
@Ferossgp, probably you know, we have custom two-pane navigator that should be used for desktop and for tablets. I'm curious if its functionality survived upgrade to react-navigation 4? :) |
|
@vkjr UI wise it works, but it should be updated cause navigation object structure was changed, so it throws error during navigation events. |
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
dd28d1b
to
31ec971
Compare
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
31ec971
to
c6fdd30
Compare
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
c6fdd30
to
89e10e7
Compare
2 similar comments
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
89e10e7
to
5fd0c7a
Compare
1 similar comment
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
5fd0c7a
to
c3df303
Compare
45% of end-end tests have passedFailed tests (53)Click to expand
Passed tests (43)Click to expand |
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
679a9c3
to
f4b9a76
Compare
|
@Ferossgp there is a typo in formatting ( |
yenda
reviewed
Mar 15, 2020
|
TODO: Add on-blur for screens to handle this case #10168 |
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
f4b9a76
to
0fcee2f
Compare
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
0fcee2f
to
96c134e
Compare
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
96c134e
to
da88f08
Compare
Get rid of navigation wrapper Use new API to declare navigation Update tabbar component Update to use new navigation events Add ios presentation modal Navigation cleanups Android specific updates Use letsubs for stack subscriptions Keycard did load event backward compatibility Fix tabbar and wallet on-focus bad rebase Do not keep welcome screen into the stack Comment outdated test Fix rebase on home PR Cancel back button on screens which can't be popped Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
rework-and-update-navigation
branch
from
da88f08
to
d823a20
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses react-navigation 5 and removes the legacy navigation code.
The separate tasks to be added: