Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code won't close from wallet screen #9992

Closed
rachelhamlin opened this issue Feb 6, 2020 · 3 comments
Closed

QR code won't close from wallet screen #9992

rachelhamlin opened this issue Feb 6, 2020 · 3 comments

Comments

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Feb 6, 2020

Bug Report

Problem

Reported by Jarrad:

When QR code is opened from wallet > individual account > share button, and back button is then pressed, QR code does not close and remains on wallet overview.

Expected behavior

QR code panel is closed when user goes back.

Actual behavior

QR code remains on wallet overview screen.

Notes

Can not reproduce on iOS.

Reproduction

  • Go to wallet
  • Open an individual wallet
  • Press the share button to bring up QR code
  • Press back button

Additional Information

Samsung Galaxy Fold on RC 9

@flexsurfer
Copy link
Member

flexsurfer commented Feb 6, 2020

hardware back button ? yeah to fix that, popover should be a screen , and bottom sheet as well @errorists @Ferossgp

@flexsurfer
Copy link
Member

its even worst with sending tx from chat, you can open tx bottom sheet, and go back to chats screen, and dunno what will happen when you send this tx from chats screen

@flexsurfer
Copy link
Member

could be fixed here : #9945

Ferossgp added a commit that referenced this issue Mar 17, 2020
Closes all popovers. Fixes #9992
Ferossgp added a commit that referenced this issue Mar 17, 2020
Closes all popovers. Fixes #9992
Ferossgp added a commit that referenced this issue Mar 18, 2020
Closes all popovers. Fixes #9992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants