Make bottom sheet height dynamical #9915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (38)
|
Ferossgp
force-pushed
the
make-bottom-sheet-dynamical
branch
7 times, most recently
from
75b9529
to
ca991b9
Compare
|
still wip? |
|
@flexsurfer yes, there is one small bug with animation during pan responder. I'm thinking on how to fix it now. |
Ferossgp
force-pushed
the
make-bottom-sheet-dynamical
branch
from
ca991b9
to
340b0b5
Compare
Ferossgp
force-pushed
the
make-bottom-sheet-dynamical
branch
from
340b0b5
to
2741fd1
Compare
Ferossgp
changed the title
Ferossgp
commented
Feb 19, 2020
flexsurfer
approved these changes
Feb 27, 2020
|
@Ferossgp give me please 1h for review, do not merge it now |
Ferossgp
force-pushed
the
make-bottom-sheet-dynamical
branch
2 times, most recently
from
5e91c2d
to
c5e720d
Compare
|
If I slowly slide bottom sheet down it suddenly disappears with no animation at all:
|
rasom
suggested changes
Feb 27, 2020
|
@rasom this happens because the velocity is big enough to close, I could empirically increase it to 0.4, wdyt? |
|
The only problem (or at least difference comparing to what we have in
current branch: |
rasom
approved these changes
Feb 27, 2020
|
Tested on IPhone 7(IOS 13) and Xiaomi Mi Note 9 (Android 10) Agreed with #9915 (comment), don't think that's the blocker. Tested with 11 accounts in mutiaccounts, 7 names in ENS names and with options in chat / browser. |
|
Agree, I don't think the overdrag issue is that big of a deal |
Fixes #9848 Update initial content height Review followup Fix sheet disappear during drag Signed-off-by: Gheorghe Pinzaru <feross95@gmail.com>
Ferossgp
force-pushed
the
make-bottom-sheet-dynamical
branch
from
46b2bda
to
3ad9cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test max height one can add multiple accounts and see how it changes inside browser account select.
Fixes #9848